Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124160/?format=api
{ "id": 124160, "url": "http://patches.dpdk.org/api/patches/124160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230219231416.22524-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230219231416.22524-6-stephen@networkplumber.org", "date": "2023-02-19T23:14:12", "name": "[v4,5/9] ip_frag: enable build on Windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2b067f4f0b8cca91735ce4c6c2b8aaa5cd86ddcc", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 27076, "url": "http://patches.dpdk.org/api/series/27076/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27076", "date": "2023-02-19T23:14:07", "name": "Enable building more libraries on Windows", "version": 4, "mbox": "http://patches.dpdk.org/series/27076/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124160/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124160/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 970FC41CE4;\n\tMon, 20 Feb 2023 00:14:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E02E042DAA;\n\tMon, 20 Feb 2023 00:14:32 +0100 (CET)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id 5A9FD42D8A\n for <dev@dpdk.org>; Mon, 20 Feb 2023 00:14:25 +0100 (CET)", "by mail-pl1-f172.google.com with SMTP id w10so1577023ply.11\n for <dev@dpdk.org>; Sun, 19 Feb 2023 15:14:25 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n l10-20020a170902d34a00b00192fe452e17sm683336plk.162.2023.02.19.15.14.23\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Feb 2023 15:14:23 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WGyFr6jmzcgM1aDdQp/EBErjnXov/ZmiUN0fVa/gzjE=;\n b=LjLGZAIaXzEaYYYQtf3ShQW8dL7vx1dYHRhM+d/3wquVgixga0JPVV58igHN+g/Wr5\n QZBPhvclQDYlgcek7j2X6KY7VamC7a6VA7g1UcwAvvY94Tce5GkPVnvPHCStcQ2OnPfA\n 8kH7EuC2utP4S1VpyHiZstXhMVfluDGm0ue7PFJHnIaaKCKu6IfzCYDi4VwZ62Us7UE/\n cyz7FGfm0hxV+V8xdEOpALfD7PAqmViZ+04ur2W8Le82P1jzeHJP00aajoFZl212/TVt\n LqM32JV3DMHbBSGJQhHIoK8bkBhjab+27p8d7b5bPN6KHfXINeEX20Hs/eedrpgeV6jm\n NDSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=WGyFr6jmzcgM1aDdQp/EBErjnXov/ZmiUN0fVa/gzjE=;\n b=ltabn7/d/wzRADS9ZuyHXGvOl/exJccvKleqbgEyXFOqdWRQa3C1J1x9x4+ZD6nNzw\n f73eVet/VT2MctquY6zvjEK5VTVT7/Ffde2xk67le01zPDVq45pM57rp7nUjmj41+Whu\n Mqlzddl+LSde9YYHaxUVEYtMohSLXGPiDzcjX7KNOQShjOHde80ekyZaS1EFw0+EeNCO\n BEXkO9qMzXUVNnkJWiolPMevwz/4K4Y1+f+4oRBBFzVeDL9YaFl3+ayMgO8i0juoq1Gn\n phnsVae329DtydCxwMnzNQgdHrwF7Mvgryu9H+Cr0n2cZfvCoeLASN3ZHCP0QPXvyXR+\n YBng==", "X-Gm-Message-State": "AO0yUKUGIEMvkssi4N/2vqQxtl7bk/s5USrgv6RLqLefS5vnBCxPhj0B\n IC+5ICza/lV7q4XlmD1h68xjR4wJGQr5+MdIIFs=", "X-Google-Smtp-Source": "\n AK7set9hek6pkodVT5kZ2YR9Ptx88wYZCFOOxaD1iEsiVwu4we4nh1dAzi7y1vT3eudlKskzwH9Q2A==", "X-Received": "by 2002:a17:902:ce91:b0:19a:82f0:7b0f with SMTP id\n f17-20020a170902ce9100b0019a82f07b0fmr1031664plg.30.1676848464346;\n Sun, 19 Feb 2023 15:14:24 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[PATCH v4 5/9] ip_frag: enable build on Windows", "Date": "Sun, 19 Feb 2023 15:14:12 -0800", "Message-Id": "<20230219231416.22524-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230219231416.22524-1-stephen@networkplumber.org>", "References": "<20230207001937.875608-1-stephen@networkplumber.org>\n <20230219231416.22524-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This build works on Windows if sys/queue.h is included.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/test_ipfrag.c | 12 ------------\n lib/ip_frag/ip_frag_common.h | 2 ++\n lib/ip_frag/meson.build | 6 ------\n 3 files changed, 2 insertions(+), 18 deletions(-)", "diff": "diff --git a/app/test/test_ipfrag.c b/app/test/test_ipfrag.c\nindex 88cc4cdeea8d..402ce361c1a2 100644\n--- a/app/test/test_ipfrag.c\n+++ b/app/test/test_ipfrag.c\n@@ -10,17 +10,6 @@\n #include <rte_cycles.h>\n #include <rte_hexdump.h>\n #include <rte_ip.h>\n-\n-#ifdef RTE_EXEC_ENV_WINDOWS\n-static int\n-test_ipfrag(void)\n-{\n-\tprintf(\"ipfrag not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-#else\n-\n #include <rte_ip_frag.h>\n #include <rte_mbuf.h>\n #include <rte_random.h>\n@@ -520,6 +509,5 @@ test_ipfrag(void)\n \treturn unit_test_suite_runner(&ipfrag_testsuite);\n }\n \n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n \n REGISTER_TEST_COMMAND(ipfrag_autotest, test_ipfrag);\ndiff --git a/lib/ip_frag/ip_frag_common.h b/lib/ip_frag/ip_frag_common.h\nindex 9c0dbdeb6eb9..0f4ad72a90d9 100644\n--- a/lib/ip_frag/ip_frag_common.h\n+++ b/lib/ip_frag/ip_frag_common.h\n@@ -8,6 +8,8 @@\n #include \"rte_ip_frag.h\"\n #include \"ip_reassembly.h\"\n \n+#include <sys/queue.h>\n+\n /* logging macros. */\n #ifdef RTE_LIBRTE_IP_FRAG_DEBUG\n #define\tIP_FRAG_LOG(lvl, fmt, args...)\tRTE_LOG(lvl, USER1, fmt, ##args)\ndiff --git a/lib/ip_frag/meson.build b/lib/ip_frag/meson.build\nindex 3a252bdaf6a4..ea2de09f7528 100644\n--- a/lib/ip_frag/meson.build\n+++ b/lib/ip_frag/meson.build\n@@ -1,12 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-if is_windows\n- build = false\n- reason = 'not supported on Windows'\n- subdir_done()\n-endif\n-\n sources = files(\n 'rte_ipv4_fragmentation.c',\n 'rte_ipv6_fragmentation.c',\n", "prefixes": [ "v4", "5/9" ] }