Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124157/?format=api
{ "id": 124157, "url": "http://patches.dpdk.org/api/patches/124157/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230219231416.22524-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230219231416.22524-3-stephen@networkplumber.org", "date": "2023-02-19T23:14:09", "name": "[v4,2/9] net/ring: build on Windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "05c809d3520d9755a74d80d55b8c6bee136c4951", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230219231416.22524-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 27076, "url": "http://patches.dpdk.org/api/series/27076/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=27076", "date": "2023-02-19T23:14:07", "name": "Enable building more libraries on Windows", "version": 4, "mbox": "http://patches.dpdk.org/series/27076/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/124157/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/124157/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04F0741CE4;\n\tMon, 20 Feb 2023 00:14:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 58C3742D8E;\n\tMon, 20 Feb 2023 00:14:29 +0100 (CET)", "from mail-pl1-f177.google.com (mail-pl1-f177.google.com\n [209.85.214.177])\n by mails.dpdk.org (Postfix) with ESMTP id 67BCA40691\n for <dev@dpdk.org>; Mon, 20 Feb 2023 00:14:22 +0100 (CET)", "by mail-pl1-f177.google.com with SMTP id j7so1776803plh.5\n for <dev@dpdk.org>; Sun, 19 Feb 2023 15:14:22 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n l10-20020a170902d34a00b00192fe452e17sm683336plk.162.2023.02.19.15.14.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 19 Feb 2023 15:14:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=YlQk95R+o2GZ1yE7eW56Qjn3lhaJLbMjvt10+rGFfQY=;\n b=to82pKblycJPBI+6+Mps54spqDiKc732xcOkXbH0hhwzwBy0fNTMueg6IASN8uoJHy\n 1YzgPEKy1hLq5IuGecJWNQyyUD1XT+qc3NPwo4fNG1qpLBI0/Mi7KiimLk+T59WJUdRW\n I7r72VbTsYTOAKY6SKgGitb5xE/Qd98wa566MHg8Sqo4x9YmDmV3RjuS1/GGB3lupH+p\n 3Jk5/XxehXp3bho9XJUc/HvjijiEUYduDeEnBw1qa/QuA8HD/Ow5/hBpvFBPaPBhted6\n C7D4IjT8Rhkh5G3QlnIukma3qYtOOkvYS1oi3AnWLAyocCYRh4ocHqZKS3t8VHTOm28g\n IhRA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=YlQk95R+o2GZ1yE7eW56Qjn3lhaJLbMjvt10+rGFfQY=;\n b=f//rsLIrFv0sEdbNQxmcXpvVLQWJNKlXVQrbuitxx+1YkMrnMDmTljtyyuaBNtL8TJ\n g/DjApTs2dUqGi13sRQAuhS3qt8EFVeyzsta0m+X3uCpf7+JsAI0c/YpjxNz91Q++A+Z\n at2fgqMJ2UN2PXcfhwRWLL0shEpAFaGoLvByJSLzY4sxNMlDRlFP6prG02B3BBECVoKM\n aNPO38Pv2aXHVA3d1JL81cUBtJfBDasyqLDSgL9SfvSbJpYRZ3R2ncCsQOT+uYl8a9wB\n YDyRCvLiODxRZpOtItnrhkg+tXg/LaXcnKIOWWbn5UpDYB3D3ViYYPMabS6XzccD6BDY\n so3Q==", "X-Gm-Message-State": "AO0yUKU8S5j0k/2auLmf4LLn4BG6McjEiDCF+h4tpYJ0NT2D7Ek7P3KU\n fNs/2p/1ZYRSQc5VrRFO/aK8M/dWCVhhLzXEYo8=", "X-Google-Smtp-Source": "\n AK7set+Uon4TTFV3YWthZ+xiH10IBVlbswiTY3Y10Pd9FbV2xwkLIctFoSFkhnXmSRidO9LnOX08Bg==", "X-Received": "by 2002:a17:902:da90:b0:19a:a9d8:e49f with SMTP id\n j16-20020a170902da9000b0019aa9d8e49fmr2780919plx.39.1676848461390;\n Sun, 19 Feb 2023 15:14:21 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v4 2/9] net/ring: build on Windows", "Date": "Sun, 19 Feb 2023 15:14:09 -0800", "Message-Id": "<20230219231416.22524-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230219231416.22524-1-stephen@networkplumber.org>", "References": "<20230207001937.875608-1-stephen@networkplumber.org>\n <20230219231416.22524-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The command line arguments are stored in node_action_pair\nand the name[] was sized to PATH_MAX which does not exist on Windows.\nSince the name is either \"CREATE\" or \"ATTACH\" it is not\nrelated to PATH_MAX (4096).\n\nWith this fix driver builds ok on windows, but need to modify the\ntest meson build to skip the eventdev test on Windows.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n app/test/meson.build | 2 +-\n drivers/net/ring/meson.build | 6 ------\n drivers/net/ring/rte_eth_ring.c | 4 +++-\n 3 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex f34d19e3c3cb..a713f0382280 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -390,7 +390,7 @@ if dpdk_conf.has('RTE_NET_BOND')\n driver_test_names += 'link_bonding_mode4_autotest'\n endif\n endif\n-if dpdk_conf.has('RTE_NET_RING')\n+if dpdk_conf.has('RTE_LIB_EVENTDEV') and dpdk_conf.has('RTE_NET_RING')\n test_deps += 'net_ring'\n test_sources += 'test_pmd_ring_perf.c'\n test_sources += 'test_pmd_ring.c'\ndiff --git a/drivers/net/ring/meson.build b/drivers/net/ring/meson.build\nindex 72792e26b05a..3534a3cc2287 100644\n--- a/drivers/net/ring/meson.build\n+++ b/drivers/net/ring/meson.build\n@@ -1,12 +1,6 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-if is_windows\n- build = false\n- reason = 'not supported on Windows'\n- subdir_done()\n-endif\n-\n sources = files('rte_eth_ring.c')\n headers = files('rte_eth_ring.h')\n pmd_supports_disable_iova_as_pa = true\ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex bd5a47dd9017..e8bc9b627102 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -9,6 +9,7 @@\n #include <ethdev_driver.h>\n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n+#include <rte_os_shim.h>\n #include <rte_string_fns.h>\n #include <bus_vdev_driver.h>\n #include <rte_kvargs.h>\n@@ -17,6 +18,7 @@\n #define ETH_RING_NUMA_NODE_ACTION_ARG\t\"nodeaction\"\n #define ETH_RING_ACTION_CREATE\t\t\"CREATE\"\n #define ETH_RING_ACTION_ATTACH\t\t\"ATTACH\"\n+#define ETH_RING_ACTION_MAX_LEN\t\t8 /* CREATE | ACTION */\n #define ETH_RING_INTERNAL_ARG\t\t\"internal\"\n #define ETH_RING_INTERNAL_ARG_MAX_LEN\t19 /* \"0x..16chars..\\0\" */\n \n@@ -539,7 +541,7 @@ eth_dev_ring_create(const char *name,\n }\n \n struct node_action_pair {\n-\tchar name[PATH_MAX];\n+\tchar name[ETH_RING_ACTION_MAX_LEN];\n \tunsigned int node;\n \tenum dev_action action;\n };\n", "prefixes": [ "v4", "2/9" ] }