Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123765/?format=api
{ "id": 123765, "url": "http://patches.dpdk.org/api/patches/123765/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230213071440.326064-1-ke1x.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230213071440.326064-1-ke1x.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230213071440.326064-1-ke1x.zhang@intel.com", "date": "2023-02-13T07:14:40", "name": "[v2] net/ice: fix ice dcf contrl thread crash", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba53c70ff71e259536a0d950ef203f4b2c6521e9", "submitter": { "id": 2503, "url": "http://patches.dpdk.org/api/people/2503/?format=api", "name": "Zhang, Ke1X", "email": "ke1x.zhang@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230213071440.326064-1-ke1x.zhang@intel.com/mbox/", "series": [ { "id": 26973, "url": "http://patches.dpdk.org/api/series/26973/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26973", "date": "2023-02-13T07:14:40", "name": "[v2] net/ice: fix ice dcf contrl thread crash", "version": 2, "mbox": "http://patches.dpdk.org/series/26973/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123765/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/123765/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C028641C84;\n\tMon, 13 Feb 2023 08:31:00 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD65040DDB;\n\tMon, 13 Feb 2023 08:31:00 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 051CC40A81\n for <dev@dpdk.org>; Mon, 13 Feb 2023 08:30:58 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Feb 2023 23:30:08 -0800", "from unknown (HELO localhost.localdomain) ([10.239.252.104])\n by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Feb 2023 23:30:06 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1676273459; x=1707809459;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=OGcJKlZKmGGpEy4T0FRTupYmc6zRJihLr8EAtE3Dguk=;\n b=hOTqsOVfuQbrKRLPw+nKnIxKEiUuyC5UhveeZfKvsgDQRuPutS1A8d5D\n YqkuCzVX3pyDF0YO+M5gag7M0ZduFMDh7+5W++3iiw2GFqa13ITnXTZE/\n OyHe3cLo0FBnWhntRca7kY2ZqH8MSNs9ja5ujkWcvbKxxMKOIVofvyi/Z\n V7L7qOvm+W9OAip203UL/U4XkyryKqb+HHzBJT6f8RYINhd8r3slFVBDA\n Hb2LY2DO2T0l7xFzVCGRpIZbtYUO8h/RhWjLVPjaIiWQW36uJ/fiKswpm\n 8pjDHxFxDzjlbnThKsaDL+gldt4m1gkhplesfJ+bjVrmQhSS1DJo8pL3k Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10619\"; a=\"332137616\"", "E=Sophos;i=\"5.97,293,1669104000\"; d=\"scan'208\";a=\"332137616\"", "E=McAfee;i=\"6500,9779,10619\"; a=\"737415750\"", "E=Sophos;i=\"5.97,293,1669104000\"; d=\"scan'208\";a=\"737415750\"" ], "From": "Ke Zhang <ke1x.zhang@intel.com>", "To": "qi.z.zhang@intel.com,\n\tqiming.yang@intel.com,\n\tdev@dpdk.org", "Cc": "Ke Zhang <ke1x.zhang@intel.com>", "Subject": "[PATCH v2] net/ice: fix ice dcf contrl thread crash", "Date": "Mon, 13 Feb 2023 15:14:40 +0800", "Message-Id": "<20230213071440.326064-1-ke1x.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230208083005.290571-1-ke1x.zhang@intel.com>", "References": "<20230208083005.290571-1-ke1x.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The control thread accesses the hardware resources after the\nresources were released, resulting in a segment error.\n\nThis commit fixes the bug by exiting thread before resource released.\n\nSigned-off-by: Ke Zhang <ke1x.zhang@intel.com>\n---\nv2: add pthread_exit() for windows\n---\n drivers/net/ice/ice_dcf.c | 4 ++++\n lib/eal/windows/include/pthread.h | 5 +++++\n 2 files changed, 9 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c\nindex 1c3d22ae0f..e58908caf5 100644\n--- a/drivers/net/ice/ice_dcf.c\n+++ b/drivers/net/ice/ice_dcf.c\n@@ -543,6 +543,8 @@ ice_dcf_handle_vsi_update_event(struct ice_dcf_hw *hw)\n \tice_dcf_disable_irq0(hw);\n \n \tfor (;;) {\n+\t\tif (hw->vc_event_msg_cb == NULL)\n+\t\t\tpthread_exit(NULL);\n \t\tif (ice_dcf_get_vf_resource(hw) == 0 &&\n \t\t ice_dcf_get_vf_vsi_map(hw) >= 0) {\n \t\t\terr = 0;\n@@ -760,6 +762,8 @@ ice_dcf_uninit_hw(struct rte_eth_dev *eth_dev, struct ice_dcf_hw *hw)\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t ice_dcf_dev_interrupt_handler, hw);\n \n+\thw->vc_event_msg_cb = NULL;\n+\n \tice_dcf_mode_disable(hw);\n \tiavf_shutdown_adminq(&hw->avf);\n \ndiff --git a/lib/eal/windows/include/pthread.h b/lib/eal/windows/include/pthread.h\nindex 27fd2cca52..f0068ebd73 100644\n--- a/lib/eal/windows/include/pthread.h\n+++ b/lib/eal/windows/include/pthread.h\n@@ -149,6 +149,11 @@ pthread_detach(__rte_unused pthread_t thread)\n \treturn 0;\n }\n \n+static inline void\n+pthread_exit(__rte_unused void *__retval)\n+{\n+}\n+\n static inline int\n pthread_join(__rte_unused pthread_t thread,\n \t__rte_unused void **value_ptr)\n", "prefixes": [ "v2" ] }