Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123621/?format=api
{ "id": 123621, "url": "http://patches.dpdk.org/api/patches/123621/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230210002222.812379-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230210002222.812379-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230210002222.812379-3-stephen@networkplumber.org", "date": "2023-02-10T00:22:19", "name": "[v3,2/5] reorder: use a dynamic logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "37b90fa15fad1cefada9e9b9f425322f0adf3ffe", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230210002222.812379-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 26934, "url": "http://patches.dpdk.org/api/series/26934/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26934", "date": "2023-02-10T00:22:17", "name": "Replace use of RTE_LOGTYPE_USER1 in library", "version": 3, "mbox": "http://patches.dpdk.org/series/26934/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123621/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123621/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 635B741C56;\n\tFri, 10 Feb 2023 01:22:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 70C5F42BAC;\n\tFri, 10 Feb 2023 01:22:30 +0100 (CET)", "from mail-pf1-f181.google.com (mail-pf1-f181.google.com\n [209.85.210.181])\n by mails.dpdk.org (Postfix) with ESMTP id 4B8B8410F9\n for <dev@dpdk.org>; Fri, 10 Feb 2023 01:22:28 +0100 (CET)", "by mail-pf1-f181.google.com with SMTP id 144so2453309pfv.11\n for <dev@dpdk.org>; Thu, 09 Feb 2023 16:22:28 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n g9-20020aa78749000000b005907664a3eesm1986639pfo.125.2023.02.09.16.22.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Feb 2023 16:22:26 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KZgfsFOvebHmT9+dLkYUNEfM3BYjfInGf2AA4yLuCd4=;\n b=4yKMW8vGI9PDhaofrEjqczro0HpOELxZ2+jDn9RYNGM+u1ljdCFEc+1BaLDiXjHjWW\n HeZ0a7AB46H8GkGIDjVnHm68DvtB1loXvRnrG7Quz9xgSk9+J/ydN2kn2iobqoDpUaMw\n hbMRVaywoSD34SyApYVZB7gafr4r7Xe0Rj0TqOjpPxfXhZ55/NBb1kYRUQcKpNUpNnmL\n +uNvbOoLyZbrJYybUsobgHNledGPYwqLIfqypYTFVroAC8ct5YNfYCIz8RyTGUwI3/mN\n uOwnB4fu8htiBmNunu+TS7EA9aOCFsKm2SHgBP7jXTNjTGqjX3vmeNfJ2cOYLtI4Ewu9\n LO6A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=KZgfsFOvebHmT9+dLkYUNEfM3BYjfInGf2AA4yLuCd4=;\n b=K0x4bmJNA6NapdDNJSAs3v2lhb4Y96rrxK4/BOtmfl7qWiF/nFyLjqQLIk/XfMMsgt\n 3Y6PBVLGSzu6rldpYS84xfj9LFmT5Vywu8M8oORCl0rVlPV5q7zi5jreqfwiGB901lBk\n 4cqw9MAe3zlxWIomIcrroKHV9IEUC5V0y4miHC49hwahvpFqFwuv4QDuIUl8xw1Tp9Eg\n UJgbE0BKFdBIKgqHSv4wMixPS/HTPV27YiXMDhnonx8E3Vs118TOo5Ie8/L+fZKF+0dW\n iL0VoCIIuOlRlvbdSEaEYNEV7U4skgmagKYXhRlAEM9mWtRIM2x544YQt1FSqoPrq16G\n cf0A==", "X-Gm-Message-State": "AO0yUKWmDn1hlE35yc+TlVNgsxZumFXH2aSjihc6pWsXsMkHnOdtsTvq\n +vyD7Hjzg+8emFcsPZDnzzbX24JanQHraUzfdjI=", "X-Google-Smtp-Source": "\n AK7set+VIe3hjYnzbIQthkJp1f9rhia9RdbV9+0cX0G5HOpPy/5qr736x8Ku6USHjhn6WmYnTlq0Uw==", "X-Received": "by 2002:a62:1d44:0:b0:5a8:4c9d:6237 with SMTP id\n d65-20020a621d44000000b005a84c9d6237mr5896462pfd.21.1675988547443;\n Thu, 09 Feb 2023 16:22:27 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n sergio.gonzalez.monroy@intel.com, Reshma Pattan <reshma.pattan@intel.com>,\n Neil Horman <nhorman@tuxdriver.com>,\n Richardson Bruce <bruce.richardson@intel.com>,\n Declan Doherty <declan.doherty@intel.com>", "Subject": "[PATCH v3 2/5] reorder: use a dynamic logtype", "Date": "Thu, 9 Feb 2023 16:22:19 -0800", "Message-Id": "<20230210002222.812379-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230210002222.812379-1-stephen@networkplumber.org>", "References": "<20230208044825.1682620-1-stephen@networkplumber.org>\n <20230210002222.812379-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Libraries should not be reusing RTE_LOGTYPE_USER1 instead\nof doing proper logtype registration.\n\nFixes: b70b56032bff (\"reorder: new library\")\nCc: sergio.gonzalez.monroy@intel.com\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/reorder/rte_reorder.c | 35 +++++++++++++++++++----------------\n 1 file changed, 19 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c\nindex 385ee479da42..c9ae42e71783 100644\n--- a/lib/reorder/rte_reorder.c\n+++ b/lib/reorder/rte_reorder.c\n@@ -27,7 +27,11 @@ EAL_REGISTER_TAILQ(rte_reorder_tailq)\n #define RTE_REORDER_NAMESIZE 32\n \n /* Macros for printing using RTE_LOG */\n-#define RTE_LOGTYPE_REORDER\tRTE_LOGTYPE_USER1\n+RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO);\n+\n+#define REORDER_LOG(level, fmt, args...)\t\t\\\n+\trte_log(RTE_LOG_ ## level, reorder_logtype,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n \n #define RTE_REORDER_SEQN_DYNFIELD_NAME \"rte_reorder_seqn_dynfield\"\n int rte_reorder_seqn_dynfield_offset = -1;\n@@ -62,26 +66,25 @@ rte_reorder_init(struct rte_reorder_buffer *b, unsigned int bufsize,\n \t\t\t\t\t(2 * size * sizeof(struct rte_mbuf *));\n \n \tif (b == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer parameter:\"\n-\t\t\t\t\t\" NULL\\n\");\n+\t\tREORDER_LOG(ERR, \"Invalid reorder buffer parameter: NULL\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (!rte_is_power_of_2(size)) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer size\"\n-\t\t\t\t\" - Not a power of 2\\n\");\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Invalid reorder buffer size - Not a power of 2\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (name == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer name ptr:\"\n-\t\t\t\t\t\" NULL\\n\");\n+\t\tREORDER_LOG(ERR, \"Invalid reorder buffer name ptr: NULL\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (bufsize < min_bufsize) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer memory size: %u, \"\n-\t\t\t\"minimum required: %u\\n\", bufsize, min_bufsize);\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Invalid reorder buffer memory size: %u, minimum required: %u\",\n+\t\t\t bufsize, min_bufsize);\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n@@ -116,14 +119,13 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \n \t/* Check user arguments. */\n \tif (!rte_is_power_of_2(size)) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer size\"\n-\t\t\t\t\" - Not a power of 2\\n\");\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Invalid reorder buffer size - Not a power of 2\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (name == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer name ptr:\"\n-\t\t\t\t\t\" NULL\\n\");\n+\t\tREORDER_LOG(ERR, \"Invalid reorder buffer name ptr: NULL\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n@@ -131,7 +133,8 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \trte_reorder_seqn_dynfield_offset =\n \t\trte_mbuf_dynfield_register(&reorder_seqn_dynfield_desc);\n \tif (rte_reorder_seqn_dynfield_offset < 0) {\n-\t\tRTE_LOG(ERR, REORDER, \"Failed to register mbuf field for reorder sequence number\\n\");\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Failed to register mbuf field for reorder sequence number\");\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n@@ -150,7 +153,7 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \t/* allocate tailq entry */\n \tte = rte_zmalloc(\"REORDER_TAILQ_ENTRY\", sizeof(*te), 0);\n \tif (te == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Failed to allocate tailq entry\\n\");\n+\t\tREORDER_LOG(ERR, \"Failed to allocate tailq entry\");\n \t\trte_errno = ENOMEM;\n \t\tb = NULL;\n \t\tgoto exit;\n@@ -159,7 +162,7 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \t/* Allocate memory to store the reorder buffer structure. */\n \tb = rte_zmalloc_socket(\"REORDER_BUFFER\", bufsize, 0, socket_id);\n \tif (b == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Memzone allocation failed\\n\");\n+\t\tREORDER_LOG(ERR, \"Memzone allocation failed\");\n \t\trte_errno = ENOMEM;\n \t\trte_free(te);\n \t} else {\n", "prefixes": [ "v3", "2/5" ] }