Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123396/?format=api
{ "id": 123396, "url": "http://patches.dpdk.org/api/patches/123396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207230438.1617331-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207230438.1617331-12-stephen@networkplumber.org", "date": "2023-02-07T23:04:32", "name": "[RFC,v2,11/17] ring: replace RTE_LOGTYPE_RING with dynamic type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dd9db4bebbde099cf8cf0fcfc518c62e8b9df510", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 26874, "url": "http://patches.dpdk.org/api/series/26874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26874", "date": "2023-02-07T23:04:21", "name": "static logtype removal", "version": 2, "mbox": "http://patches.dpdk.org/series/26874/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123396/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C0AD341C34;\n\tWed, 8 Feb 2023 00:06:10 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6DD2642D5F;\n\tWed, 8 Feb 2023 00:05:20 +0100 (CET)", "from mail-pj1-f45.google.com (mail-pj1-f45.google.com\n [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id B2C1942D56\n for <dev@dpdk.org>; Wed, 8 Feb 2023 00:05:17 +0100 (CET)", "by mail-pj1-f45.google.com with SMTP id\n ge21-20020a17090b0e1500b002308aac5b5eso345711pjb.4\n for <dev@dpdk.org>; Tue, 07 Feb 2023 15:05:17 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n gq17-20020a17090b105100b0020dc318a43esm71189pjb.25.2023.02.07.15.05.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Feb 2023 15:05:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TGI+362xtBNoVKpNbOlux/TIyZ9au9Qd1CJOZexwK04=;\n b=sRgNBZMQXOSp5I+WWgSeo5hk292AWpiZs5bMgRaDRrvb+NuWpSIiXdlyJDKxdcvFeH\n hgn47fSoH1t0ECn5LpD4Bgkmz8fv2+BxQZFkTALw10Qc8CgDzv0vOZXsUESOeYhx8nWP\n OSAk98SVEzRkdLIiMMRvpOTNErtxf1m4wQuWcoXNV96v3riB9ra2ONEv4COnK+ngdHwV\n oONm+2/2Gp+XlxIowQNrc9aLXDe1v6TPLPO/fU6O9OLpUfeNS19Tu7vVcDgoGKdwvVgG\n eTqqHQncFAY0dVDADCcg+1TJ3xAu1zc3Drx+seRz8oQXjZDXpuGWf1kaQSRyBkcjPx/I\n TBIQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=TGI+362xtBNoVKpNbOlux/TIyZ9au9Qd1CJOZexwK04=;\n b=V5eaVx0NyfupuIIhTe4W0muPouS39x5Ar7Qkv8CpJE7ukou+Jcb6KFV+hs5Zf0Dga5\n raA/S4pYZNPIpqiTeY9jcpYjiUGJ/RLJnxxO3yANa8OEUPTiX5tTcIgvdyKPLv2KM1L4\n aINXPaBjeErRjyo63ZQaNbMTMkvPkZd2lkHhzfAgjY8Egdy/XNAC7I1vEOCPOT1x7TAq\n pnGToJVS1iMuf0e8cRz00lpwqztB1u9Al5vuZLJNLw/XllEs92rLtcfXXj5bhfH8mkNP\n nggxJCqKo5rwH7ft9ei/RAFzAbHHLiHU/2Ww4kJCMGaKbW8p0gF/KcKCxNNu8CEwg8O2\n 1UAA==", "X-Gm-Message-State": "AO0yUKVoLRIZJicRcoBXnF0RC6rfqawVKHEu4tCKhFBtdT1SoA20qxBL\n KOb/GO8x6aRASKJyA7LEmXL/QiJ/34+CnxzX5V4=", "X-Google-Smtp-Source": "\n AK7set+aES/601rvoOIJjnhqIjpN0OEAFaMDoc+rP+vjKz4KH+gJ7CfaTnzPaF+RBY6uOUW2bbR0mg==", "X-Received": "by 2002:a17:90a:313:b0:230:c87e:2b2d with SMTP id\n 19-20020a17090a031300b00230c87e2b2dmr5639302pje.40.1675811116614;\n Tue, 07 Feb 2023 15:05:16 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Subject": "[RFC v2 11/17] ring: replace RTE_LOGTYPE_RING with dynamic type", "Date": "Tue, 7 Feb 2023 15:04:32 -0800", "Message-Id": "<20230207230438.1617331-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230207230438.1617331-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230207230438.1617331-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The logtype for ring only used in library.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_log.c | 1 -\n lib/eal/include/rte_log.h | 2 +-\n lib/ring/rte_ring.c | 31 +++++++++++++++++++------------\n 3 files changed, 20 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c\nindex 7dbf1df3b979..04c9d43351da 100644\n--- a/lib/eal/common/eal_common_log.c\n+++ b/lib/eal/common/eal_common_log.c\n@@ -349,7 +349,6 @@ struct logtype {\n \n static const struct logtype logtype_strings[] = {\n \t{RTE_LOGTYPE_EAL, \"lib.eal\"},\n-\t{RTE_LOGTYPE_RING, \"lib.ring\"},\n \t{RTE_LOGTYPE_MEMPOOL, \"lib.mempool\"},\n \t{RTE_LOGTYPE_PMD, \"pmd\"},\n \t{RTE_LOGTYPE_HASH, \"lib.hash\"},\ndiff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rte_log.h\nindex 5b7850af4e2b..a99fe383c89b 100644\n--- a/lib/eal/include/rte_log.h\n+++ b/lib/eal/include/rte_log.h\n@@ -28,7 +28,7 @@ extern \"C\" {\n /* SDK log type */\n #define RTE_LOGTYPE_EAL 0 /**< Log related to eal. */\n \t\t\t\t /* was RTE_LOGTYPE_MALLOC */\n-#define RTE_LOGTYPE_RING 2 /**< Log related to ring. */\n+\t\t\t\t /* was RTE_LOGTYPE_RING */\n #define RTE_LOGTYPE_MEMPOOL 3 /**< Log related to mempool. */\n \t\t\t\t /* was RTE_LOGTYPE_TIMER */\n #define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver. */\ndiff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c\nindex cddaf6b2876f..1b4633468a2a 100644\n--- a/lib/ring/rte_ring.c\n+++ b/lib/ring/rte_ring.c\n@@ -26,6 +26,13 @@\n #include \"rte_ring.h\"\n #include \"rte_ring_elem.h\"\n \n+RTE_LOG_REGISTER_DEFAULT(ring_logtype, INFO);\n+\n+#define RING_LOG(level, fmt, args...)\t\t\t\\\n+\trte_log(RTE_LOG_ ## level, ring_logtype,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+\n+\n TAILQ_HEAD(rte_ring_list, rte_tailq_entry);\n \n static struct rte_tailq_elem rte_ring_tailq = {\n@@ -52,15 +59,15 @@ rte_ring_get_memsize_elem(unsigned int esize, unsigned int count)\n \n \t/* Check if element size is a multiple of 4B */\n \tif (esize % 4 != 0) {\n-\t\tRTE_LOG(ERR, RING, \"element size is not a multiple of 4\\n\");\n+\t\tRING_LOG(ERR, \"element size is not a multiple of 4\");\n \n \t\treturn -EINVAL;\n \t}\n \n \t/* count must be a power of 2 */\n \tif ((!POWEROF2(count)) || (count > RTE_RING_SZ_MASK )) {\n-\t\tRTE_LOG(ERR, RING,\n-\t\t\t\"Requested number of elements is invalid, must be power of 2, and not exceed %u\\n\",\n+\t\tRING_LOG(ERR,\n+\t\t\t\"Requested number of elements is invalid, must be power of 2, and not exceed %u\",\n \t\t\tRTE_RING_SZ_MASK);\n \n \t\treturn -EINVAL;\n@@ -195,8 +202,8 @@ rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,\n \n \t/* future proof flags, only allow supported values */\n \tif (flags & ~RING_F_MASK) {\n-\t\tRTE_LOG(ERR, RING,\n-\t\t\t\"Unsupported flags requested %#x\\n\", flags);\n+\t\tRING_LOG(ERR,\n+\t\t\t\"Unsupported flags requested %#x\", flags);\n \t\treturn -EINVAL;\n \t}\n \n@@ -216,8 +223,8 @@ rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,\n \t\tr->capacity = count;\n \t} else {\n \t\tif ((!POWEROF2(count)) || (count > RTE_RING_SZ_MASK)) {\n-\t\t\tRTE_LOG(ERR, RING,\n-\t\t\t\t\"Requested size is invalid, must be power of 2, and not exceed the size limit %u\\n\",\n+\t\t\tRING_LOG(ERR,\n+\t\t\t\t\"Requested size is invalid, must be power of 2, and not exceed the size limit %u\",\n \t\t\t\tRTE_RING_SZ_MASK);\n \t\t\treturn -EINVAL;\n \t\t}\n@@ -271,7 +278,7 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,\n \n \tte = rte_zmalloc(\"RING_TAILQ_ENTRY\", sizeof(*te), 0);\n \tif (te == NULL) {\n-\t\tRTE_LOG(ERR, RING, \"Cannot reserve memory for tailq\\n\");\n+\t\tRING_LOG(ERR, \"Cannot reserve memory for tailq\");\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n@@ -295,7 +302,7 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,\n \t\tTAILQ_INSERT_TAIL(ring_list, te, next);\n \t} else {\n \t\tr = NULL;\n-\t\tRTE_LOG(ERR, RING, \"Cannot reserve memory\\n\");\n+\t\tRING_LOG(ERR, \"Cannot reserve memory\");\n \t\trte_free(te);\n \t}\n \trte_mcfg_tailq_write_unlock();\n@@ -327,13 +334,13 @@ rte_ring_free(struct rte_ring *r)\n \t * therefore, there is no memzone to free.\n \t */\n \tif (r->memzone == NULL) {\n-\t\tRTE_LOG(ERR, RING,\n-\t\t\t\"Cannot free ring, not created with rte_ring_create()\\n\");\n+\t\tRING_LOG(ERR,\n+\t\t\t \"Cannot free ring, not created with rte_ring_create()\");\n \t\treturn;\n \t}\n \n \tif (rte_memzone_free(r->memzone) != 0) {\n-\t\tRTE_LOG(ERR, RING, \"Cannot free memory\\n\");\n+\t\tRING_LOG(ERR, \"Cannot free memory\");\n \t\treturn;\n \t}\n \n", "prefixes": [ "RFC", "v2", "11/17" ] }