Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123391/?format=api
{ "id": 123391, "url": "http://patches.dpdk.org/api/patches/123391/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207230438.1617331-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207230438.1617331-6-stephen@networkplumber.org", "date": "2023-02-07T23:04:26", "name": "[RFC,v2,05/17] gso: remove logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3f14ce01a044280bdfb775834749129f075f6b0f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 26874, "url": "http://patches.dpdk.org/api/series/26874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26874", "date": "2023-02-07T23:04:21", "name": "static logtype removal", "version": 2, "mbox": "http://patches.dpdk.org/series/26874/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123391/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123391/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 720D041C34;\n\tWed, 8 Feb 2023 00:05:25 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D443942D29;\n\tWed, 8 Feb 2023 00:05:11 +0100 (CET)", "from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170])\n by mails.dpdk.org (Postfix) with ESMTP id 2406E42D29\n for <dev@dpdk.org>; Wed, 8 Feb 2023 00:05:11 +0100 (CET)", "by mail-pl1-f170.google.com with SMTP id w5so7288753plg.8\n for <dev@dpdk.org>; Tue, 07 Feb 2023 15:05:11 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n gq17-20020a17090b105100b0020dc318a43esm71189pjb.25.2023.02.07.15.05.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Feb 2023 15:05:09 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xEjvKrBAUqZeBvyRL0ll8ue+hM/7XowkxMi6ngrjkWo=;\n b=YCFc74BF/HyjUP3BKVtIehS72NMimPlfPy0qt7hznt9SKoAR2nWcrgAT1EG4SuvSXY\n +TzZUtFhxdHPWaqgsR90CiyRxNPqDO6k6FT2zpxlLTIQqYYbtujxIAgL0fMYpzetNYNu\n fWm3ORFHyHif1ulvuL/qSIkMq0qRQVrmbQ/isKuV3VgTb+om1v0IlCzdYuj9XGK6NWlK\n BISb1oMXdm/rSs/ZFLbP1QQiCsuv4a81RGrJya83us93lQMjtz07WYMBvNhQ5uOCtiOC\n WHwSsCLeAhEDfnxzSB1pP8S23oVb3R4vsTY1oyzL3QJfbslPjJTdXtX8OwSPN3OUdWHl\n V2yg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=xEjvKrBAUqZeBvyRL0ll8ue+hM/7XowkxMi6ngrjkWo=;\n b=rARxXTH5vKyDbyfcN2ZKkWhS7KLY97Kwb2gxIEqNBO5zQETbkhuo88GfEec7uyKP49\n tSXZWwKd0T8Z1ouBM46ilORZdArySy83N0qdcZN7P3YNQIthfsy+kAw7NGC4jw46nj1g\n BcWc1mD2o3mduhYGC0vZ1H2kA9ihY9UMISeJNFe24hYyuiPEyrLBf+rgddCz7SepVZe5\n nnCg/5DvhN909sTnBcgL6OK6Mg8xIpx9+KYeBLv96TPlGozXwXj0fsaObbRIZ7v9ztyg\n bj/TZxkng5muTofSDwtV88ddPIpRGgFLFm9Z9vTCabFAlx7boUvgPa9lP6GMOZuud9zz\n Aj1g==", "X-Gm-Message-State": "AO0yUKU+as+s67pEMwef7JZ59FgNA/+BPyifpXal+DH48zM0fb5usq4J\n 0WNAmp0czSw0igU09ZAuexFwkoWvebjbnMpRnfI=", "X-Google-Smtp-Source": "\n AK7set82fPvAeZzfvYjjU079BqEzY8r6N1htQxyDDJzTPONYYcNDga99BrYxctSbwieZusP2OtnGFQ==", "X-Received": "by 2002:a17:90b:1bca:b0:22c:79bf:bee1 with SMTP id\n oa10-20020a17090b1bca00b0022c79bfbee1mr6186097pjb.10.1675811110104;\n Tue, 07 Feb 2023 15:05:10 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, jiayu.hu@intel.com,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Mark Kavanagh <mark.b.kavanagh@intel.com>", "Subject": "[RFC v2 05/17] gso: remove logtype", "Date": "Tue, 7 Feb 2023 15:04:26 -0800", "Message-Id": "<20230207230438.1617331-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230207230438.1617331-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230207230438.1617331-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If a large packet is passed into GSO routines of unknown protocol\nthen library would log a message and pass it through. This is incorrect\nbehaviour on many levels:\n - it allows oversize packet to get passed on to NIC driver\n - no direct return is visible to applications\n - if it happens once, many more will follow and log will fill.\n - bonus it is only log message with GSO type.\n\nThe fix is to just return -EINVAL which is what this library\ndoes in many other places when looking at headers.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\nCc: jiayu.hu@intel.com\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/eal_common_log.c | 2 +-\n lib/eal/include/rte_log.h | 1 -\n lib/gso/rte_gso.c | 3 +--\n 3 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c\nindex bd7b188ceb4a..c369154cb1ea 100644\n--- a/lib/eal/common/eal_common_log.c\n+++ b/lib/eal/common/eal_common_log.c\n@@ -368,7 +368,7 @@ static const struct logtype logtype_strings[] = {\n \t{RTE_LOGTYPE_CRYPTODEV, \"lib.cryptodev\"},\n \t{RTE_LOGTYPE_EFD, \"lib.efd\"},\n \t{RTE_LOGTYPE_EVENTDEV, \"lib.eventdev\"},\n-\t{RTE_LOGTYPE_GSO, \"lib.gso\"},\n+\n \t{RTE_LOGTYPE_USER1, \"user1\"},\n \t{RTE_LOGTYPE_USER2, \"user2\"},\n \t{RTE_LOGTYPE_USER3, \"user3\"},\ndiff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rte_log.h\nindex 6d2b0856a565..97d6b26a9967 100644\n--- a/lib/eal/include/rte_log.h\n+++ b/lib/eal/include/rte_log.h\n@@ -46,7 +46,6 @@ extern \"C\" {\n #define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */\n #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */\n #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */\n-#define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */\n \n /* these log types can be used in an application */\n #define RTE_LOGTYPE_USER1 24 /**< User-defined log type 1. */\ndiff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c\nindex 4b59217c16ee..19c351769fcc 100644\n--- a/lib/gso/rte_gso.c\n+++ b/lib/gso/rte_gso.c\n@@ -81,8 +81,7 @@ rte_gso_segment(struct rte_mbuf *pkt,\n \t\t\t\tindirect_pool, pkts_out, nb_pkts_out);\n \t} else {\n \t\t/* unsupported packet, skip */\n-\t\tRTE_LOG(DEBUG, GSO, \"Unsupported packet type\\n\");\n-\t\tret = 0;\n+\t\tret = -EINVAL;\n \t}\n \n \tif (ret < 0) {\n", "prefixes": [ "RFC", "v2", "05/17" ] }