Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123390/?format=api
{ "id": 123390, "url": "http://patches.dpdk.org/api/patches/123390/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207230438.1617331-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207230438.1617331-5-stephen@networkplumber.org", "date": "2023-02-07T23:04:25", "name": "[RFC,v2,04/17] latencystats: use dynamic logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "efe4e355b218e447490d6105e01a54a195159b83", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 26874, "url": "http://patches.dpdk.org/api/series/26874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26874", "date": "2023-02-07T23:04:21", "name": "static logtype removal", "version": 2, "mbox": "http://patches.dpdk.org/series/26874/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123390/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/123390/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF8EC41C34;\n\tWed, 8 Feb 2023 00:05:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7AB4442D17;\n\tWed, 8 Feb 2023 00:04:50 +0100 (CET)", "from mail-pj1-f44.google.com (mail-pj1-f44.google.com\n [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 3E382427F2\n for <dev@dpdk.org>; Wed, 8 Feb 2023 00:04:47 +0100 (CET)", "by mail-pj1-f44.google.com with SMTP id\n e10-20020a17090a630a00b0022bedd66e6dso376361pjj.1\n for <dev@dpdk.org>; Tue, 07 Feb 2023 15:04:47 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n gq17-20020a17090b105100b0020dc318a43esm71189pjb.25.2023.02.07.15.04.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Feb 2023 15:04:45 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=NvdUuNsyahgHaUTI/xF7yC88g8W9RGQN1t1NkC5FbQU=;\n b=mCuL52doveGUk0LF+XmN92KommblHLCOcQUxKX2NBH8R+lRCAjydXfXiOkeOdlUu6J\n rvyiL5cBp89/aO8/jd8moWT/+1ZH6jBOhRViN6IGyeGsJEQvF3ocnV9GpzW0/wIL6opJ\n nxzmtIGbWRD7zBCo9iq2TcQHM8bqxyGT0ob6L4S+iR1nuQc4rH7kY7PKwBYC05ox0up6\n SFVzZth1tSJzLdZl5vAHQ7C9Oq/0NUnQ9C7xV15409jgw91zLhqIIv2FVeozvZiivGVH\n MJSHFrfNRdJCWWKQ5PVf+WRYPW1Thqrsp1ujWvUs+oO5QJmoZT19Ed02WKQnlj6cnB+J\n A8YA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=NvdUuNsyahgHaUTI/xF7yC88g8W9RGQN1t1NkC5FbQU=;\n b=uIMbFAVeOMw8anWjzTmjuokXXA0FrCTolse8DAExWcikKIg5SYqNGBP0XKVk9mdbi5\n HoG3OdY6AJZVoQ/7lgF/vLmYtU/FwyzXc/HgZBSEsrBGZDlBJ6adjwKQazpKGi3Xkz6v\n XqJamP4V/GzYjL085w5DC+sS+v3katwJmUzW/qrB27KWP4bAgJsUjG8jSZk9oAkm2rAj\n YAYNJge0aM7oXgaFILurMuxmnrcORvtxQVdD1rrKmlbwSqhmmhAwp8ITnfaN+71OzMqA\n /Y2CjqVCbxxFhSmoGCW3Crqsa4QDf45RCy1SQ2Q1tEwJjeewnO0w5UD/GrMCLsx3WKww\n eedA==", "X-Gm-Message-State": "AO0yUKXWlOTLi5wT819jkLH0g8R0cJkONQQAdFxWStJOUQeA+btdkPNb\n 5bHBH/CO1H3kjc1TQlsz/izBLgYkkREaiVdHvBU=", "X-Google-Smtp-Source": "\n AK7set9gtj8sOyGFds0ry0QFfHBwVjtaenaQVHUICGzNIr8Ae3FYz/RaINbV4CN1mfQ3vAqDrxEZag==", "X-Received": "by 2002:a17:90a:2:b0:229:9aac:abb6 with SMTP id\n 2-20020a17090a000200b002299aacabb6mr5980858pja.47.1675811086150;\n Tue, 07 Feb 2023 15:04:46 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>, reshma.pattan@intel.com,\n Remy Horton <remy.horton@intel.com>,\n Harry van Haaren <harry.van.haaren@intel.com>", "Subject": "[RFC v2 04/17] latencystats: use dynamic logtype", "Date": "Tue, 7 Feb 2023 15:04:25 -0800", "Message-Id": "<20230207230438.1617331-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230207230438.1617331-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230207230438.1617331-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Libraries should not reuse RTE_LOGTYPE_USER1 for their\nloggging. Instead they should register their own type.\n\nFixes: 5cd3cac9ed22 (\"latency: added new library for latency stats\")\nCc: reshma.pattan@intel.com\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/latencystats/rte_latencystats.c | 55 +++++++++++++++--------------\n 1 file changed, 28 insertions(+), 27 deletions(-)", "diff": "diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c\nindex 8985a377db4e..3a4c47e2b34a 100644\n--- a/lib/latencystats/rte_latencystats.c\n+++ b/lib/latencystats/rte_latencystats.c\n@@ -26,7 +26,10 @@ latencystat_cycles_per_ns(void)\n }\n \n /* Macros for printing using RTE_LOG */\n-#define RTE_LOGTYPE_LATENCY_STATS RTE_LOGTYPE_USER1\n+RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);\n+#define LATENCYSTATS_LOG(level, fmt, args...)\t\t\\\n+\trte_log(RTE_LOG_ ## level, latencystat_logtype,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n \n static uint64_t timestamp_dynflag;\n static int timestamp_dynfield_offset = -1;\n@@ -95,7 +98,7 @@ rte_latencystats_update(void)\n \t\t\t\t\tlatency_stats_index,\n \t\t\t\t\tvalues, NUM_LATENCY_STATS);\n \tif (ret < 0)\n-\t\tRTE_LOG(INFO, LATENCY_STATS, \"Failed to push the stats\\n\");\n+\t\tLATENCYSTATS_LOG(INFO, \"Failed to push the stats\");\n \n \treturn ret;\n }\n@@ -227,8 +230,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tmz = rte_memzone_reserve(MZ_RTE_LATENCY_STATS, sizeof(*glob_stats),\n \t\t\t\t\trte_socket_id(), flags);\n \tif (mz == NULL) {\n-\t\tRTE_LOG(ERR, LATENCY_STATS, \"Cannot reserve memory: %s:%d\\n\",\n-\t\t\t__func__, __LINE__);\n+\t\tLATENCYSTATS_LOG(ERR, \"Cannot reserve memory\");\n \t\treturn -ENOMEM;\n \t}\n \n@@ -243,8 +245,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tlatency_stats_index = rte_metrics_reg_names(ptr_strings,\n \t\t\t\t\t\t\tNUM_LATENCY_STATS);\n \tif (latency_stats_index < 0) {\n-\t\tRTE_LOG(DEBUG, LATENCY_STATS,\n-\t\t\t\"Failed to register latency stats names\\n\");\n+\t\tLATENCYSTATS_LOG(ERR, \"Failed to register latency stats names\");\n \t\treturn -1;\n \t}\n \n@@ -252,8 +253,8 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \tret = rte_mbuf_dyn_rx_timestamp_register(×tamp_dynfield_offset,\n \t\t\t×tamp_dynflag);\n \tif (ret != 0) {\n-\t\tRTE_LOG(ERR, LATENCY_STATS,\n-\t\t\t\"Cannot register mbuf field/flag for timestamp\\n\");\n+\t\tLATENCYSTATS_LOG(ERR,\n+\t\t\t\t \"Cannot register mbuf field/flag for timestamp\");\n \t\treturn -rte_errno;\n \t}\n \n@@ -263,9 +264,9 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tRTE_LOG(INFO, LATENCY_STATS,\n-\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n-\t\t\t\tpid, strerror(-ret));\n+\t\t\tLATENCYSTATS_LOG(INFO,\n+\t\t\t\t\t \"Error during getting device (port %u) info: %s\",\n+\t\t\t\t\t pid, strerror(-ret));\n \n \t\t\tcontinue;\n \t\t}\n@@ -275,18 +276,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,\n \t\t\tcbs->cb = rte_eth_add_first_rx_callback(pid, qid,\n \t\t\t\t\tadd_time_stamps, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tRTE_LOG(INFO, LATENCY_STATS, \"Failed to \"\n-\t\t\t\t\t\"register Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\\n\", pid, qid);\n+\t\t\t\tLATENCYSTATS_LOG(INFO,\n+\t\t\t\t\t\t \"Failed to register Rx callback for pid=%d, qid=%d\",\n+\t\t\t\t\t\t pid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tcbs->cb = rte_eth_add_tx_callback(pid, qid,\n \t\t\t\t\tcalc_latency, user_cb);\n \t\t\tif (!cbs->cb)\n-\t\t\t\tRTE_LOG(INFO, LATENCY_STATS, \"Failed to \"\n-\t\t\t\t\t\"register Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\\n\", pid, qid);\n+\t\t\t\tLATENCYSTATS_LOG(INFO,\n+\t\t\t\t\t\t \"Failed to register Tx callback for pid=%d, qid=%d\",\n+\t\t\t\t\t\t pid, qid);\n \t\t}\n \t}\n \treturn 0;\n@@ -307,8 +308,8 @@ rte_latencystats_uninit(void)\n \n \t\tret = rte_eth_dev_info_get(pid, &dev_info);\n \t\tif (ret != 0) {\n-\t\t\tRTE_LOG(INFO, LATENCY_STATS,\n-\t\t\t\t\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\tLATENCYSTATS_LOG(INFO,\n+\t\t\t\t\"Error during getting device (port %u) info: %s\",\n \t\t\t\tpid, strerror(-ret));\n \n \t\t\tcontinue;\n@@ -318,17 +319,17 @@ rte_latencystats_uninit(void)\n \t\t\tcbs = &rx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tRTE_LOG(INFO, LATENCY_STATS, \"failed to \"\n-\t\t\t\t\t\"remove Rx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\\n\", pid, qid);\n+\t\t\t\tLATENCYSTATS_LOG(INFO,\n+\t\t\t\t\t\t \"failed to remove Rx callback for pid=%d, qid=%d\",\n+\t\t\t\t\t\t pid, qid);\n \t\t}\n \t\tfor (qid = 0; qid < dev_info.nb_tx_queues; qid++) {\n \t\t\tcbs = &tx_cbs[pid][qid];\n \t\t\tret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);\n \t\t\tif (ret)\n-\t\t\t\tRTE_LOG(INFO, LATENCY_STATS, \"failed to \"\n-\t\t\t\t\t\"remove Tx callback for pid=%d, \"\n-\t\t\t\t\t\"qid=%d\\n\", pid, qid);\n+\t\t\t\tLATENCYSTATS_LOG(INFO,\n+\t\t\t\t\t\t \"failed to remove Tx callback for pid=%d, qid=%d\",\n+\t\t\t\t\t\t pid, qid);\n \t\t}\n \t}\n \n@@ -365,8 +366,8 @@ rte_latencystats_get(struct rte_metric_value *values, uint16_t size)\n \t\tconst struct rte_memzone *mz;\n \t\tmz = rte_memzone_lookup(MZ_RTE_LATENCY_STATS);\n \t\tif (mz == NULL) {\n-\t\t\tRTE_LOG(ERR, LATENCY_STATS,\n-\t\t\t\t\"Latency stats memzone not found\\n\");\n+\t\t\tLATENCYSTATS_LOG(ERR,\n+\t\t\t\t\t \"Latency stats memzone not found\");\n \t\t\treturn -ENOMEM;\n \t\t}\n \t\tglob_stats = mz->addr;\n", "prefixes": [ "RFC", "v2", "04/17" ] }