Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123389/?format=api
{ "id": 123389, "url": "http://patches.dpdk.org/api/patches/123389/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207230438.1617331-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207230438.1617331-4-stephen@networkplumber.org", "date": "2023-02-07T23:04:24", "name": "[RFC,v2,03/17] reorder: use a dynamic logtype", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "37b90fa15fad1cefada9e9b9f425322f0adf3ffe", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230207230438.1617331-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 26874, "url": "http://patches.dpdk.org/api/series/26874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26874", "date": "2023-02-07T23:04:21", "name": "static logtype removal", "version": 2, "mbox": "http://patches.dpdk.org/series/26874/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123389/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123389/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3420141C34;\n\tWed, 8 Feb 2023 00:05:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6CF1042D0E;\n\tWed, 8 Feb 2023 00:04:49 +0100 (CET)", "from mail-pj1-f42.google.com (mail-pj1-f42.google.com\n [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 2ADC341153\n for <dev@dpdk.org>; Wed, 8 Feb 2023 00:04:46 +0100 (CET)", "by mail-pj1-f42.google.com with SMTP id o13so16585678pjg.2\n for <dev@dpdk.org>; Tue, 07 Feb 2023 15:04:46 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n gq17-20020a17090b105100b0020dc318a43esm71189pjb.25.2023.02.07.15.04.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 07 Feb 2023 15:04:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KZgfsFOvebHmT9+dLkYUNEfM3BYjfInGf2AA4yLuCd4=;\n b=jdIPPf16hsQ4qmaE7igDIzFnAzB6o2XOoTV+RnrCWALNwsBJTg060pWLda+kCxDuzn\n Yk2994636gmCxg/Gl7Ornt24MVx6m1P59EQdoctvEry0Tk48v9vClkVPaogXldhr9aWD\n Y3rzOn89M2lHBHfKNgYcZcXBo3u1MXes3UvFgzPhKjYyeVDZisDyM5+0ZQ5miXy/Ykcq\n jBvfV8eiDIBAFUqiFxljf7D9y++EHIV7HEvd/CVJbIFweSBy9Oc0GhoBSAcloCOSGlvJ\n s3svYrfVMOCDw9kffGEq0udnmfOiHpInFKrE9wHe64xdlah5a1+kYpQtVbakkDtbCrLZ\n A/AQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=KZgfsFOvebHmT9+dLkYUNEfM3BYjfInGf2AA4yLuCd4=;\n b=i4czgO3d8j+7gmq1WjKNqqq4IrLB38HL5ZXg8oNmDu7dgkrj/i1q/CfzIh5bQbCrzT\n dF1Y1/HfJ/4isNhrS1BJx91xb9rJhNyDLJPfHU7lhQIr929BRAheP06F6o8TJA8zBzD7\n rtnlJgPMjxBURUZ1dHn47KHNizZMDhkE3awmgtWQoqPOtV4ksOgok5yc1VxBv+4hYyQ+\n 0skY/bhNcmYJkocRVnMa8dGAC4qI0eDSAbmO+TO9Nm++4GwhRyxyUg7A5QoV/jOGAVKp\n PY1HeFL7+KzBLBZuGLNGMNuPmpUxi/Gb2BuSqeY4YonliEWb3KY8KPVJghSklza+ErjE\n CFDw==", "X-Gm-Message-State": "AO0yUKWYg8aPVhkfQhv5QCW/Wnupv9WFLFQrutBJxJhdecmJDut37MtE\n 9XCYpkBVrLvkbS4JNlAtmP32/fMr/n/UgwECz4U=", "X-Google-Smtp-Source": "\n AK7set9f8+kuHHktpfC0G+vwDZ98vPS/2+Y7H4BtRxhRafa+WTm+tT43GbBEg4d1L02Xc1/bIHQvmw==", "X-Received": "by 2002:a17:90b:1bc8:b0:230:c6b8:87c0 with SMTP id\n oa8-20020a17090b1bc800b00230c6b887c0mr5798843pjb.31.1675811085009;\n Tue, 07 Feb 2023 15:04:45 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n sergio.gonzalez.monroy@intel.com, Reshma Pattan <reshma.pattan@intel.com>,\n Neil Horman <nhorman@tuxdriver.com>,\n Declan Doherty <declan.doherty@intel.com>,\n Richardson Bruce <bruce.richardson@intel.com>", "Subject": "[RFC v2 03/17] reorder: use a dynamic logtype", "Date": "Tue, 7 Feb 2023 15:04:24 -0800", "Message-Id": "<20230207230438.1617331-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230207230438.1617331-1-stephen@networkplumber.org>", "References": "<20230207204151.1503491-1-stephen@networkplumber.org>\n <20230207230438.1617331-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Libraries should not be reusing RTE_LOGTYPE_USER1 instead\nof doing proper logtype registration.\n\nFixes: b70b56032bff (\"reorder: new library\")\nCc: sergio.gonzalez.monroy@intel.com\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/reorder/rte_reorder.c | 35 +++++++++++++++++++----------------\n 1 file changed, 19 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c\nindex 385ee479da42..c9ae42e71783 100644\n--- a/lib/reorder/rte_reorder.c\n+++ b/lib/reorder/rte_reorder.c\n@@ -27,7 +27,11 @@ EAL_REGISTER_TAILQ(rte_reorder_tailq)\n #define RTE_REORDER_NAMESIZE 32\n \n /* Macros for printing using RTE_LOG */\n-#define RTE_LOGTYPE_REORDER\tRTE_LOGTYPE_USER1\n+RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO);\n+\n+#define REORDER_LOG(level, fmt, args...)\t\t\\\n+\trte_log(RTE_LOG_ ## level, reorder_logtype,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n \n #define RTE_REORDER_SEQN_DYNFIELD_NAME \"rte_reorder_seqn_dynfield\"\n int rte_reorder_seqn_dynfield_offset = -1;\n@@ -62,26 +66,25 @@ rte_reorder_init(struct rte_reorder_buffer *b, unsigned int bufsize,\n \t\t\t\t\t(2 * size * sizeof(struct rte_mbuf *));\n \n \tif (b == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer parameter:\"\n-\t\t\t\t\t\" NULL\\n\");\n+\t\tREORDER_LOG(ERR, \"Invalid reorder buffer parameter: NULL\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (!rte_is_power_of_2(size)) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer size\"\n-\t\t\t\t\" - Not a power of 2\\n\");\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Invalid reorder buffer size - Not a power of 2\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (name == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer name ptr:\"\n-\t\t\t\t\t\" NULL\\n\");\n+\t\tREORDER_LOG(ERR, \"Invalid reorder buffer name ptr: NULL\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (bufsize < min_bufsize) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer memory size: %u, \"\n-\t\t\t\"minimum required: %u\\n\", bufsize, min_bufsize);\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Invalid reorder buffer memory size: %u, minimum required: %u\",\n+\t\t\t bufsize, min_bufsize);\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n@@ -116,14 +119,13 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \n \t/* Check user arguments. */\n \tif (!rte_is_power_of_2(size)) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer size\"\n-\t\t\t\t\" - Not a power of 2\\n\");\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Invalid reorder buffer size - Not a power of 2\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n \tif (name == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Invalid reorder buffer name ptr:\"\n-\t\t\t\t\t\" NULL\\n\");\n+\t\tREORDER_LOG(ERR, \"Invalid reorder buffer name ptr: NULL\");\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n@@ -131,7 +133,8 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \trte_reorder_seqn_dynfield_offset =\n \t\trte_mbuf_dynfield_register(&reorder_seqn_dynfield_desc);\n \tif (rte_reorder_seqn_dynfield_offset < 0) {\n-\t\tRTE_LOG(ERR, REORDER, \"Failed to register mbuf field for reorder sequence number\\n\");\n+\t\tREORDER_LOG(ERR,\n+\t\t\t \"Failed to register mbuf field for reorder sequence number\");\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n@@ -150,7 +153,7 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \t/* allocate tailq entry */\n \tte = rte_zmalloc(\"REORDER_TAILQ_ENTRY\", sizeof(*te), 0);\n \tif (te == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Failed to allocate tailq entry\\n\");\n+\t\tREORDER_LOG(ERR, \"Failed to allocate tailq entry\");\n \t\trte_errno = ENOMEM;\n \t\tb = NULL;\n \t\tgoto exit;\n@@ -159,7 +162,7 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \t/* Allocate memory to store the reorder buffer structure. */\n \tb = rte_zmalloc_socket(\"REORDER_BUFFER\", bufsize, 0, socket_id);\n \tif (b == NULL) {\n-\t\tRTE_LOG(ERR, REORDER, \"Memzone allocation failed\\n\");\n+\t\tREORDER_LOG(ERR, \"Memzone allocation failed\");\n \t\trte_errno = ENOMEM;\n \t\trte_free(te);\n \t} else {\n", "prefixes": [ "RFC", "v2", "03/17" ] }