Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123366/?format=api
{ "id": 123366, "url": "http://patches.dpdk.org/api/patches/123366/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230207193731.1242505-2-rjarry@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230207193731.1242505-2-rjarry@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230207193731.1242505-2-rjarry@redhat.com", "date": "2023-02-07T19:37:27", "name": "[v9,1/5] eal: add lcore info in telemetry", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "c196bda826080c93f1452496999029d86d359711", "submitter": { "id": 2850, "url": "http://patches.dpdk.org/api/people/2850/?format=api", "name": "Robin Jarry", "email": "rjarry@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230207193731.1242505-2-rjarry@redhat.com/mbox/", "series": [ { "id": 26868, "url": "http://patches.dpdk.org/api/series/26868/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26868", "date": "2023-02-07T19:37:27", "name": "[v9,1/5] eal: add lcore info in telemetry", "version": 9, "mbox": "http://patches.dpdk.org/series/26868/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123366/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123366/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D914641C33;\n\tTue, 7 Feb 2023 20:37:50 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B7AC42B8E;\n\tTue, 7 Feb 2023 20:37:45 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 9AB6140EF0\n for <dev@dpdk.org>; Tue, 7 Feb 2023 20:37:43 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-3-UWrTxBP7N3mDO_a82fgx_w-1; Tue, 07 Feb 2023 14:37:41 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B68B1800B24;\n Tue, 7 Feb 2023 19:37:40 +0000 (UTC)", "from ringo.home (unknown [10.39.208.16])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B483B1121314;\n Tue, 7 Feb 2023 19:37:39 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1675798663;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=g4aodA0tW4w72nTc2pJb1Tk4UYX7CGHAEkfFsVYXWdY=;\n b=btLdwl43p4LviUO7UrKoSQCTiJYgQr0GQjgoCw+9RcG3GiF6NJzBA+YTKs+hjFqY57Laez\n KIGEZRpECc4OMJiIeRyF1TFgkF6f8AdcF3kKFi7c5zB6gNXGWcTwNA3F6d9tZ5Zc3RGOIv\n FCYyTUpXcZjJBTUEMTIOAnVF8+yYEOc=", "X-MC-Unique": "UWrTxBP7N3mDO_a82fgx_w-1", "From": "Robin Jarry <rjarry@redhat.com>", "To": "dev@dpdk.org", "Cc": "Robin Jarry <rjarry@redhat.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Kevin Laatz <kevin.laatz@intel.com>", "Subject": "[PATCH v9 1/5] eal: add lcore info in telemetry", "Date": "Tue, 7 Feb 2023 20:37:27 +0100", "Message-Id": "<20230207193731.1242505-2-rjarry@redhat.com>", "In-Reply-To": "<20221123102612.1688865-1-rjarry@redhat.com>", "References": "<20221123102612.1688865-1-rjarry@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Report the same information than rte_lcore_dump() in the telemetry\nAPI into /eal/lcore/list and /eal/lcore/info,ID.\n\nExample:\n\n --> /eal/lcore/info,3\n {\n \"/eal/lcore/info\": {\n \"lcore_id\": 3,\n \"socket\": 0,\n \"role\": \"RTE\",\n \"cpuset\": [\n 3\n ]\n }\n }\n\nSigned-off-by: Robin Jarry <rjarry@redhat.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nReviewed-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n\nNotes:\n v8 -> v9: Updated with 64 bits integers telemetry functions\n\n lib/eal/common/eal_common_lcore.c | 123 +++++++++++++++++++++++++-----\n 1 file changed, 105 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c\nindex 06c594b0224f..f53fc17b4d04 100644\n--- a/lib/eal/common/eal_common_lcore.c\n+++ b/lib/eal/common/eal_common_lcore.c\n@@ -10,6 +10,9 @@\n #include <rte_errno.h>\n #include <rte_lcore.h>\n #include <rte_log.h>\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+#include <rte_telemetry.h>\n+#endif\n \n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n@@ -419,35 +422,35 @@ rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg)\n \treturn ret;\n }\n \n+static const char *\n+lcore_role_str(enum rte_lcore_role_t role)\n+{\n+\tswitch (role) {\n+\tcase ROLE_RTE:\n+\t\treturn \"RTE\";\n+\tcase ROLE_SERVICE:\n+\t\treturn \"SERVICE\";\n+\tcase ROLE_NON_EAL:\n+\t\treturn \"NON_EAL\";\n+\tdefault:\n+\t\treturn \"UNKNOWN\";\n+\t}\n+}\n+\n static int\n lcore_dump_cb(unsigned int lcore_id, void *arg)\n {\n \tstruct rte_config *cfg = rte_eal_get_configuration();\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n-\tconst char *role;\n \tFILE *f = arg;\n \tint ret;\n \n-\tswitch (cfg->lcore_role[lcore_id]) {\n-\tcase ROLE_RTE:\n-\t\trole = \"RTE\";\n-\t\tbreak;\n-\tcase ROLE_SERVICE:\n-\t\trole = \"SERVICE\";\n-\t\tbreak;\n-\tcase ROLE_NON_EAL:\n-\t\trole = \"NON_EAL\";\n-\t\tbreak;\n-\tdefault:\n-\t\trole = \"UNKNOWN\";\n-\t\tbreak;\n-\t}\n-\n \tret = eal_thread_dump_affinity(&lcore_config[lcore_id].cpuset, cpuset,\n \t\tsizeof(cpuset));\n \tfprintf(f, \"lcore %u, socket %u, role %s, cpuset %s%s\\n\", lcore_id,\n-\t\trte_lcore_to_socket_id(lcore_id), role, cpuset,\n-\t\tret == 0 ? \"\" : \"...\");\n+\t\trte_lcore_to_socket_id(lcore_id),\n+\t\tlcore_role_str(cfg->lcore_role[lcore_id]),\n+\t\tcpuset, ret == 0 ? \"\" : \"...\");\n \treturn 0;\n }\n \n@@ -456,3 +459,87 @@ rte_lcore_dump(FILE *f)\n {\n \trte_lcore_iterate(lcore_dump_cb, f);\n }\n+\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+static int\n+lcore_telemetry_id_cb(unsigned int lcore_id, void *arg)\n+{\n+\tstruct rte_tel_data *d = arg;\n+\treturn rte_tel_data_add_array_int(d, lcore_id);\n+}\n+\n+static int\n+handle_lcore_list(const char *cmd __rte_unused,\n+\tconst char *params __rte_unused,\n+\tstruct rte_tel_data *d)\n+{\n+\tint ret = rte_tel_data_start_array(d, RTE_TEL_INT_VAL);\n+\tif (ret)\n+\t\treturn ret;\n+\treturn rte_lcore_iterate(lcore_telemetry_id_cb, d);\n+}\n+\n+struct lcore_telemetry_info {\n+\tunsigned int lcore_id;\n+\tstruct rte_tel_data *d;\n+};\n+\n+static int\n+lcore_telemetry_info_cb(unsigned int lcore_id, void *arg)\n+{\n+\tstruct rte_config *cfg = rte_eal_get_configuration();\n+\tstruct lcore_telemetry_info *info = arg;\n+\tstruct rte_tel_data *cpuset;\n+\tunsigned int cpu;\n+\n+\tif (info->lcore_id != lcore_id)\n+\t\treturn 0;\n+\n+\trte_tel_data_start_dict(info->d);\n+\trte_tel_data_add_dict_int(info->d, \"lcore_id\", lcore_id);\n+\trte_tel_data_add_dict_int(info->d, \"socket\", rte_lcore_to_socket_id(lcore_id));\n+\trte_tel_data_add_dict_string(info->d, \"role\", lcore_role_str(cfg->lcore_role[lcore_id]));\n+\tcpuset = rte_tel_data_alloc();\n+\tif (cpuset == NULL)\n+\t\treturn -ENOMEM;\n+\trte_tel_data_start_array(cpuset, RTE_TEL_INT_VAL);\n+\tfor (cpu = 0; cpu < CPU_SETSIZE; cpu++) {\n+\t\tif (CPU_ISSET(cpu, &lcore_config[lcore_id].cpuset))\n+\t\t\trte_tel_data_add_array_int(cpuset, cpu);\n+\t}\n+\trte_tel_data_add_dict_container(info->d, \"cpuset\", cpuset, 0);\n+\n+\treturn 0;\n+}\n+\n+static int\n+handle_lcore_info(const char *cmd __rte_unused, const char *params, struct rte_tel_data *d)\n+{\n+\tstruct lcore_telemetry_info info = { .d = d };\n+\tunsigned long lcore_id;\n+\tchar *endptr;\n+\n+\tif (params == NULL)\n+\t\treturn -EINVAL;\n+\terrno = 0;\n+\tlcore_id = strtoul(params, &endptr, 10);\n+\tif (errno)\n+\t\treturn -errno;\n+\tif (*params == '\\0' || *endptr != '\\0' || lcore_id >= RTE_MAX_LCORE)\n+\t\treturn -EINVAL;\n+\n+\tinfo.lcore_id = lcore_id;\n+\n+\treturn rte_lcore_iterate(lcore_telemetry_info_cb, &info);\n+}\n+\n+RTE_INIT(lcore_telemetry)\n+{\n+\trte_telemetry_register_cmd(\n+\t\t\"/eal/lcore/list\", handle_lcore_list,\n+\t\t\"List of lcore ids. Takes no parameters\");\n+\trte_telemetry_register_cmd(\n+\t\t\"/eal/lcore/info\", handle_lcore_info,\n+\t\t\"Returns lcore info. Parameters: int lcore_id\");\n+}\n+#endif /* !RTE_EXEC_ENV_WINDOWS */\n", "prefixes": [ "v9", "1/5" ] }