Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/123144/?format=api
{ "id": 123144, "url": "http://patches.dpdk.org/api/patches/123144/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/a137683754ff2ed6571376bad9f50a738635f168.1675693844.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<a137683754ff2ed6571376bad9f50a738635f168.1675693844.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/a137683754ff2ed6571376bad9f50a738635f168.1675693844.git.gmuthukrishn@marvell.com", "date": "2023-02-06T14:45:53", "name": "[v1,01/10] examples/fips_validation: fix MCT output for SHA", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d08cf6b5472d200db6147df98bb198257403fdeb", "submitter": { "id": 2301, "url": "http://patches.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/a137683754ff2ed6571376bad9f50a738635f168.1675693844.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 26816, "url": "http://patches.dpdk.org/api/series/26816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26816", "date": "2023-02-06T14:45:52", "name": "fips_validation application improvements", "version": 1, "mbox": "http://patches.dpdk.org/series/26816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/123144/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/123144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B18B841C12;\n\tMon, 6 Feb 2023 15:46:20 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CA8B242D12;\n\tMon, 6 Feb 2023 15:46:16 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 98C5A40FAE\n for <dev@dpdk.org>; Mon, 6 Feb 2023 15:46:15 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 31688kg6015844; Mon, 6 Feb 2023 06:46:15 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nhqrtbkc8-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 06 Feb 2023 06:46:14 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Mon, 6 Feb 2023 06:46:12 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Mon, 6 Feb 2023 06:46:12 -0800", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id D40603F7050;\n Mon, 6 Feb 2023 06:46:10 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=QK6+en4WVSOmcq49zdQux3hyhsB2/4OjX0h6aMr9KWE=;\n b=R6xp3X+SgcZsAtf2fvJcbmMdGwq2cd8VSV0MlPnTQlOiDiceHSpxx9N2yx79Cde6NTmw\n ULpoB+zinaL/SPsvd0SJ3LJilgyOapCCqpDsOyufSQiiFLX6I/fttWdd3HvRPAdrkpO9\n zM3SRI3ta6OltXMTtaDTpJldoWAkcl62GPKqM523NhGUSWFLje8ja7H4XcOUo+Exu2vN\n 1cwp7B8C0yNUUj1JtKOiluNAWxPe1buy+VRLfvh43e8L+GXvrFvUwzAD3cDUXWrQIV6o\n nA71LKZy2v0J6qFB66z5E0P3ndHZRemUCbYAbjknDhuCIOuUijNntuncfi7bRMh9w/hn JA==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Anoob Joseph <anoobj@marvell.com>, <jerinj@marvell.com>, Akhil Goyal\n <gakhil@marvell.com>, Brian Dooley <brian.dooley@intel.com>, \"Gowrishankar\n Muthukrishnan\" <gmuthukrishn@marvell.com>", "Subject": "[v1, 01/10] examples/fips_validation: fix MCT output for SHA", "Date": "Mon, 6 Feb 2023 20:15:53 +0530", "Message-ID": "\n <a137683754ff2ed6571376bad9f50a738635f168.1675693844.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1675693844.git.gmuthukrishn@marvell.com>", "References": "<cover.1675693844.git.gmuthukrishn@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "BV07pj1tBvqWkH-0bIh5AEoS5soQlVz3", "X-Proofpoint-ORIG-GUID": "BV07pj1tBvqWkH-0bIh5AEoS5soQlVz3", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1\n definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MCT test for SHA need not print message string along\nwith digest value.\n\nFixes: d5c247145c2 (\"examples/fips_validation: add parsing for SHA\")\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\n examples/fips_validation/fips_validation_sha.c | 8 ++------\n examples/fips_validation/main.c | 13 +++++--------\n 2 files changed, 7 insertions(+), 14 deletions(-)", "diff": "diff --git a/examples/fips_validation/fips_validation_sha.c b/examples/fips_validation/fips_validation_sha.c\nindex c5da2cc623..178ea492d3 100644\n--- a/examples/fips_validation/fips_validation_sha.c\n+++ b/examples/fips_validation/fips_validation_sha.c\n@@ -182,7 +182,7 @@ parse_test_sha_json_writeback(struct fips_val *val)\n static int\n parse_test_sha_mct_json_writeback(struct fips_val *val)\n {\n-\tjson_t *tcId, *msg, *md, *resArr, *res;\n+\tjson_t *tcId, *md, *resArr, *res;\n \tstruct fips_val val_local;\n \n \ttcId = json_object_get(json_info.json_test_case, \"tcId\");\n@@ -208,11 +208,7 @@ parse_test_sha_mct_json_writeback(struct fips_val *val)\n \n \tres = json_object();\n \n-\twriteback_hex_str(\"\", info.one_line_text, &val[1]);\n-\tmsg = json_string(info.one_line_text);\n-\tjson_object_set_new(res, \"msg\", msg);\n-\n-\tval_local.val = val[0].val + vec.pt.len;\n+\tval_local.val = val->val + vec.pt.len;\n \tval_local.len = vec.cipher_auth.digest.len;\n \n \twriteback_hex_str(\"\", info.one_line_text, &val_local);\ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex 622f8b5a6e..cc585e8418 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -2268,8 +2268,7 @@ fips_mct_sha_test(void)\n #define SHA_EXTERN_ITER\t100\n #define SHA_INTERN_ITER\t1000\n #define SHA_MD_BLOCK\t3\n-\t/* val[0] is op result and other value is for parse_writeback callback */\n-\tstruct fips_val val[2] = {{NULL, 0},};\n+\tstruct fips_val val = {NULL, 0};\n \tstruct fips_val md[SHA_MD_BLOCK], msg;\n \tint ret;\n \tuint32_t i, j;\n@@ -2328,7 +2327,7 @@ fips_mct_sha_test(void)\n \t\t\t\treturn ret;\n \t\t\t}\n \n-\t\t\tret = get_writeback_data(&val[0]);\n+\t\t\tret = get_writeback_data(&val);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n \n@@ -2337,7 +2336,7 @@ fips_mct_sha_test(void)\n \t\t\tmemcpy(md[1].val, md[2].val, md[2].len);\n \t\t\tmd[1].len = md[2].len;\n \n-\t\t\tmemcpy(md[2].val, (val[0].val + vec.pt.len),\n+\t\t\tmemcpy(md[2].val, (val.val + vec.pt.len),\n \t\t\t\tvec.cipher_auth.digest.len);\n \t\t\tmd[2].len = vec.cipher_auth.digest.len;\n \t\t}\n@@ -2348,9 +2347,7 @@ fips_mct_sha_test(void)\n \t\tif (info.file_type != FIPS_TYPE_JSON)\n \t\t\tfprintf(info.fp_wr, \"COUNT = %u\\n\", j);\n \n-\t\tval[1].val = msg.val;\n-\t\tval[1].len = msg.len;\n-\t\tinfo.parse_writeback(val);\n+\t\tinfo.parse_writeback(&val);\n \n \t\tif (info.file_type != FIPS_TYPE_JSON)\n \t\t\tfprintf(info.fp_wr, \"\\n\");\n@@ -2361,7 +2358,7 @@ fips_mct_sha_test(void)\n \n \trte_free(vec.pt.val);\n \n-\tfree(val[0].val);\n+\tfree(val.val);\n \tfree(msg.val);\n \n \treturn 0;\n", "prefixes": [ "v1", "01/10" ] }