Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122839/?format=api
{ "id": 122839, "url": "http://patches.dpdk.org/api/patches/122839/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230201092310.23252-28-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230201092310.23252-28-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230201092310.23252-28-syalavarthi@marvell.com", "date": "2023-02-01T09:22:58", "name": "[v4,27/39] ml/cnxk: dequeue a burst of inference requests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "239e1a52ef369c2ea8f46d6822ecc83c13d934ad", "submitter": { "id": 2480, "url": "http://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230201092310.23252-28-syalavarthi@marvell.com/mbox/", "series": [ { "id": 26732, "url": "http://patches.dpdk.org/api/series/26732/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26732", "date": "2023-02-01T09:22:31", "name": "Implementation of ML CNXK driver", "version": 4, "mbox": "http://patches.dpdk.org/series/26732/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122839/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/122839/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2813941B9D;\n\tWed, 1 Feb 2023 10:26:38 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E01C34301D;\n\tWed, 1 Feb 2023 10:23:54 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 9AC2B42D75\n for <dev@dpdk.org>; Wed, 1 Feb 2023 10:23:26 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 3116LRYB024189 for <dev@dpdk.org>; Wed, 1 Feb 2023 01:23:25 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3nfjr8rgv6-9\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 01 Feb 2023 01:23:25 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Wed, 1 Feb 2023 01:23:21 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Wed, 1 Feb 2023 01:23:21 -0800", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 489735B6922;\n Wed, 1 Feb 2023 01:23:21 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=VkPVjIcukKU9EeHa0GTGjw1US9RHANzwfA1WPiKxioQ=;\n b=kp5eI8KqqpT/rKxeqOmC2QfGYc2VL2C2KEMq3qt0E3UoPKQvBsWhuFnSluOImRbgIq1r\n BRuHir92CqF6xl/pqGU2Rw7gZVDTasKvw+TGseAmG/3a2YmM6N8aUBy3XeQnbDkn62GF\n 9KZPvdcjhUMc/eimxGEVPIP0gC1O5cw0iRnMyKM9uxJSyAYe2qgwvJML+blVUK3iY+Cl\n FgzVhT631M2LoAmDf82NIFdU60jvhgPViXspQgDcUYJqcg9iXkmvCraXOefrg0qHYV69\n GbEwSvMYv+0KmIkKp+VwE8Irh2nkb/yZ2B0i39qnoapoC3ccvXUwGRs+XzaJ9YVcL0jm KQ==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <jerinj@marvell.com>,\n <aprabhu@marvell.com>", "Subject": "[PATCH v4 27/39] ml/cnxk: dequeue a burst of inference requests", "Date": "Wed, 1 Feb 2023 01:22:58 -0800", "Message-ID": "<20230201092310.23252-28-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230201092310.23252-1-syalavarthi@marvell.com>", "References": "<20221208200220.20267-1-syalavarthi@marvell.com>\n <20230201092310.23252-1-syalavarthi@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "SA3TPFOJoIt859Ts-9vB-rTPQTsgK_Nj", "X-Proofpoint-ORIG-GUID": "SA3TPFOJoIt859Ts-9vB-rTPQTsgK_Nj", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1\n definitions=2023-02-01_03,2023-01-31_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enabled driver support to dequeue inference requests from\ninternal queue. Dequeue checks for request completion by\npolling the status field of the job request.\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n drivers/ml/cnxk/cn10k_ml_ops.c | 61 ++++++++++++++++++++++++++++++++++\n drivers/ml/cnxk/cn10k_ml_ops.h | 2 ++\n 2 files changed, 63 insertions(+)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c\nindex 1abdf6fad1..ef3cbadca7 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.c\n@@ -473,6 +473,7 @@ cn10k_ml_dev_configure(struct rte_ml_dev *dev, const struct rte_ml_dev_config *c\n \trte_spinlock_init(&ocm->lock);\n \n \tdev->enqueue_burst = cn10k_ml_enqueue_burst;\n+\tdev->dequeue_burst = cn10k_ml_dequeue_burst;\n \n \tmldev->nb_models_loaded = 0;\n \tmldev->state = ML_CN10K_DEV_STATE_CONFIGURED;\n@@ -1418,6 +1419,23 @@ queue_free_count(uint64_t head, uint64_t tail, uint64_t nb_desc)\n \treturn nb_desc - queue_pending_count(head, tail, nb_desc) - 1;\n }\n \n+static __rte_always_inline void\n+cn10k_ml_result_update(struct rte_ml_dev *dev, int qp_id, struct cn10k_ml_result *result,\n+\t\t struct rte_ml_op *op)\n+{\n+\tPLT_SET_USED(dev);\n+\tPLT_SET_USED(qp_id);\n+\n+\top->impl_opaque = result->error_code;\n+\n+\tif (likely(result->error_code == 0))\n+\t\top->status = RTE_ML_OP_STATUS_SUCCESS;\n+\telse\n+\t\top->status = RTE_ML_OP_STATUS_ERROR;\n+\n+\top->user_ptr = result->user_ptr;\n+}\n+\n __rte_hot uint16_t\n cn10k_ml_enqueue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op **ops,\n \t\t uint16_t nb_ops)\n@@ -1472,6 +1490,49 @@ cn10k_ml_enqueue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op\n \treturn count;\n }\n \n+__rte_hot uint16_t\n+cn10k_ml_dequeue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op **ops,\n+\t\t uint16_t nb_ops)\n+{\n+\tstruct cn10k_ml_queue *queue;\n+\tstruct cn10k_ml_req *req;\n+\tstruct cn10k_ml_qp *qp;\n+\n+\tuint64_t status;\n+\tuint16_t count;\n+\tuint64_t tail;\n+\n+\tqp = dev->data->queue_pairs[qp_id];\n+\tqueue = &qp->queue;\n+\n+\ttail = queue->tail;\n+\tnb_ops = PLT_MIN(nb_ops, queue_pending_count(queue->head, tail, qp->nb_desc));\n+\tcount = 0;\n+\n+\tif (unlikely(nb_ops == 0))\n+\t\tgoto empty_or_active;\n+\n+dequeue_req:\n+\treq = &queue->reqs[tail];\n+\tstatus = plt_read64(&req->status);\n+\tif (unlikely(status != ML_CN10K_POLL_JOB_FINISH))\n+\t\tgoto empty_or_active;\n+\n+\tcn10k_ml_result_update(dev, qp_id, &req->result, req->op);\n+\tops[count] = req->op;\n+\n+\tqueue_index_advance(&tail, qp->nb_desc);\n+\tcount++;\n+\n+\tif (count < nb_ops)\n+\t\tgoto dequeue_req;\n+\n+empty_or_active:\n+\tqueue->tail = tail;\n+\n+\treturn count;\n+}\n+\n struct rte_ml_dev_ops cn10k_ml_ops = {\n \t/* Device control ops */\n \t.dev_info_get = cn10k_ml_dev_info_get,\ndiff --git a/drivers/ml/cnxk/cn10k_ml_ops.h b/drivers/ml/cnxk/cn10k_ml_ops.h\nindex d35f91a302..3178295bba 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ops.h\n+++ b/drivers/ml/cnxk/cn10k_ml_ops.h\n@@ -73,5 +73,7 @@ int cn10k_ml_model_stop(struct rte_ml_dev *dev, int16_t model_id);\n /* Fast-path ops */\n __rte_hot uint16_t cn10k_ml_enqueue_burst(struct rte_ml_dev *dev, uint16_t qp_id,\n \t\t\t\t\t struct rte_ml_op **ops, uint16_t nb_ops);\n+__rte_hot uint16_t cn10k_ml_dequeue_burst(struct rte_ml_dev *dev, uint16_t qp_id,\n+\t\t\t\t\t struct rte_ml_op **ops, uint16_t nb_ops);\n \n #endif /* _CN10K_ML_OPS_H_ */\n", "prefixes": [ "v4", "27/39" ] }