Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122672/?format=api
{ "id": 122672, "url": "http://patches.dpdk.org/api/patches/122672/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230130093129.18529-7-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230130093129.18529-7-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230130093129.18529-7-liudongdong3@huawei.com", "date": "2023-01-30T09:31:25", "name": "[V2,06/10] net/hns3: using RSS filter list to check duplicated rule", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0b07edba89ef1bd0016407670903f4fab8fc9f04", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230130093129.18529-7-liudongdong3@huawei.com/mbox/", "series": [ { "id": 26688, "url": "http://patches.dpdk.org/api/series/26688/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26688", "date": "2023-01-30T09:31:20", "name": "net/hns3: some bugfixes for rss", "version": 2, "mbox": "http://patches.dpdk.org/series/26688/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122672/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/122672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 887A141B7E;\n\tMon, 30 Jan 2023 10:33:00 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6F84042FB2;\n\tMon, 30 Jan 2023 10:32:15 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id B151742D0D;\n Mon, 30 Jan 2023 10:32:07 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4P52y5432nzfZ50;\n Mon, 30 Jan 2023 17:31:57 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.34; Mon, 30 Jan 2023 17:32:04 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH V2 06/10] net/hns3: using RSS filter list to check duplicated\n rule", "Date": "Mon, 30 Jan 2023 17:31:25 +0800", "Message-ID": "<20230130093129.18529-7-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230130093129.18529-1-liudongdong3@huawei.com>", "References": "<20230129105140.29921-1-liudongdong3@huawei.com>\n <20230130093129.18529-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nAll rules from user are saved in RSS filter list, so use RSS\nfilter list to check duplicated rule.\n\nFixes: c37ca66f2b27 (\"net/hns3: support RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 35 +++++++++++++++++++++--------------\n 1 file changed, 21 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex c338eab049..303275ae93 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1300,7 +1300,7 @@ hns3_action_rss_same(const struct rte_flow_action_rss *comp,\n \t\t!memcmp(comp->key, with->key, with->key_len);\n \n \treturn (func_is_same && rss_key_is_same &&\n-\t\tcomp->types == (with->types & HNS3_ETH_RSS_SUPPORT) &&\n+\t\tcomp->types == with->types &&\n \t\tcomp->level == with->level &&\n \t\tcomp->queue_num == with->queue_num &&\n \t\t!memcmp(comp->queue, with->queue,\n@@ -1596,15 +1596,7 @@ hns3_config_rss_filter(struct hns3_hw *hw,\n \t}\n \n \t/* Set hash algorithm and flow types by the user's config */\n-\tret = hns3_hw_rss_hash_set(hw, &rss_flow_conf);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tret = hns3_rss_conf_copy(rss_info, &rss_flow_conf);\n-\tif (ret)\n-\t\thns3_err(hw, \"RSS config init fail(%d)\", ret);\n-\n-\treturn ret;\n+\treturn hns3_hw_rss_hash_set(hw, &rss_flow_conf);\n }\n \n static int\n@@ -1676,17 +1668,32 @@ hns3_restore_filter(struct hns3_adapter *hns)\n \treturn hns3_restore_rss_filter(hw);\n }\n \n+static bool\n+hns3_rss_action_is_dup(struct hns3_hw *hw,\n+\t\t const struct rte_flow_action_rss *act)\n+{\n+\tstruct hns3_rss_conf_ele *filter;\n+\n+\tTAILQ_FOREACH(filter, &hw->flow_rss_list, entries) {\n+\t\tif (!filter->filter_info.valid)\n+\t\t\tcontinue;\n+\n+\t\tif (hns3_action_rss_same(&filter->filter_info.conf, act))\n+\t\t\treturn true;\n+\t}\n+\n+\treturn false;\n+}\n+\n static int\n hns3_flow_parse_rss(struct rte_eth_dev *dev,\n \t\t const struct hns3_rss_conf *conf, bool add)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n-\tbool ret;\n \n-\tret = hns3_action_rss_same(&hw->rss_info.conf, &conf->conf);\n-\tif (ret) {\n-\t\thns3_err(hw, \"Enter duplicate RSS configuration : %d\", ret);\n+\tif (hns3_rss_action_is_dup(hw, &conf->conf)) {\n+\t\thns3_err(hw, \"duplicate RSS configuration\");\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "V2", "06/10" ] }