Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122647/?format=api
{ "id": 122647, "url": "http://patches.dpdk.org/api/patches/122647/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230130045302.1560006-10-rongweil@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230130045302.1560006-10-rongweil@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230130045302.1560006-10-rongweil@nvidia.com", "date": "2023-01-30T04:53:00", "name": "[v3,09/11] app/testpmd: raw encap with flex item support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6b584628839e31bd373145f8793017032c3294bc", "submitter": { "id": 2223, "url": "http://patches.dpdk.org/api/people/2223/?format=api", "name": "rongwei liu", "email": "rongweil@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230130045302.1560006-10-rongweil@nvidia.com/mbox/", "series": [ { "id": 26683, "url": "http://patches.dpdk.org/api/series/26683/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26683", "date": "2023-01-30T04:52:51", "name": "add flex item support", "version": 3, "mbox": "http://patches.dpdk.org/series/26683/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122647/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/122647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0D6A6424B9;\n\tMon, 30 Jan 2023 05:54:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8742241151;\n\tMon, 30 Jan 2023 05:54:05 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2088.outbound.protection.outlook.com [40.107.223.88])\n by mails.dpdk.org (Postfix) with ESMTP id B717C42D29\n for <dev@dpdk.org>; Mon, 30 Jan 2023 05:54:01 +0100 (CET)", "from MW2PR16CA0061.namprd16.prod.outlook.com (2603:10b6:907:1::38)\n by SJ0PR12MB8089.namprd12.prod.outlook.com (2603:10b6:a03:4eb::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Mon, 30 Jan\n 2023 04:54:00 +0000", "from CO1NAM11FT070.eop-nam11.prod.protection.outlook.com\n (2603:10b6:907:1:cafe::35) by MW2PR16CA0061.outlook.office365.com\n (2603:10b6:907:1::38) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36 via Frontend\n Transport; Mon, 30 Jan 2023 04:54:00 +0000", "from mail.nvidia.com (216.228.117.160) by\n CO1NAM11FT070.mail.protection.outlook.com (10.13.175.20) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6043.17 via Frontend Transport; Mon, 30 Jan 2023 04:54:00 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 29 Jan\n 2023 20:53:46 -0800", "from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 29 Jan\n 2023 20:53:44 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=H9SZ4X8uobT6PD9l3Pp6RNNkMjadBSNHXFll8RldXy/UJFRCqAEyjAxZVklMw861S04jY4EE/C2FRSwvcOL2WLkKX2ZMaRn5SfIkERqwGRndMyqQn9TRAg2bSKf+sdbUiDjJRba+n5mNCrSBnQL4pEkgABcEL29tpNEH+zVZkZMzBi3ftubbB7+XXxcb3wnnaSEMuDG5/NfsZnNNLsyQz5IBZSVLAq4cXMpqD/768Q+Sa9Gzb4j8yOOZGCNZX53/FIvspvpeCSgjHk3aQ6ehPH4Tslb0AZ76fUe/P4O4i4N3gH/wfKBqdhd8Ev50/03hYeoYKuKujNIc8O7oQhu2Xw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=p+q+vrNiX6zn3xxx6pBtNu5+Q90OHYv6uY61JVIWMbM=;\n b=YfCf7bAzRbK8Yon9meNBJj604cfuM5BwsCT7FE/arrDPSfs7qEMYZ9YY86+I6ko8rZqBf3KMZnVrVfHDb5hE2aGn50JlhIwRUuHtWb8y8A4P3DVsg6PF9QPEzWnWFFoIaE35l3PE4rLcfiTQsBZpwQop5cBZ0UIy/X8QybBvgkVDHahMkA0ywj/LGEGtI7V0pyESXiyD29DTGjkjMjieKElBYpjARfK741l/XyOAUKlNnFyBTd/ocEywbRHJxpPH5dRMwg5ew79SmHLseIfC5uPSLscYU6SSJTpbdzsHU5+gcYxMAUql3C63K0SXFGoXNKJjTiu6JNSKIz2PcsvK8A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=p+q+vrNiX6zn3xxx6pBtNu5+Q90OHYv6uY61JVIWMbM=;\n b=U3Y7ONmsbkOU0PxNTGoxNn11PcwB1ve0OxbJFIxvZk2DQteHpcKpTZuVrlcPqF5yNU4NNyAekv4lU8OM/CBdQjXhqigKoTbE9f3bkWLwUu7X9qQPCs0oWk2p9KOJNRHJyZMqdBebkjaQPPV3++O+miciAaJjqu0JQKETaMtmwGpX631y8g/smZPo5rTRA32kGIvfMRUSkzIDUftGA5SR8Jt/4C+J0JaeRuYujaXQ9Yexfwm2VNnhwKdSubIbCsPymXpvipsIR2SAFoZiBOxXEV21Lt4ZEzuFfUKq3ku6VSBst3OLMIDJGY4XAdiOATVoTIFMlhWhnYsKogQlinyh5Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Rongwei Liu <rongweil@nvidia.com>", "To": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,\n <thomas@monjalon.net>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang\n <yuying.zhang@intel.com>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>", "Subject": "[PATCH v3 09/11] app/testpmd: raw encap with flex item support", "Date": "Mon, 30 Jan 2023 06:53:00 +0200", "Message-ID": "<20230130045302.1560006-10-rongweil@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230130045302.1560006-1-rongweil@nvidia.com>", "References": "<3ba49f25-52d0-fe07-02e6-22a71e0fbe13@oktetlabs.ru>\n <20230130045302.1560006-1-rongweil@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.37]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT070:EE_|SJ0PR12MB8089:EE_", "X-MS-Office365-Filtering-Correlation-Id": "dc7ca2dd-4d61-48ae-81ec-08db027e008e", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +E8QyYxnos6Ge12FGSc0M97eEPWwepuucItbButR5BWxZLJLJkp6bJe1VilRF00rl4vTcP/A5K6kpIEfuzKEVi7ONwHi7HfCCOl1wGGzZ7+UXXkNC6gy60JtaVA/Vc0duEjpjZJzJyrPnqRo9nC3iV7Uh4NaozoXtxlDMu4ybk9gOv8CDMAdJLNx6sEWMv/SP/F5f/w0NAyo8OJZbvc3eNsso8omu/UwlKxLlmUXhXHRTn1YzO/yiMvFGueD1cuIOHFaCdd9uSpZVN/9GuA+tVkh0X59Hh9IE0xNfxtZm5NeRvAghDzQ3FflV+7PFixXwnG27qk9vX9Y8HceqzV8nKhE6w3G4X5X2NQDLGH9AIN5HOjY6nuTj66axHlTni4ECjjV4SVfLGqHyAjQNReEAJdafOHipFTR3HiKIgG6qzkW7ExVmuqZlPdwIGp/NAeKUbuPyXxWd0u9Q6mpozosBrY074lxxN+PdnMUGw8WoCLvKT4ZQ6dq/VUPjpH1Ycd79Zzg6CxQ+q9KgMNHDC6nllp4+TKZV/2XuqJDtP71hpC3ZanRylhamei3k2L9y2+DQ6Yzw/bv5UimGxDXppleR5V4XYFWMnsuaF4ONBErjmGOWaUyc7jP46nrjiuQ0TIW0tMs1fDilcL6RJBX/sQYgBA/SgIoSuatPzEHn2JZYviAQ4M/Hb6yEdU9vOP9rQRYLGjc08oaWk9T0B+zqQ9ofQ==", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230025)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199018)(40470700004)(36840700001)(46966006)(356005)(86362001)(82310400005)(36756003)(41300700001)(2906002)(54906003)(7696005)(110136005)(6666004)(478600001)(107886003)(2616005)(8936002)(55016003)(40480700001)(5660300002)(316002)(4326008)(70206006)(70586007)(8676002)(83380400001)(7636003)(82740400003)(26005)(36860700001)(6286002)(16526019)(186003)(1076003)(40460700003)(47076005)(426003)(336012);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Jan 2023 04:54:00.0437 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n dc7ca2dd-4d61-48ae-81ec-08db027e008e", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT070.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR12MB8089", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Application should retrieve raw_encap buffer from\nspec->pattern if it is flex item.\n\nSigned-off-by: Rongwei Liu <rongweil@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 26 +++++++++++++++++---------\n 1 file changed, 17 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex f5d7a67def..50c8ec5594 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -11193,6 +11193,7 @@ cmd_set_raw_parsed(const struct buffer *in)\n \tuint16_t proto = 0;\n \tuint16_t idx = in->port; /* We borrow port field as index */\n \tint gtp_psc = -1; /* GTP PSC option index. */\n+\tconst void *src_spec;\n \n \tif (in->command == SET_SAMPLE_ACTIONS)\n \t\treturn cmd_set_raw_parsed_sample(in);\n@@ -11216,6 +11217,7 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\titem = in->args.vc.pattern + i;\n \t\tif (item->spec == NULL)\n \t\t\titem->spec = flow_item_default_mask(item);\n+\t\tsrc_spec = item->spec;\n \t\tswitch (item->type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ETH:\n \t\t\tsize = sizeof(struct rte_ether_hdr);\n@@ -11343,9 +11345,13 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\t\tsize = sizeof(struct rte_flow_item_pfcp);\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_FLEX:\n-\t\t\tsize = item->spec ?\n-\t\t\t\t((const struct rte_flow_item_flex *)\n-\t\t\t\titem->spec)->length : 0;\n+\t\t\tif (item->spec != NULL) {\n+\t\t\t\tsize = ((const struct rte_flow_item_flex *)item->spec)->length;\n+\t\t\t\tsrc_spec = ((const struct rte_flow_item_flex *)item->spec)->pattern;\n+\t\t\t} else {\n+\t\t\t\tsize = 0;\n+\t\t\t\tsrc_spec = NULL;\n+\t\t\t}\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_GRE_OPTION:\n \t\t\tsize = 0;\n@@ -11378,12 +11384,14 @@ cmd_set_raw_parsed(const struct buffer *in)\n \t\t\tfprintf(stderr, \"Error - Not supported item\\n\");\n \t\t\tgoto error;\n \t\t}\n-\t\t*total_size += size;\n-\t\trte_memcpy(data_tail - (*total_size), item->spec, size);\n-\t\t/* update some fields which cannot be set by cmdline */\n-\t\tupdate_fields((data_tail - (*total_size)), item,\n-\t\t\t upper_layer);\n-\t\tupper_layer = proto;\n+\t\tif (size) {\n+\t\t\t*total_size += size;\n+\t\t\trte_memcpy(data_tail - (*total_size), src_spec, size);\n+\t\t\t/* update some fields which cannot be set by cmdline */\n+\t\t\tupdate_fields((data_tail - (*total_size)), item,\n+\t\t\t\t upper_layer);\n+\t\t\tupper_layer = proto;\n+\t\t}\n \t}\n \tif (verbose_level & 0x1)\n \t\tprintf(\"total data size is %zu\\n\", (*total_size));\n", "prefixes": [ "v3", "09/11" ] }