Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122623/?format=api
{ "id": 122623, "url": "http://patches.dpdk.org/api/patches/122623/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230129105140.29921-8-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230129105140.29921-8-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230129105140.29921-8-liudongdong3@huawei.com", "date": "2023-01-29T10:51:37", "name": "[07/10] net/hns3: remove useless code when destroy valid RSS rule", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e25079d1819ca1de3a6f554dad81a992408f7cd7", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230129105140.29921-8-liudongdong3@huawei.com/mbox/", "series": [ { "id": 26679, "url": "http://patches.dpdk.org/api/series/26679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26679", "date": "2023-01-29T10:51:32", "name": "net/hns3: some bugfixes for rss", "version": 1, "mbox": "http://patches.dpdk.org/series/26679/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122623/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/122623/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AAEF424B3;\n\tSun, 29 Jan 2023 11:53:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9991E42FB4;\n\tSun, 29 Jan 2023 11:52:22 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 7C69440EDD;\n Sun, 29 Jan 2023 11:52:16 +0100 (CET)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.57])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4P4Skw28SlznVQn;\n Sun, 29 Jan 2023 18:50:16 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.34; Sun, 29 Jan 2023 18:52:14 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <ferruh.yigit@amd.com>, <thomas@monjalon.net>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<stable@dpdk.org>, <yisen.zhuang@huawei.com>, <liudongdong3@huawei.com>,\n <lihuisong@huawei.com>", "Subject": "[PATCH 07/10] net/hns3: remove useless code when destroy valid RSS\n rule", "Date": "Sun, 29 Jan 2023 18:51:37 +0800", "Message-ID": "<20230129105140.29921-8-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20230129105140.29921-1-liudongdong3@huawei.com>", "References": "<20230129105140.29921-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nThe hw::rss_info::conf::func was set to the macro RTE_ETH_HASH_FUNCTION_MAX\nand hw::rss_info::conf::queue was set to NULL when all rules are flushed,\nwhich indicates no flow rules is issued. See\ncommit eb158fc756a5 (\"net/hns3: fix config when creating RSS rule after\nflush\").\nActually, the way determining whether there are rules has been changed by\nwalking the flow RSS list. See\ncommit 705a50800334 (\"net/hns3: fix RSS filter restore\").\n\nIn addition, the rte_flow_action_rss from user isn't saved to 'conf' in\nhw->rss_info now. So this code can be removed.\n\nFixes: eb158fc756a5 (\"net/hns3: fix config when creating RSS rule after flush\")\nFixes: 705a50800334 (\"net/hns3: fix RSS filter restore\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 26 ++------------------------\n 1 file changed, 2 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 303275ae93..7adde16cbc 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -1279,19 +1279,8 @@ hns3_action_rss_same(const struct rte_flow_action_rss *comp,\n \tbool rss_key_is_same;\n \tbool func_is_same;\n \n-\t/*\n-\t * When user flush all RSS rule, RSS func is set invalid with\n-\t * RTE_ETH_HASH_FUNCTION_MAX. Then the user create a flow after\n-\t * flushed, any validate RSS func is different with it before\n-\t * flushed. Others, when user create an action RSS with RSS func\n-\t * specified RTE_ETH_HASH_FUNCTION_DEFAULT, the func is the same\n-\t * between continuous RSS flow.\n-\t */\n-\tif (comp->func == RTE_ETH_HASH_FUNCTION_MAX)\n-\t\tfunc_is_same = false;\n-\telse\n-\t\tfunc_is_same = (with->func != RTE_ETH_HASH_FUNCTION_DEFAULT) ?\n-\t\t\t\t(comp->func == with->func) : true;\n+\tfunc_is_same = (with->func != RTE_ETH_HASH_FUNCTION_DEFAULT) ?\n+\t\t\t(comp->func == with->func) : true;\n \n \tif (with->key_len == 0 || with->key == NULL)\n \t\trss_key_is_same = 1;\n@@ -1533,7 +1522,6 @@ static int\n hns3_config_rss_filter(struct hns3_hw *hw,\n \t\t const struct hns3_rss_conf *conf, bool add)\n {\n-\tstruct hns3_rss_conf *rss_info;\n \tuint64_t flow_types;\n \tuint16_t num;\n \tint ret;\n@@ -1560,7 +1548,6 @@ hns3_config_rss_filter(struct hns3_hw *hw,\n \t/* Update the useful flow types */\n \trss_flow_conf.types = flow_types;\n \n-\trss_info = &hw->rss_info;\n \tif (!add) {\n \t\tif (!conf->valid)\n \t\t\treturn 0;\n@@ -1571,15 +1558,6 @@ hns3_config_rss_filter(struct hns3_hw *hw,\n \t\t\treturn ret;\n \t\t}\n \n-\t\tif (rss_flow_conf.queue_num) {\n-\t\t\t/*\n-\t\t\t * Due the content of queue pointer have been reset to\n-\t\t\t * 0, the rss_info->conf.queue should be set to NULL\n-\t\t\t */\n-\t\t\trss_info->conf.queue = NULL;\n-\t\t\trss_info->conf.queue_num = 0;\n-\t\t}\n-\n \t\treturn 0;\n \t}\n \n", "prefixes": [ "07/10" ] }