Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122497/?format=api
{ "id": 122497, "url": "http://patches.dpdk.org/api/patches/122497/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1674583351-15292-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1674583351-15292-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1674583351-15292-3-git-send-email-roretzla@linux.microsoft.com", "date": "2023-01-24T18:02:29", "name": "[v9,2/4] eal: remove thread getname API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1f2c21cbc0e48426b90475ad04e398da995ead6c", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1674583351-15292-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 26644, "url": "http://patches.dpdk.org/api/series/26644/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26644", "date": "2023-01-24T18:02:27", "name": "add rte_thread_set_name API for rte_thread_t", "version": 9, "mbox": "http://patches.dpdk.org/series/26644/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122497/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/122497/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81D584247A;\n\tTue, 24 Jan 2023 19:02:45 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 28DCB427EE;\n\tTue, 24 Jan 2023 19:02:41 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8BB1E40223\n for <dev@dpdk.org>; Tue, 24 Jan 2023 19:02:38 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id EDB5820E34C5; Tue, 24 Jan 2023 10:02:37 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com EDB5820E34C5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1674583357;\n bh=/WfmXJJxKm+mal8OfLlKYUyuNv5oCE/YuA3TJ0dLmR0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ivJUBqEzqLMpvpC3uLYCUkdYQxtohGZGOK1B5a7YeCwudBu01Mkj5Oz2D+gqEr4sv\n +WlgHb+U3p5tXXVW3DAwkXs4WEFK3f+ztLaajNrttfDQgoQ9U+JnRs74PumJ2urYuX\n 4fuFCm9imVy4zedPMv5mseQAbIBGY+qaqug0Q1Co=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com, jerinjacobk@gmail.com,\n mb@smartsharesystems.com, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v9 2/4] eal: remove thread getname API", "Date": "Tue, 24 Jan 2023 10:02:29 -0800", "Message-Id": "<1674583351-15292-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1674583351-15292-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com>\n <1674583351-15292-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Remove the rte_thread_getname API. The API is __rte_experimental and\nrequires no deprecation notice.\n\nFold the platform specific variants into the one place it is used as a\nspecial case to retain the functionality for linux only.\n\nAdjust the function as follows.\n\n* reduce scope where thread_get_name can be used to eal_common_trace.c\n* change the return type to void since the return value is not\n consistent reportable depending on glibc version.\n* change the thread id type to be rte_thread_t.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\n lib/eal/common/eal_common_trace.c | 15 ++++++++++++++-\n lib/eal/freebsd/eal_thread.c | 9 ---------\n lib/eal/include/rte_lcore.h | 17 -----------------\n lib/eal/linux/eal_thread.c | 15 ---------------\n lib/eal/version.map | 1 -\n 5 files changed, 14 insertions(+), 43 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex 5caaac8..75162b7 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -298,6 +298,19 @@ rte_trace_mode rte_trace_mode_get(void)\n \t\ttrace_point_dump(f, tp);\n }\n \n+static void\n+thread_get_name(rte_thread_t id, char *name, size_t len)\n+{\n+#if defined(RTE_EXEC_ENV_LINUX) && defined(__GLIBC__) && defined(__GLIBC_PREREQ)\n+#if __GLIBC_PREREQ(2, 12)\n+\tpthread_getname_np((pthread_t)id.opaque_id, name, len);\n+#endif\n+#endif\n+\tRTE_SET_USED(id);\n+\tRTE_SET_USED(name);\n+\tRTE_SET_USED(len);\n+}\n+\n void\n __rte_trace_mem_per_thread_alloc(void)\n {\n@@ -356,7 +369,7 @@ rte_trace_mode rte_trace_mode_get(void)\n \t/* Store the thread name */\n \tchar *name = header->stream_header.thread_name;\n \tmemset(name, 0, __RTE_TRACE_EMIT_STRING_LEN_MAX);\n-\trte_thread_getname(pthread_self(), name,\n+\tthread_get_name(rte_thread_self(), name,\n \t\t__RTE_TRACE_EMIT_STRING_LEN_MAX);\n \n \ttrace->lcore_meta[count].mem = header;\ndiff --git a/lib/eal/freebsd/eal_thread.c b/lib/eal/freebsd/eal_thread.c\nindex b69f5d3..3227d9b 100644\n--- a/lib/eal/freebsd/eal_thread.c\n+++ b/lib/eal/freebsd/eal_thread.c\n@@ -49,12 +49,3 @@ int rte_thread_setname(pthread_t id, const char *name)\n \tpthread_set_name_np(id, name);\n \treturn 0;\n }\n-\n-int rte_thread_getname(pthread_t id, char *name, size_t len)\n-{\n-\tRTE_SET_USED(id);\n-\tRTE_SET_USED(name);\n-\tRTE_SET_USED(len);\n-\n-\treturn -ENOTSUP;\n-}\ndiff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h\nindex 6938c3f..9c78650 100644\n--- a/lib/eal/include/rte_lcore.h\n+++ b/lib/eal/include/rte_lcore.h\n@@ -352,23 +352,6 @@ enum rte_lcore_role_t {\n int rte_thread_setname(pthread_t id, const char *name);\n \n /**\n- * Get thread name.\n- *\n- * @note It fails with glibc < 2.12.\n- *\n- * @param id\n- * Thread id.\n- * @param name\n- * Thread name to set.\n- * @param len\n- * Thread name buffer length.\n- * @return\n- * On success, return 0; otherwise return a negative value.\n- */\n-__rte_experimental\n-int rte_thread_getname(pthread_t id, char *name, size_t len);\n-\n-/**\n * Register current non-EAL thread as a lcore.\n *\n * @note This API is not compatible with the multi-process feature:\ndiff --git a/lib/eal/linux/eal_thread.c b/lib/eal/linux/eal_thread.c\nindex d5fddab..c07ad9d 100644\n--- a/lib/eal/linux/eal_thread.c\n+++ b/lib/eal/linux/eal_thread.c\n@@ -55,18 +55,3 @@ int rte_thread_setname(pthread_t id, const char *name)\n \tRTE_SET_USED(name);\n \treturn -ret;\n }\n-\n-int rte_thread_getname(pthread_t id, char *name, size_t len)\n-{\n-\tint ret = ENOSYS;\n-#if defined(__GLIBC__) && defined(__GLIBC_PREREQ)\n-#if __GLIBC_PREREQ(2, 12)\n-\tret = pthread_getname_np(id, name, len);\n-#endif\n-#endif\n-\tRTE_SET_USED(id);\n-\tRTE_SET_USED(name);\n-\tRTE_SET_USED(len);\n-\treturn -ret;\n-\n-}\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex c98ba71..6523102 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -369,7 +369,6 @@ EXPERIMENTAL {\n \t__rte_trace_point_register;\n \tper_lcore_trace_mem;\n \tper_lcore_trace_point_sz;\n-\trte_thread_getname; # WINDOWS_NO_EXPORT\n \trte_trace_dump; # WINDOWS_NO_EXPORT\n \trte_trace_is_enabled; # WINDOWS_NO_EXPORT\n \trte_trace_metadata_dump; # WINDOWS_NO_EXPORT\n", "prefixes": [ "v9", "2/4" ] }