Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122470/?format=api
{ "id": 122470, "url": "http://patches.dpdk.org/api/patches/122470/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230124104742.1265439-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230124104742.1265439-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230124104742.1265439-4-david.marchand@redhat.com", "date": "2023-01-24T10:47:39", "name": "[3/6] app/testpmd: bulk free mbufs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d458ab2347e56a5b26efcd8d00afa0e85042ad1c", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230124104742.1265439-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 26634, "url": "http://patches.dpdk.org/api/series/26634/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26634", "date": "2023-01-24T10:47:36", "name": "Testpmd code cleanup", "version": 1, "mbox": "http://patches.dpdk.org/series/26634/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122470/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/122470/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AFCB42476;\n\tTue, 24 Jan 2023 11:48:30 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 922D342D3A;\n\tTue, 24 Jan 2023 11:48:28 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id AF58642BB1\n for <dev@dpdk.org>; Tue, 24 Jan 2023 11:48:27 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-615-uWd8xbxzN6SqnAnsOTatWQ-1; Tue, 24 Jan 2023 05:48:24 -0500", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com\n [10.11.54.5])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD68C183B3C1;\n Tue, 24 Jan 2023 10:48:23 +0000 (UTC)", "from dmarchan.redhat.com (ovpn-192-67.brq.redhat.com [10.40.192.67])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9BCF753A0;\n Tue, 24 Jan 2023 10:48:22 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1674557307;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=kGhVsI2fdFUDwVl8m3ieqaWO0F3pA33zhPn7K/E7vB8=;\n b=CRggF6h4sMp89tWytFr/XTG0+7qAmGFpuYOSvMuAsbSQJdP2aUaVB+zTJuTgRw93edYyYu\n hW8lIU7Uo70ZpxdH13lxgld+RK/lxpKtP1WAj9FIQVlqVmhstt8KMeSQd4BjE1r8f5zJqE\n u4Q14S86XmWO89eQbewa5J9KC4Eu8a4=", "X-MC-Unique": "uWd8xbxzN6SqnAnsOTatWQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>,\n Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>, Robin Jarry <rjarry@redhat.com>", "Subject": "[PATCH 3/6] app/testpmd: bulk free mbufs", "Date": "Tue, 24 Jan 2023 11:47:39 +0100", "Message-Id": "<20230124104742.1265439-4-david.marchand@redhat.com>", "In-Reply-To": "<20230124104742.1265439-1-david.marchand@redhat.com>", "References": "<20230124104742.1265439-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use the bulk free helper.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test-pmd/5tswap.c | 4 +---\n app/test-pmd/csumonly.c | 4 +---\n app/test-pmd/flowgen.c | 8 ++------\n app/test-pmd/icmpecho.c | 4 +---\n app/test-pmd/iofwd.c | 4 +---\n app/test-pmd/macfwd.c | 4 +---\n app/test-pmd/macswap.c | 4 +---\n app/test-pmd/noisy_vnf.c | 7 ++-----\n app/test-pmd/rxonly.c | 4 +---\n app/test-pmd/shared_rxq_fwd.c | 3 +--\n app/test-pmd/testpmd.c | 4 +---\n app/test-pmd/txonly.c | 4 +---\n 12 files changed, 14 insertions(+), 40 deletions(-)", "diff": "diff --git a/app/test-pmd/5tswap.c b/app/test-pmd/5tswap.c\nindex e665643a65..0a3a897e7b 100644\n--- a/app/test-pmd/5tswap.c\n+++ b/app/test-pmd/5tswap.c\n@@ -174,9 +174,7 @@ pkt_burst_5tuple_swap(struct fwd_stream *fs)\n \tinc_tx_burst_stats(fs, nb_tx);\n \tif (unlikely(nb_tx < nb_rx)) {\n \t\tfs->fwd_dropped += (nb_rx - nb_tx);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_rx);\n+\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_rx - nb_tx);\n \t}\n \n \treturn true;\ndiff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 700c79f122..07850501f4 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -1195,9 +1195,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)\n \tinc_tx_burst_stats(fs, nb_tx);\n \tif (unlikely(nb_tx < nb_prep)) {\n \t\tfs->fwd_dropped += (nb_prep - nb_tx);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(tx_pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_prep);\n+\t\trte_pktmbuf_free_bulk(&tx_pkts_burst[nb_tx], nb_prep - nb_tx);\n \t}\n \n \treturn true;\ndiff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c\nindex f26fd830f1..b3bd4f7c65 100644\n--- a/app/test-pmd/flowgen.c\n+++ b/app/test-pmd/flowgen.c\n@@ -75,7 +75,6 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \tuint16_t nb_dropped;\n \tuint16_t nb_pkt;\n \tuint16_t nb_clones = nb_pkt_flowgen_clones;\n-\tuint16_t i;\n \tuint32_t retry;\n \tuint64_t tx_offloads;\n \tint next_flow = RTE_PER_LCORE(_next_flow);\n@@ -86,8 +85,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \tinc_rx_burst_stats(fs, nb_rx);\n \tfs->rx_packets += nb_rx;\n \n-\tfor (i = 0; i < nb_rx; i++)\n-\t\trte_pktmbuf_free(pkts_burst[i]);\n+\trte_pktmbuf_free_bulk(pkts_burst, nb_rx);\n \n \tmbp = current_fwd_lcore()->mbp;\n \tvlan_tci = ports[fs->tx_port].tx_vlan_id;\n@@ -186,9 +184,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \t\t\tnext_flow += nb_flows_flowgen;\n \n \t\tfs->fwd_dropped += nb_dropped;\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_pkt);\n+\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_pkt - nb_tx);\n \t}\n \n \tRTE_PER_LCORE(_next_flow) = next_flow;\ndiff --git a/app/test-pmd/icmpecho.c b/app/test-pmd/icmpecho.c\nindex cd984d1ffb..5ef1116141 100644\n--- a/app/test-pmd/icmpecho.c\n+++ b/app/test-pmd/icmpecho.c\n@@ -500,9 +500,7 @@ reply_to_icmp_echo_rqsts(struct fwd_stream *fs)\n \t\tinc_tx_burst_stats(fs, nb_tx);\n \t\tif (unlikely(nb_tx < nb_replies)) {\n \t\t\tfs->fwd_dropped += (nb_replies - nb_tx);\n-\t\t\tdo {\n-\t\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t\t} while (++nb_tx < nb_replies);\n+\t\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_replies - nb_tx);\n \t\t}\n \t}\n \ndiff --git a/app/test-pmd/iofwd.c b/app/test-pmd/iofwd.c\nindex 8218bd6b4b..9d0af5f667 100644\n--- a/app/test-pmd/iofwd.c\n+++ b/app/test-pmd/iofwd.c\n@@ -76,9 +76,7 @@ pkt_burst_io_forward(struct fwd_stream *fs)\n \tinc_tx_burst_stats(fs, nb_tx);\n \tif (unlikely(nb_tx < nb_rx)) {\n \t\tfs->fwd_dropped += (nb_rx - nb_tx);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_rx);\n+\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_rx - nb_tx);\n \t}\n \n \treturn true;\ndiff --git a/app/test-pmd/macfwd.c b/app/test-pmd/macfwd.c\nindex c1b116e559..3a840247c7 100644\n--- a/app/test-pmd/macfwd.c\n+++ b/app/test-pmd/macfwd.c\n@@ -107,9 +107,7 @@ pkt_burst_mac_forward(struct fwd_stream *fs)\n \tinc_tx_burst_stats(fs, nb_tx);\n \tif (unlikely(nb_tx < nb_rx)) {\n \t\tfs->fwd_dropped += (nb_rx - nb_tx);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_rx);\n+\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_rx - nb_tx);\n \t}\n \n \treturn true;\ndiff --git a/app/test-pmd/macswap.c b/app/test-pmd/macswap.c\nindex 361341e075..14b3eefffd 100644\n--- a/app/test-pmd/macswap.c\n+++ b/app/test-pmd/macswap.c\n@@ -86,9 +86,7 @@ pkt_burst_mac_swap(struct fwd_stream *fs)\n \tinc_tx_burst_stats(fs, nb_tx);\n \tif (unlikely(nb_tx < nb_rx)) {\n \t\tfs->fwd_dropped += (nb_rx - nb_tx);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_rx);\n+\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_rx - nb_tx);\n \t}\n \n \treturn true;\ndiff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c\nindex e2fecafeac..ecea51b603 100644\n--- a/app/test-pmd/noisy_vnf.c\n+++ b/app/test-pmd/noisy_vnf.c\n@@ -111,11 +111,8 @@ do_retry(uint16_t nb_rx, uint16_t nb_tx, struct rte_mbuf **pkts,\n static uint32_t\n drop_pkts(struct rte_mbuf **pkts, uint16_t nb_rx, uint16_t nb_tx)\n {\n-\tif (nb_tx < nb_rx) {\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts[nb_tx]);\n-\t\t} while (++nb_tx < nb_rx);\n-\t}\n+\tif (nb_tx < nb_rx)\n+\t\trte_pktmbuf_free_bulk(&pkts[nb_tx], nb_rx - nb_tx);\n \n \treturn nb_rx - nb_tx;\n }\ndiff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c\nindex 375be990bd..ad4597cf9a 100644\n--- a/app/test-pmd/rxonly.c\n+++ b/app/test-pmd/rxonly.c\n@@ -46,7 +46,6 @@ pkt_burst_receive(struct fwd_stream *fs)\n {\n \tstruct rte_mbuf *pkts_burst[MAX_PKT_BURST];\n \tuint16_t nb_rx;\n-\tuint16_t i;\n \n \t/*\n \t * Receive a burst of packets.\n@@ -58,8 +57,7 @@ pkt_burst_receive(struct fwd_stream *fs)\n \t\treturn false;\n \n \tfs->rx_packets += nb_rx;\n-\tfor (i = 0; i < nb_rx; i++)\n-\t\trte_pktmbuf_free(pkts_burst[i]);\n+\trte_pktmbuf_free_bulk(pkts_burst, nb_rx);\n \n \treturn true;\n }\ndiff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c\nindex 4b3a87a3ba..4902ec407e 100644\n--- a/app/test-pmd/shared_rxq_fwd.c\n+++ b/app/test-pmd/shared_rxq_fwd.c\n@@ -53,8 +53,7 @@ forward_sub_burst(struct fwd_stream *src_fs, uint16_t port, uint16_t nb_rx,\n \t} else {\n \t\t/* Source stream not found, drop all packets. */\n \t\tsrc_fs->fwd_dropped += nb_rx;\n-\t\twhile (nb_rx > 0)\n-\t\t\trte_pktmbuf_free(pkts[--nb_rx]);\n+\t\trte_pktmbuf_free_bulk(pkts, nb_rx);\n \t}\n }\n \ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 9afc107975..dab67bce5c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2196,7 +2196,6 @@ flush_fwd_rx_queues(void)\n \tportid_t port_id;\n \tqueueid_t rxq;\n \tuint16_t nb_rx;\n-\tuint16_t i;\n \tuint8_t j;\n \tuint64_t prev_tsc = 0, diff_tsc, cur_tsc, timer_tsc = 0;\n \tuint64_t timer_period;\n@@ -2229,8 +2228,7 @@ flush_fwd_rx_queues(void)\n \t\t\t\tdo {\n \t\t\t\t\tnb_rx = rte_eth_rx_burst(port_id, rxq,\n \t\t\t\t\t\tpkts_burst, MAX_PKT_BURST);\n-\t\t\t\t\tfor (i = 0; i < nb_rx; i++)\n-\t\t\t\t\t\trte_pktmbuf_free(pkts_burst[i]);\n+\t\t\t\t\trte_pktmbuf_free_bulk(pkts_burst, nb_rx);\n \n \t\t\t\t\tcur_tsc = rte_rdtsc();\n \t\t\t\t\tdiff_tsc = cur_tsc - prev_tsc;\ndiff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c\nindex 23e51a1bec..63ad5e69bf 100644\n--- a/app/test-pmd/txonly.c\n+++ b/app/test-pmd/txonly.c\n@@ -418,9 +418,7 @@ pkt_burst_transmit(struct fwd_stream *fs)\n \t\t\t (unsigned) nb_pkt, (unsigned) nb_tx,\n \t\t\t (unsigned) (nb_pkt - nb_tx));\n \t\tfs->fwd_dropped += (nb_pkt - nb_tx);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(pkts_burst[nb_tx]);\n-\t\t} while (++nb_tx < nb_pkt);\n+\t\trte_pktmbuf_free_bulk(&pkts_burst[nb_tx], nb_pkt - nb_tx);\n \t}\n \n \treturn true;\n", "prefixes": [ "3/6" ] }