Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122404/?format=api
http://patches.dpdk.org/api/patches/122404/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230120044140.95975-8-okaya@kernel.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230120044140.95975-8-okaya@kernel.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230120044140.95975-8-okaya@kernel.org", "date": "2023-01-20T04:41:37", "name": "[v3,07/10] malloc: check result of rte_mem_virt2memseg", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9318e66d2aa47f21bbfb753e6d267d6704815073", "submitter": { "id": 2903, "url": "http://patches.dpdk.org/api/people/2903/?format=api", "name": "Sinan Kaya", "email": "okaya@kernel.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230120044140.95975-8-okaya@kernel.org/mbox/", "series": [ { "id": 26621, "url": "http://patches.dpdk.org/api/series/26621/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26621", "date": "2023-01-20T04:41:30", "name": "codeql fixes for various subsystems", "version": 3, "mbox": "http://patches.dpdk.org/series/26621/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122404/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/122404/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEFCD4242A;\n\tFri, 20 Jan 2023 05:42:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1640842DCD;\n\tFri, 20 Jan 2023 05:42:00 +0100 (CET)", "from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])\n by mails.dpdk.org (Postfix) with ESMTP id D193A42DAE\n for <dev@dpdk.org>; Fri, 20 Jan 2023 05:41:55 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id 9B784B81AFA;\n Fri, 20 Jan 2023 04:41:55 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id E3722C433D2;\n Fri, 20 Jan 2023 04:41:53 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1674189714;\n bh=W2hMNo666ixKADSmKcIGEqrJdVzX4Yclf2h5OFo6Gqg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=RCbm/0UqmmvjRJuf9zMow/N04aUhN8A6bmOAoMSI6/suMBZnsB8oj8gcvr3/+b3hY\n Mme68pGwc1N8H3YbrnY5Fy3Mseo1hmjRAxLsdOCq2NxOHdaS58BUkBeSLyGD/l5mIR\n DUD6HmXWS3POQVz++9xFeNVAnLUKacvWOw1MFNgFLKnHY4/AaTLgho+pufiLSz86z4\n ZqhZRHQ8TVH+jFfwq+2M/fhn2ebF6aGW1ux4UygCUAtTzWc771pYT0xUXkd4Wqj/OO\n L4OdNZyc3wBGSBjDZjNiVOR+ctdxRTIeWj2S8xZmQ95kXChtFd5wNZUCRJibr2Xzn5\n pRP6R/+Hjn9Ng==", "From": "okaya@kernel.org", "To": "Anatoly Burakov <anatoly.burakov@intel.com>", "Cc": "dev@dpdk.org,\n\tSinan Kaya <okaya@kernel.org>", "Subject": "[PATCH v3 07/10] malloc: check result of rte_mem_virt2memseg", "Date": "Thu, 19 Jan 2023 23:41:37 -0500", "Message-Id": "<20230120044140.95975-8-okaya@kernel.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230120044140.95975-1-okaya@kernel.org>", "References": "<20230120044140.95975-1-okaya@kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sinan Kaya <okaya@kernel.org>\n\nIn malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg\nis dereferenced here and may be null.\n\nSigned-off-by: Sinan Kaya <okaya@kernel.org>\n---\n lib/eal/common/malloc_elem.c | 11 ++++++++---\n lib/eal/common/malloc_heap.c | 2 +-\n 2 files changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c\nindex 83f05497cc..8f49812846 100644\n--- a/lib/eal/common/malloc_elem.c\n+++ b/lib/eal/common/malloc_elem.c\n@@ -63,6 +63,8 @@ malloc_elem_find_max_iova_contig(struct malloc_elem *elem, size_t align)\n \n \tcur_page = RTE_PTR_ALIGN_FLOOR(contig_seg_start, page_sz);\n \tms = rte_mem_virt2memseg(cur_page, elem->msl);\n+\tif (ms == NULL)\n+\t\treturn 0;\n \n \t/* do first iteration outside the loop */\n \tpage_end = RTE_PTR_ADD(cur_page, page_sz);\n@@ -91,9 +93,12 @@ malloc_elem_find_max_iova_contig(struct malloc_elem *elem, size_t align)\n \t\t\t * we're not blowing past data end.\n \t\t\t */\n \t\t\tms = rte_mem_virt2memseg(contig_seg_start, elem->msl);\n-\t\t\tcur_page = ms->addr;\n-\t\t\t/* don't trigger another recalculation */\n-\t\t\texpected_iova = ms->iova;\n+\t\t\tif (ms != NULL) {\n+\t\t\t\tcur_page = ms->addr;\n+\n+\t\t\t\t/* don't trigger another recalculation */\n+\t\t\t\texpected_iova = ms->iova;\n+\t\t\t}\n \t\t\tcontinue;\n \t\t}\n \t\t/* cur_seg_end ends on a page boundary or on data end. if we're\ndiff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c\nindex 3f41430e42..88270ce4d2 100644\n--- a/lib/eal/common/malloc_heap.c\n+++ b/lib/eal/common/malloc_heap.c\n@@ -930,7 +930,7 @@ malloc_heap_free(struct malloc_elem *elem)\n \t\tconst struct rte_memseg *tmp =\n \t\t\t\trte_mem_virt2memseg(aligned_start, msl);\n \n-\t\tif (tmp->flags & RTE_MEMSEG_FLAG_DO_NOT_FREE) {\n+\t\tif ((tmp != NULL) && (tmp->flags & RTE_MEMSEG_FLAG_DO_NOT_FREE)) {\n \t\t\t/* this is an unfreeable segment, so move start */\n \t\t\taligned_start = RTE_PTR_ADD(tmp->addr, tmp->len);\n \t\t}\n", "prefixes": [ "v3", "07/10" ] }{ "id": 122404, "url": "