Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/122025/?format=api
{ "id": 122025, "url": "http://patches.dpdk.org/api/patches/122025/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230113081931.221576-19-mingxia.liu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230113081931.221576-19-mingxia.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230113081931.221576-19-mingxia.liu@intel.com", "date": "2023-01-13T08:19:28", "name": "[v2,18/21] net/cpfl: add hw statistics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "00ab2405a22b878bdaea8fd8d710c6a6d9fe9907", "submitter": { "id": 2514, "url": "http://patches.dpdk.org/api/people/2514/?format=api", "name": "Liu, Mingxia", "email": "mingxia.liu@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230113081931.221576-19-mingxia.liu@intel.com/mbox/", "series": [ { "id": 26532, "url": "http://patches.dpdk.org/api/series/26532/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26532", "date": "2023-01-13T08:19:10", "name": "add support for cpfl PMD in DPDK", "version": 2, "mbox": "http://patches.dpdk.org/series/26532/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/122025/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/122025/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 58C70423C1;\n\tFri, 13 Jan 2023 10:17:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7DB68410EF;\n\tFri, 13 Jan 2023 10:15:36 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 52AA042DFB\n for <dev@dpdk.org>; Fri, 13 Jan 2023 10:15:27 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2023 01:15:27 -0800", "from dpdk-mingxial-01.sh.intel.com ([10.67.119.167])\n by fmsmga006.fm.intel.com with ESMTP; 13 Jan 2023 01:15:25 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673601327; x=1705137327;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=huTi3Xf5V/qfTdXDtn34lKbb4d659OmJvf85KJqACS8=;\n b=ObJZC3JC0diFaym4eEGj9hUZfLidt3fsjL5hDO18ujbnbq+gNFJwlk0i\n su68FAoFppW9nUGgrZNNS+7e9IoXNHZfJmR1Pe5BKOvAX2E8e6z43ypz+\n uIlStR+T+RGwtt+tPv6TAOoMV/bdkaF1HEiXvRYxUg1INEa3b/Dh/qb3N\n KXkECp3Mz8uCAFTZp20cDPnVFhfi9TzQaI+95vs/Lg82pgsm3PFeMuFcN\n myHPWz6tX5v3gsTo7+LBBOcgzVRcnjSvE8quH+bGi/cT6ruK4J4ZpgVAS\n 5bLqmToChd6LyPtRFcAAVuYhPxjL/GWXYUEGOX9eKmzYBDMy4yY6Y8DiH g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10588\"; a=\"304332573\"", "E=Sophos;i=\"5.97,213,1669104000\"; d=\"scan'208\";a=\"304332573\"", "E=McAfee;i=\"6500,9779,10588\"; a=\"903522772\"", "E=Sophos;i=\"5.97,213,1669104000\"; d=\"scan'208\";a=\"903522772\"" ], "X-ExtLoop1": "1", "From": "Mingxia Liu <mingxia.liu@intel.com>", "To": "dev@dpdk.org, qi.z.zhang@intel.com, jingjing.wu@intel.com,\n beilei.xing@intel.com", "Cc": "wenjun1.wu@intel.com,\n\tMingxia Liu <mingxia.liu@intel.com>", "Subject": "[PATCH v2 18/21] net/cpfl: add hw statistics", "Date": "Fri, 13 Jan 2023 08:19:28 +0000", "Message-Id": "<20230113081931.221576-19-mingxia.liu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230113081931.221576-1-mingxia.liu@intel.com>", "References": "<20221223015558.3143279-1-mingxia.liu@intel.com>\n <20230113081931.221576-1-mingxia.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch add hardware packets/bytes statistics.\n\nSigned-off-by: Mingxia Liu <mingxia.liu@intel.com>\n---\n drivers/net/cpfl/cpfl_ethdev.c | 88 ++++++++++++++++++++++++++++++++++\n drivers/net/idpf/idpf_ethdev.c | 3 +-\n 2 files changed, 90 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex 5fc40f8298..9ae653b99a 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -178,6 +178,87 @@ cpfl_dev_supported_ptypes_get(struct rte_eth_dev *dev __rte_unused)\n \treturn ptypes;\n }\n \n+static uint64_t\n+cpfl_get_mbuf_alloc_failed_stats(struct rte_eth_dev *dev)\n+{\n+\tuint64_t mbuf_alloc_failed = 0;\n+\tstruct idpf_rx_queue *rxq;\n+\tint i = 0;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\trxq = dev->data->rx_queues[i];\n+\t\tmbuf_alloc_failed +=\n+\t\t rte_atomic64_read(&(rxq->rx_stats.mbuf_alloc_failed));\n+\t}\n+\n+\treturn mbuf_alloc_failed;\n+}\n+\n+static int\n+cpfl_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tstruct idpf_vport *vport =\n+\t\t(struct idpf_vport *)dev->data->dev_private;\n+\tstruct virtchnl2_vport_stats *pstats = NULL;\n+\tint ret;\n+\n+\tret = idpf_query_stats(vport, &pstats);\n+\tif (ret == 0) {\n+\t\tuint8_t crc_stats_len = (dev->data->dev_conf.rxmode.offloads &\n+\t\t\t\t\t RTE_ETH_RX_OFFLOAD_KEEP_CRC) ? 0 :\n+\t\t\t\t\t RTE_ETHER_CRC_LEN;\n+\n+\t\tidpf_update_stats(&vport->eth_stats_offset, pstats);\n+\t\tstats->ipackets = pstats->rx_unicast + pstats->rx_multicast +\n+\t\t\t\tpstats->rx_broadcast - pstats->rx_discards;\n+\t\tstats->opackets = pstats->tx_broadcast + pstats->tx_multicast +\n+\t\t\t\t\t\tpstats->tx_unicast;\n+\t\tstats->imissed = pstats->rx_discards;\n+\t\tstats->oerrors = pstats->tx_errors + pstats->tx_discards;\n+\t\tstats->ibytes = pstats->rx_bytes;\n+\t\tstats->ibytes -= stats->ipackets * crc_stats_len;\n+\t\tstats->obytes = pstats->tx_bytes;\n+\n+\t\tdev->data->rx_mbuf_alloc_failed = cpfl_get_mbuf_alloc_failed_stats(dev);\n+\t\tstats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;\n+\t} else {\n+\t\tPMD_DRV_LOG(ERR, \"Get statistics failed\");\n+\t}\n+\treturn ret;\n+}\n+\n+static void\n+cpfl_reset_mbuf_alloc_failed_stats(struct rte_eth_dev *dev)\n+{\n+\tstruct idpf_rx_queue *rxq;\n+\tint i;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\trxq = dev->data->rx_queues[i];\n+\t\trte_atomic64_set(&(rxq->rx_stats.mbuf_alloc_failed), 0);\n+\t}\n+}\n+\n+static int\n+cpfl_dev_stats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct idpf_vport *vport =\n+\t\t(struct idpf_vport *)dev->data->dev_private;\n+\tstruct virtchnl2_vport_stats *pstats = NULL;\n+\tint ret;\n+\n+\tret = idpf_query_stats(vport, &pstats);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\t/* set stats offset base on current values */\n+\tvport->eth_stats_offset = *pstats;\n+\n+\tcpfl_reset_mbuf_alloc_failed_stats(dev);\n+\n+\treturn 0;\n+}\n+\n static int\n cpfl_init_rss(struct idpf_vport *vport)\n {\n@@ -365,6 +446,11 @@ cpfl_dev_start(struct rte_eth_dev *dev)\n \t\tgoto err_vport;\n \t}\n \n+\tif (cpfl_dev_stats_reset(dev)) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to reset stats\");\n+\t\tgoto err_vport;\n+\t}\n+\n \tvport->stopped = 0;\n \n \treturn 0;\n@@ -766,6 +852,8 @@ static const struct eth_dev_ops cpfl_eth_dev_ops = {\n \t.tx_queue_release\t\t= cpfl_dev_tx_queue_release,\n \t.mtu_set\t\t\t= cpfl_dev_mtu_set,\n \t.dev_supported_ptypes_get\t= cpfl_dev_supported_ptypes_get,\n+\t.stats_get\t\t\t= cpfl_dev_stats_get,\n+\t.stats_reset\t\t\t= cpfl_dev_stats_reset,\n };\n \n static uint16_t\ndiff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex bcd15db3c5..b2cf959ee7 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -824,13 +824,14 @@ idpf_dev_start(struct rte_eth_dev *dev)\n \n \tif (idpf_dev_stats_reset(dev)) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to reset stats\");\n-\t\tgoto err_vport;\n+\t\tgoto err_stats_reset;\n \t}\n \n \tvport->stopped = 0;\n \n \treturn 0;\n \n+err_stats_reset:\n err_vport:\n \tidpf_stop_queues(dev);\n err_startq:\n", "prefixes": [ "v2", "18/21" ] }