Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 12202,
    "url": "http://patches.dpdk.org/api/patches/12202/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1461321661-30272-1-git-send-email-michalx.kobylinski@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1461321661-30272-1-git-send-email-michalx.kobylinski@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1461321661-30272-1-git-send-email-michalx.kobylinski@intel.com",
    "date": "2016-04-22T10:41:01",
    "name": "[dpdk-dev] cfgfile: fix integer overflow",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "0c6eb79a36d7f712360f2a9fd0d863aaade8f0c5",
    "submitter": {
        "id": 322,
        "url": "http://patches.dpdk.org/api/people/322/?format=api",
        "name": "Michal Kobylinski",
        "email": "michalx.kobylinski@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1461321661-30272-1-git-send-email-michalx.kobylinski@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/12202/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/12202/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 93DAC2E83;\n\tFri, 22 Apr 2016 13:11:48 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id EC0772C4B\n\tfor <dev@dpdk.org>; Fri, 22 Apr 2016 13:11:46 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP; 22 Apr 2016 04:11:47 -0700",
            "from gklab-246-020.igk.intel.com (HELO Sent) ([10.217.246.20])\n\tby fmsmga002.fm.intel.com with SMTP; 22 Apr 2016 04:11:44 -0700",
            "by Sent (sSMTP sendmail emulation); Fri, 22 Apr 2016 12:41:03 +0200"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.24,516,1455004800\"; d=\"scan'208\";a=\"964218220\"",
        "From": "Michal Kobylinski <michalx.kobylinski@intel.com>",
        "To": "cristian.dumitrescu@intel.com,\n\tdev@dpdk.org",
        "Cc": "Michal Kobylinski <michalx.kobylinski@intel.com>",
        "Date": "Fri, 22 Apr 2016 12:41:01 +0200",
        "Message-Id": "<1461321661-30272-1-git-send-email-michalx.kobylinski@intel.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "Subject": "[dpdk-dev] [PATCH] cfgfile: fix integer overflow",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix issue reported by Coverity.\n\nCoverity ID 13289: Integer overflowed argument: The argument will be too\nsmall or even negative, likely resulting in unexpected behavior (for\nexample, under-allocation in a memory allocation function).\nIn rte_cfgfile_load: An integer overflow occurs, with the overflowed\nvalue used as an argument to a function\n\nFixes: eaafbad419bf (\"cfgfile: library to interpret config files\")\n\nSigned-off-by: Michal Kobylinski <michalx.kobylinski@intel.com>\n---\n lib/librte_cfgfile/rte_cfgfile.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c\nindex 75625a2..0a5a279 100644\n--- a/lib/librte_cfgfile/rte_cfgfile.c\n+++ b/lib/librte_cfgfile/rte_cfgfile.c\n@@ -135,7 +135,7 @@ rte_cfgfile_load(const char *filename, int flags)\n \t\t\t\tgoto error1;\n \t\t\t}\n \t\t\t*end = '\\0';\n-\t\t\t_strip(&buffer[1], end - &buffer[1]);\n+\t\t\t_strip(&buffer[1], (unsigned)(end - &buffer[1]));\n \n \t\t\t/* close off old section and add start new one */\n \t\t\tif (curr_section >= 0)\n",
    "prefixes": [
        "dpdk-dev"
    ]
}