Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121628/?format=api
{ "id": 121628, "url": "http://patches.dpdk.org/api/patches/121628/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230105161020.247780-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230105161020.247780-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20230105161020.247780-3-thomas@monjalon.net", "date": "2023-01-05T16:10:19", "name": "[2/3] common/mlx5: get Windows dependency from standard variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4b9a1491b92706dc96420968488c3df193085089", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230105161020.247780-3-thomas@monjalon.net/mbox/", "series": [ { "id": 26402, "url": "http://patches.dpdk.org/api/series/26402/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26402", "date": "2023-01-05T16:10:17", "name": "fix mlx5 build with MinGW", "version": 1, "mbox": "http://patches.dpdk.org/series/26402/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/121628/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/121628/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 110FCA00C2;\n\tThu, 5 Jan 2023 17:10:48 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 74C1F42D3E;\n\tThu, 5 Jan 2023 17:10:44 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 374F542D3C\n for <dev@dpdk.org>; Thu, 5 Jan 2023 17:10:43 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.46])\n by mailout.nyi.internal (Postfix) with ESMTP id AF5C55C019B;\n Thu, 5 Jan 2023 11:10:42 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Thu, 05 Jan 2023 11:10:42 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Thu,\n 5 Jan 2023 11:10:41 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to\n :in-reply-to:message-id:mime-version:references:reply-to:sender\n :subject:subject:to:to; s=fm2; t=1672935042; x=1673021442; bh=ib\n 7O1LGwUD2a+Fc+GF+TMgShESWR+pgoLmv/rJeBiQM=; b=UkwEel9IKeWKpLnrnw\n gMHR3yshX3JW6dWmp0EdI4rsN84jVZ3SnkLFFumGW9un6WSGd6DbZtrJfs92Dz1Z\n ZfrrZwjgH3l6KHO/DhqC5zh9Ea/LK1cPhKe+JjdCMU0vT7/kNC+QvK1A1wH4qB9y\n 2FgXri5i2b+xU4y2KcTGIf6PaFqfnwM1JMb89/lo508q39l+J4nlAM5oqPdo5JaC\n CFd8RCv136U1UCzNRa6dIIZCKiniqMuHQF6Y2DNxT510pohC731+q+DmnprfWg4P\n mQhuhqKwTf+Yxq8VmeBkQU7u/bjmW9M/uTtz/K/IkrQQVCN7LR/iBB4TVidjmIcg\n fiYg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding:date:date\n :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to\n :message-id:mime-version:references:reply-to:sender:subject\n :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm2; t=1672935042; x=1673021442; bh=ib7O1LGwUD2a+\n Fc+GF+TMgShESWR+pgoLmv/rJeBiQM=; b=ilfWKhLR2YFsEyZdHspa54uMDs1Ro\n NHSnbZhn7SnKDbdG9xFmZV0Fbl+mkschPxLgO1KoDwbi+Vmq2MoFO74awCBuJhl2\n NJBJ5C9wiCYXP46OZ/SuQGdqcQe7jDRWC2bJJxejdshzf4DMocLzKkQNbqVa8GsQ\n WuJPURALMeg3OmxpG11se4wHkGDRxJSM8k/mzcm4YbyfoVf/ny1NTzd41QNf3eEe\n yKoOHzECJW0P+2Yqa4GXyCkEthnhIh7Xfp48jWmdILX5SCoS1NwMiQfpDCuARV9X\n /NbhWaZ7tfBZlga3KpkzStXyRroM9BhOXwyCHzMKPykfpP/ZFcPfWdnkA==" ], "X-ME-Sender": "<xms:gva2Y2eRu-LGp5GEWw0ya2z8cc-1uXBuoKftMxaXS_FHo_6iYoKbnQ>\n <xme:gva2YwOPabNhzCDV-HxaSWjM21GcqH2uBLz7-wH4L5EpXg-lHpMbDvtYNn-b2agY_\n jsmtwWXEwvEU5TXfQ>", "X-ME-Received": "\n <xmr:gva2Y3jukqLiUtlK0F8XR_Nz5N4YUZhaS5a3IfRPkB9akIiTjy_VlqBZb767ekRY6kNNt4CQsNic5akFWMLaAltoZKfoUv0>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvhedrjeekgdekjecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdejhfdugeehvddtieejieegteeuudfgjeeukeeiledthfetveek\n hefhieelhfdtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh\n homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:gva2Yz_FUmZq3YbC-mVXPoMRACDL9LMMJqoYiR7VMHBWnosrQ8ZzZQ>\n <xmx:gva2YytazKK0kvJjOsY89ogsOCpGlClustpo02Oj8xzei6ckqaUTag>\n <xmx:gva2Y6Gij9Q6oejKNlrEoZDHGqb4BURZoiZLOi_TRUjuA959I0-3hQ>\n <xmx:gva2Y75hWmLkvGma_YAXm8JEBGGcZC2TF0DMD-a6x_C95t5ZXsnGow>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Tal Shnaiderman <talshn@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Subject": "[PATCH 2/3] common/mlx5: get Windows dependency from standard\n variables", "Date": "Thu, 5 Jan 2023 17:10:19 +0100", "Message-Id": "<20230105161020.247780-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.39.0", "In-Reply-To": "<20230105161020.247780-1-thomas@monjalon.net>", "References": "<20230105161020.247780-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "It was requested to provide path to DevX library through\nDEVX_INC_PATH and DEVX_LIB_PATH.\nIt was non-standard and triggers some issues with recent Meson.\n\nUsing CFLAGS/LDFLAGS is standard and simpler.\nIt is also possible to use the Meson options -Dc_args and -Dc_link_args.\nThere are 2 options to provide:\n\t-I<include_directory>\n\t-L<library_directory>\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n doc/guides/platform/mlx5.rst | 12 ++++++-----\n drivers/common/mlx5/windows/meson.build | 28 ++++++++++++-------------\n 2 files changed, 21 insertions(+), 19 deletions(-)", "diff": "diff --git a/doc/guides/platform/mlx5.rst b/doc/guides/platform/mlx5.rst\nindex 5784b9a87b..33eb8627b5 100644\n--- a/doc/guides/platform/mlx5.rst\n+++ b/doc/guides/platform/mlx5.rst\n@@ -259,13 +259,15 @@ configured by the ``ibverbs_link`` build option:\n Compilation on Windows\n ~~~~~~~~~~~~~~~~~~~~~~\n \n-The DevX SDK location must be set through two environment variables:\n+The DevX SDK location must be set through CFLAGS/LDFLAGS,\n+either::\n \n-``DEVX_LIB_PATH``\n- path to the DevX lib file.\n+ meson -Dc_args=-Idevx/inc -Dc_link_args=-Ldevx/lib\n \n-``DEVX_INC_PATH``\n- path to the DevX header files.\n+or::\n+\n+ export CFLAGS=-Idevx/inc\n+ export LDFLAGS=-Ldevx/lib\n \n \n .. _mlx5_common_env:\ndiff --git a/drivers/common/mlx5/windows/meson.build b/drivers/common/mlx5/windows/meson.build\nindex cc486014a8..f60daed840 100644\n--- a/drivers/common/mlx5/windows/meson.build\n+++ b/drivers/common/mlx5/windows/meson.build\n@@ -1,6 +1,20 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright 2019 Mellanox Technologies, Ltd\n \n+if not cc.has_header('mlx5devx.h')\n+ build = false\n+ reason = 'missing dependency, \"mlx5devx.h\"'\n+ subdir_done()\n+endif\n+\n+devxlib = cc.find_library('mlx5devx', required: true)\n+if not devxlib.found()\n+ build = false\n+ reason = 'missing dependency, \"mlx5devx\"'\n+ subdir_done()\n+endif\n+ext_deps += devxlib\n+\n includes += include_directories('.')\n \n sources += files(\n@@ -8,20 +22,6 @@ sources += files(\n 'mlx5_common_os.c',\n )\n \n-res_lib = run_command(python3, '-c', 'import os; print(os.environ[\"DEVX_LIB_PATH\"])', check: false)\n-res_inc = run_command(python3, '-c', 'import os; print(os.environ[\"DEVX_INC_PATH\"])', check: false)\n-\n-if (res_lib.returncode() != 0 or res_inc.returncode() != 0)\n- build = false\n- reason = 'DevX environment variables are not set, DEVX_LIB_PATH and DEVX_INC_PATH vars must be exported'\n- subdir_done()\n-endif\n-\n-devx_lib_dir = res_lib.stdout().strip()\n-devx_inc_dir = res_inc.stdout().strip()\n-\n-ext_deps += cc.find_library('mlx5devx', dirs: devx_lib_dir, required: true)\n-includes += include_directories(devx_inc_dir)\n cflags_options = [\n '-std=c11',\n '-Wno-strict-prototypes',\n", "prefixes": [ "2/3" ] }