Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/12121/?format=api
{ "id": 12121, "url": "http://patches.dpdk.org/api/patches/12121/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1461098825-21640-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1461098825-21640-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1461098825-21640-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-04-19T20:47:05", "name": "[dpdk-dev] eal: remove useless internal function from memcpy headers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "398375ef7f3ac7c697a40c50845949158549349c", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1461098825-21640-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/12121/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/12121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 894BE2C6A;\n\tTue, 19 Apr 2016 22:47:38 +0200 (CEST)", "from mail-wm0-f53.google.com (mail-wm0-f53.google.com\n\t[74.125.82.53]) by dpdk.org (Postfix) with ESMTP id DD42B2C5A\n\tfor <dev@dpdk.org>; Tue, 19 Apr 2016 22:47:36 +0200 (CEST)", "by mail-wm0-f53.google.com with SMTP id e201so28120559wme.0\n\tfor <dev@dpdk.org>; Tue, 19 Apr 2016 13:47:36 -0700 (PDT)", "from XPS13.localdomain (guy78-1-82-235-116-147.fbx.proxad.net.\n\t[82.235.116.147]) by smtp.gmail.com with ESMTPSA id\n\tu192sm6094762wmd.11.2016.04.19.13.47.35\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 19 Apr 2016 13:47:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=WPwhKAg25nYQzX/TCy/3SHi8SuATLcrkIB3+7htGWKY=;\n\tb=uDUtOx2QKAgNeOmYWjItxWW13YrqFtmkbQDkAEjiSqMrA0FzoY593bv8VdCQErA3JL\n\t8yPquj8UOWzzWIvBpE6LlZxiUg3eylbd7F+y/yzf5h2Ie9HwejrdtFVlIpsgtBPI4dJq\n\thSpFwQtf1IBN68J8iMu4iI1Q0PqzkCdXtLHUjO/dNshnZZ50W+wWI2N/nzfD897XiRrF\n\tY8hqTfgNFle8WrXJmmHwBUefLiFhsFDLsjBU9EbJCluoN0UYfKy8OBcfRMpPbShX+rjq\n\tDrLCmJa3N8q8pFYXOSZiylln8mjsLBAH4lEaG0R8MlZBJQlCP4KOB1AyyHMYelIMwmsO\n\tRq9w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=WPwhKAg25nYQzX/TCy/3SHi8SuATLcrkIB3+7htGWKY=;\n\tb=QysVFCx1HT46x4yslidOlHgI6Lni0kOYu8tdm+/BYMxvGetNB3DZnn8gcRMmmOoGzp\n\tdtcMrI6X9k92vPNzw1JhttpqaFMXgp0wDjyRXFbJOfr6okUl+6Dyd7D8xXczyVXdB1v7\n\tVOye8U81mX0p/fGY2SdNtS/wtHS1nE9m8d5VVx0xVCrxXcA0eO1HWVjr6S4/OBXKXMZO\n\t5+DRa3Bo8E53509vEEv+g0sgeH/y96DkjrPM0IQqH9xcpjwmGzlEYp4KRuQgcuHJbWo9\n\tB1h1nRQBPZ8MqiMiOAa08w+gz6oWU+IauA5HOYZc+umTzEcCOh+VQqwHvhrtTZk4gzc5\n\tBl8w==", "X-Gm-Message-State": "AOPr4FXBk82fzZdiOdIRXnRpoaFTc2XF3aX7lWzoYQji5JZD/9cBp0tAkMyfYHtjo+3WQwl5", "X-Received": "by 10.28.24.80 with SMTP id 77mr25229792wmy.16.1461098856708;\n\tTue, 19 Apr 2016 13:47:36 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "david.marchand@6wind.com", "Cc": "dev@dpdk.org", "Date": "Tue, 19 Apr 2016 22:47:05 +0200", "Message-Id": "<1461098825-21640-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] eal: remove useless internal function from\n\tmemcpy headers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function rte_memcpy_func() is used in ARM and PPC implementations\nof rte_memcpy().\nThere are some useless copies in Tile and some ARM branches.\nIt was also declared without doxygen comment in the generic header.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 6 ------\n lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h | 6 ------\n lib/librte_eal/common/include/arch/tile/rte_memcpy.h | 6 ------\n lib/librte_eal/common/include/generic/rte_memcpy.h | 7 -------\n 4 files changed, 25 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h b/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h\nindex 988125b..da6c233 100644\n--- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h\n+++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h\n@@ -323,12 +323,6 @@ rte_memcpy(void *dst, const void *src, size_t n)\n \treturn memcpy(dst, src, n);\n }\n \n-static inline void *\n-rte_memcpy_func(void *dst, const void *src, size_t n)\n-{\n-\treturn memcpy(dst, src, n);\n-}\n-\n #endif /* RTE_ARCH_ARM_NEON_MEMCPY */\n \n #ifdef __cplusplus\ndiff --git a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h\nindex 917cdc1..5db66b6 100644\n--- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h\n+++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h\n@@ -80,12 +80,6 @@ rte_mov256(uint8_t *dst, const uint8_t *src)\n \n #define rte_memcpy(d, s, n)\tmemcpy((d), (s), (n))\n \n-static inline void *\n-rte_memcpy_func(void *dst, const void *src, size_t n)\n-{\n-\treturn memcpy(dst, src, n);\n-}\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/common/include/arch/tile/rte_memcpy.h b/lib/librte_eal/common/include/arch/tile/rte_memcpy.h\nindex 9b5b37e..e606957 100644\n--- a/lib/librte_eal/common/include/arch/tile/rte_memcpy.h\n+++ b/lib/librte_eal/common/include/arch/tile/rte_memcpy.h\n@@ -80,12 +80,6 @@ rte_mov256(uint8_t *dst, const uint8_t *src)\n \n #define rte_memcpy(d, s, n)\tmemcpy((d), (s), (n))\n \n-static inline void *\n-rte_memcpy_func(void *dst, const void *src, size_t n)\n-{\n-\treturn memcpy(dst, src, n);\n-}\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_eal/common/include/generic/rte_memcpy.h b/lib/librte_eal/common/include/generic/rte_memcpy.h\nindex 03e8477..afb0afe 100644\n--- a/lib/librte_eal/common/include/generic/rte_memcpy.h\n+++ b/lib/librte_eal/common/include/generic/rte_memcpy.h\n@@ -134,11 +134,4 @@ rte_memcpy(void *dst, const void *src, size_t n);\n \n #endif /* __DOXYGEN__ */\n \n-/*\n- * memcpy() function used by rte_memcpy macro\n- */\n-static inline void *\n-rte_memcpy_func(void *dst, const void *src, size_t n) __attribute__((always_inline));\n-\n-\n #endif /* _RTE_MEMCPY_H_ */\n", "prefixes": [ "dpdk-dev" ] }