Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121145/?format=api
{ "id": 121145, "url": "http://patches.dpdk.org/api/patches/121145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221221025202.31733-2-jesna.k.e@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221221025202.31733-2-jesna.k.e@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221221025202.31733-2-jesna.k.e@amd.com", "date": "2022-12-21T02:52:02", "name": "[v1,2/2] net/axgbe: move offloads to Rx/Tx queue setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "16143ebacc620a1bcafdfe27bb4e4a08a3ccb50d", "submitter": { "id": 2920, "url": "http://patches.dpdk.org/api/people/2920/?format=api", "name": "Jesna K E", "email": "jesna.k.e@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221221025202.31733-2-jesna.k.e@amd.com/mbox/", "series": [ { "id": 26203, "url": "http://patches.dpdk.org/api/series/26203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26203", "date": "2022-12-21T02:52:01", "name": "[v1,1/2] net/axgbe: add multi-process support", "version": 1, "mbox": "http://patches.dpdk.org/series/26203/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/121145/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/121145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 417B7A0545;\n\tWed, 21 Dec 2022 03:52:28 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EAE08410D3;\n\tWed, 21 Dec 2022 03:52:27 +0100 (CET)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2072.outbound.protection.outlook.com [40.107.101.72])\n by mails.dpdk.org (Postfix) with ESMTP id E7105410D3\n for <dev@dpdk.org>; Wed, 21 Dec 2022 03:52:26 +0100 (CET)", "from DM5PR07CA0100.namprd07.prod.outlook.com (2603:10b6:4:ae::29) by\n CY8PR12MB7413.namprd12.prod.outlook.com (2603:10b6:930:5f::5) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5924.16; Wed, 21 Dec 2022 02:52:24 +0000", "from DM6NAM11FT081.eop-nam11.prod.protection.outlook.com\n (2603:10b6:4:ae:cafe::c6) by DM5PR07CA0100.outlook.office365.com\n (2603:10b6:4:ae::29) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.21 via Frontend\n Transport; Wed, 21 Dec 2022 02:52:23 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n DM6NAM11FT081.mail.protection.outlook.com (10.13.172.136) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5944.10 via Frontend Transport; Wed, 21 Dec 2022 02:52:23 +0000", "from cae-Bilby-RV1.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 20 Dec\n 2022 20:52:21 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=H5IQHot1ffN2UNqEkd7OPZ6i6CYoQZczkkciTrnAlDv2/WTmVi+MrkNBhdVhLBn7ZnozhfKVHT8d2IXh6dKegWMkQo//TOU7jRN6PCuFq2Ny5LF15iq/DJclirUV6hD0fLJohQ4/TiRglekucRHXqX7dRyW4a0p5EIL/imIZlpLqYOWjkAC+nxzDjFKP5UjyjuPdnFAEIqZVdoXh6VIdNbKHTnMhgl29X4F5ZNZkkaslTKNINTMD/F84j0cusu3Uqh8un0d3WFoqRUPyubf8kD/vsmmaKJ6lBQ67RGX4bUydACm5Fs4ZtkD1CVLIqUqpD8Ou7yW3JW3ssvx7ai+RJw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=OaAz0yMctBiM/lxjyt5m/7mVRTycVLyLUpUIEcjjdpI=;\n b=Fdym3ZqnmWE2GM5SMl3DmPm4Nt3qqZQ+NAKeSxpTLrLA1zrRJIeF0AXuol5du/9ackvZ5sWxGWyDN1dBnPpR+rDWS2Ja2uhdsuAN15vrWtGcM0ZDPm8ZNLCrwyNAQGm9Wz2CGFMqrKqncQ9C1VZksyQPmEN1ctTLSQGuh9Jws26Sij8dJHOEFdSImTzRKbFJFGxV2QplkApO+jfM9efqlqHFMn9Pi9sMC2mLm9eMtJi8YWqoh0VkqI8KoRR28mjZlN0vptth+UiQaY2vUS75py8kp1Oj1E/l/10k4NuXOOMVF2yxHn2Ly9GJG8LNukGncjbpnQRRB1Rlx8KYMiprZg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=OaAz0yMctBiM/lxjyt5m/7mVRTycVLyLUpUIEcjjdpI=;\n b=l6SxMYZHunIUqs+DzOJmA80yq6LN0jQbYBTImxcX/lpMZV/g0xzjDi9Hwv7cPxEiPU4Zj7cPUffWLke6GWMdn5lsMVXzkm5KR5qPAHaACYD7IqWMgckOED4bb6tiyWSU3ouedCaZg+todjL4j0Fl0/RV1oigSfobpAmgFwjbjuU=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Jesna K E <jesna.k.e@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Ferruh.Yigit@amd.com>, <Selwin.Sebastian@amd.com>, Jesna K E\n <jesna.k.e@amd.com>", "Subject": "[PATCH v1 2/2] net/axgbe: move offloads to Rx/Tx queue setup", "Date": "Wed, 21 Dec 2022 08:22:02 +0530", "Message-ID": "<20221221025202.31733-2-jesna.k.e@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221221025202.31733-1-jesna.k.e@amd.com>", "References": "<20221221025202.31733-1-jesna.k.e@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT081:EE_|CY8PR12MB7413:EE_", "X-MS-Office365-Filtering-Correlation-Id": "bfa6b7e1-9d6b-4301-dfa8-08dae2fe631c", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7riR9928/7BM7c35hwkZFdCGTvZazuShHFXK7rXzMo49mRM5I9lxy7oqFF0yQVcBDtsHvxuhkHBOzafkEN5GaFetLjv5OFHkEDSPtx/V9VX3P65s+jh8VqyRPDBeC12YsNltCwcvUNMNKWIh2InyNRUUZaihi4Pykyc4J81Ae3YBsdlI6FucXMb8Yz2J+crKK6nDKbjtnDiU8muisXWQv2QSgpfLoAL1Rp5LHnI49qw/DK+9fWB122gzOHcHZASEIW/ntvSiDoglsURrvauYWZACZ/lArXKcrfcY7gHWXgasZKD2yM9XtRq30R20nHaqIyP9mS40NuLbJWJQtQDYl6A7c4m/gQc5UhpmsBiaSU4jZWRN76W/rzSOr9hYhEGWEAAh8koFeLE9vVoUPy2OzVMi9n0I27IaFg3o0u7T+kWCu6QT963pG/mggR6V1k/C2Sg5EYTPmX+K746q4VZvkSAI3aKQaoSSxiChej7kPZptuZ0EtcGOMVea6h24x2PJ9C+exW5+qGF4PM6M+AK0PW3Sh/lFFXzSJxAFUDVkZ5cXw2I1xSZ6kPt4r/QsXLSsceVl5hBgm/xWPd7QLCS/jN4js/mmMAyT0RFxdM1ijIm5G0I/XlrQjyU/pXtm7s1AqlwPfjdta+Na8BMH9F5U2Xo0bAfPRF61wEqKRrNw7udTyxXEuEV1lo1C7+yb8+ypH03h+PPf4Sh+DQQ2EpqrE7TzfNz9loFo3pBVoOj5uoQ=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(6666004)(26005)(4326008)(186003)(36756003)(103116003)(5660300002)(70206006)(426003)(70586007)(8676002)(82310400005)(86362001)(7696005)(41300700001)(83380400001)(316002)(16526019)(36860700001)(54906003)(40460700003)(6916009)(478600001)(356005)(1076003)(82740400003)(2906002)(47076005)(40480700001)(81166007)(2616005)(8936002)(336012)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Dec 2022 02:52:23.7972 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n bfa6b7e1-9d6b-4301-dfa8-08dae2fe631c", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT081.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY8PR12MB7413", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For Multiprocess dpdk applications retrieving the offload parameter\nfor receive packet directly from struct eth_dev\ngiving segmentation fault since rxmode.offloads from eth_dev was\nnull duirng recv_pkts. So retrieved offload from rx/tx_queue_setup()\n\nSigned-off-by: Jesna K E <jesna.k.e@amd.com>\n---\n drivers/net/axgbe/axgbe_rxtx.c | 10 ++++------\n drivers/net/axgbe/axgbe_rxtx.h | 4 ++--\n 2 files changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_rxtx.c b/drivers/net/axgbe/axgbe_rxtx.c\nindex 9b283bd9d0..5dc4fe7369 100644\n--- a/drivers/net/axgbe/axgbe_rxtx.c\n+++ b/drivers/net/axgbe/axgbe_rxtx.c\n@@ -86,6 +86,7 @@ int axgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tif (rxq->free_thresh > rxq->nb_desc)\n \t\trxq->free_thresh = rxq->nb_desc >> 3;\n \n+\trxq->offloads = rx_conf->offloads | dev->data->dev_conf.rxmode.offloads;\n \t/* Allocate RX ring hardware descriptors */\n \tsize = rxq->nb_desc * sizeof(union axgbe_rx_desc);\n \tdma = rte_eth_dma_zone_reserve(dev, \"rx_ring\", queue_idx, size, 128,\n@@ -211,7 +212,6 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tunsigned int err, etlt;\n \tuint32_t error_status;\n \tuint16_t idx, pidx, pkt_len;\n-\tuint64_t offloads;\n \n \tidx = AXGBE_GET_DESC_IDX(rxq, rxq->cur);\n \twhile (nb_rx < nb_pkts) {\n@@ -278,14 +278,13 @@ axgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tmbuf->hash.rss = rte_le_to_cpu_32(desc->write.desc1);\n \t\tetlt = AXGMAC_GET_BITS_LE(desc->write.desc3,\n \t\t\t\tRX_NORMAL_DESC3, ETLT);\n-\t\toffloads = rxq->pdata->eth_dev->data->dev_conf.rxmode.offloads;\n \t\tif (!err || !etlt) {\n \t\t\tif (etlt == RX_CVLAN_TAG_PRESENT) {\n \t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_VLAN;\n \t\t\t\tmbuf->vlan_tci =\n \t\t\t\t\tAXGMAC_GET_BITS_LE(desc->write.desc0,\n \t\t\t\t\t\t\tRX_NORMAL_DESC0, OVT);\n-\t\t\t\tif (offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)\n+\t\t\t\tif (rxq->offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)\n \t\t\t\t\tmbuf->ol_flags |= RTE_MBUF_F_RX_VLAN_STRIPPED;\n \t\t\t\telse\n \t\t\t\t\tmbuf->ol_flags &= ~RTE_MBUF_F_RX_VLAN_STRIPPED;\n@@ -345,7 +344,6 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,\n \tunsigned int err = 0, etlt;\n \tuint32_t error_status = 0;\n \tuint16_t idx, pidx, data_len = 0, pkt_len = 0;\n-\tuint64_t offloads;\n \tbool eop = 0;\n \n \tidx = AXGBE_GET_DESC_IDX(rxq, rxq->cur);\n@@ -441,14 +439,13 @@ uint16_t eth_axgbe_recv_scattered_pkts(void *rx_queue,\n \t\t\t\trte_le_to_cpu_32(desc->write.desc1);\n \t\tetlt = AXGMAC_GET_BITS_LE(desc->write.desc3,\n \t\t\t\tRX_NORMAL_DESC3, ETLT);\n-\t\toffloads = rxq->pdata->eth_dev->data->dev_conf.rxmode.offloads;\n \t\tif (!err || !etlt) {\n \t\t\tif (etlt == RX_CVLAN_TAG_PRESENT) {\n \t\t\t\tfirst_seg->ol_flags |= RTE_MBUF_F_RX_VLAN;\n \t\t\t\tfirst_seg->vlan_tci =\n \t\t\t\t\tAXGMAC_GET_BITS_LE(desc->write.desc0,\n \t\t\t\t\t\t\tRX_NORMAL_DESC0, OVT);\n-\t\t\t\tif (offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)\n+\t\t\t\tif (rxq->offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)\n \t\t\t\t\tfirst_seg->ol_flags |=\n \t\t\t\t\t\tRTE_MBUF_F_RX_VLAN_STRIPPED;\n \t\t\t\telse\n@@ -606,6 +603,7 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \ttxq->desc = tz->addr;\n \ttxq->queue_id = queue_idx;\n \ttxq->port_id = dev->data->port_id;\n+\ttxq->offloads = offloads;\n \ttxq->dma_regs = (void *)((uint8_t *)pdata->xgmac_regs + DMA_CH_BASE +\n \t\t(DMA_CH_INC * txq->queue_id));\n \ttxq->dma_tail_reg = (volatile uint32_t *)((uint8_t *)txq->dma_regs +\ndiff --git a/drivers/net/axgbe/axgbe_rxtx.h b/drivers/net/axgbe/axgbe_rxtx.h\nindex d5660f5c4b..56e7c7aadd 100644\n--- a/drivers/net/axgbe/axgbe_rxtx.h\n+++ b/drivers/net/axgbe/axgbe_rxtx.h\n@@ -100,7 +100,7 @@ struct axgbe_rx_queue {\n \tuint64_t rx_mbuf_alloc_failed;\n \t/* Number of mbufs allocated from pool*/\n \tuint64_t mbuf_alloc;\n-\n+\tuint64_t offloads; /**< Rx offloads with RTE_ETH_RX_OFFLOAD_**/\n } __rte_cache_aligned;\n \n /*Tx descriptor format */\n@@ -149,7 +149,7 @@ struct axgbe_tx_queue {\n \tuint64_t pkts;\n \tuint64_t bytes;\n \tuint64_t errors;\n-\n+\tuint64_t offloads; /**< Tx offload flags of RTE_ETH_TX_OFFLOAD_* */\n } __rte_cache_aligned;\n \n /*Queue related APIs */\n", "prefixes": [ "v1", "2/2" ] }