Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/121091/?format=api
{ "id": 121091, "url": "http://patches.dpdk.org/api/patches/121091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221220143232.2519650-18-ktejasree@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221220143232.2519650-18-ktejasree@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221220143232.2519650-18-ktejasree@marvell.com", "date": "2022-12-20T14:32:32", "name": "[17/17] common/cnxk: remove salt from session", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "33e96913e811275fd94b40fc0b44a02d7b007846", "submitter": { "id": 1789, "url": "http://patches.dpdk.org/api/people/1789/?format=api", "name": "Tejasree Kondoj", "email": "ktejasree@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221220143232.2519650-18-ktejasree@marvell.com/mbox/", "series": [ { "id": 26195, "url": "http://patches.dpdk.org/api/series/26195/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=26195", "date": "2022-12-20T14:32:15", "name": "fixes and improvements to cnxk crytpo PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/26195/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/121091/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/121091/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7EA4A0545;\n\tTue, 20 Dec 2022 15:34:40 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AE90142D69;\n\tTue, 20 Dec 2022 15:33:27 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 9A2A042D10\n for <dev@dpdk.org>; Tue, 20 Dec 2022 15:33:25 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 2BKEOQ0v018991 for <dev@dpdk.org>; Tue, 20 Dec 2022 06:33:25 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3mhe5rnb5x-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 20 Dec 2022 06:33:24 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Tue, 20 Dec 2022 06:33:22 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Tue, 20 Dec 2022 06:33:22 -0800", "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 87C1C3F7070;\n Tue, 20 Dec 2022 06:33:20 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=8Lw8WQ2XJMBqwPqEp2AgDi4khP9BeF8K4dNibNQI9Rk=;\n b=N5fGYhW6aBoJbzgiyWrg2zq2bk69g7hqe9wZ4yEu2SPKT7dE5cT5gM3jiu97p9hzTKrw\n G8CLhvHB0PoteSe7QPvje0oYcfqZLR1RYDagAp4oXGDkX4WUzmAtuyz4kDAofG96sb+n\n 2SpytkJO2vqO9kPxj0i9/MVSoPLA6+nrfI9fmAnRm9TcVN7aTCN3Mw0Cj0/PtrKbINHT\n jYTIsbPpuVT9nxvmPixCj+sFqT/B5Mx0EOgfJAWKEqRzU1xNeT/77TVPSV4K7dgmL1Qn\n +TXDKC1kERnU0AxKTwUrUrBIuCpPm9ZSEUmfXjb7TGyfehZ4s6qHjWjbribo8d6y7CkQ Ow==", "From": "Tejasree Kondoj <ktejasree@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Vidya Sagar Velumuri\n <vvelumuri@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>, Volodymyr Fialko <vfialko@marvell.com>, \"Aakash\n Sasidharan\" <asasidharan@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 17/17] common/cnxk: remove salt from session", "Date": "Tue, 20 Dec 2022 20:02:32 +0530", "Message-ID": "<20221220143232.2519650-18-ktejasree@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221220143232.2519650-1-ktejasree@marvell.com>", "References": "<20221220143232.2519650-1-ktejasree@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "nM0wSn8c5EVtB4bV9IbsjgdBK8cSgTpe", "X-Proofpoint-ORIG-GUID": "nM0wSn8c5EVtB4bV9IbsjgdBK8cSgTpe", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2022-12-20_05,2022-12-20_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Anoob Joseph <anoobj@marvell.com>\n\nComplete 16B IV can be passed in DPTR to microcode. Passing salt in CPTR\ncannot be supported as the salt need to be given in different formats\nwhen CTX is enabled.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/common/cnxk/roc_se.c | 17 +++--------------\n drivers/common/cnxk/roc_se.h | 2 +-\n drivers/crypto/cnxk/cnxk_se.h | 6 +++---\n 3 files changed, 7 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_se.c b/drivers/common/cnxk/roc_se.c\nindex f335c2367f..6f0a81b22c 100644\n--- a/drivers/common/cnxk/roc_se.c\n+++ b/drivers/common/cnxk/roc_se.c\n@@ -497,8 +497,9 @@ roc_se_auth_key_set(struct roc_se_ctx *se_ctx, roc_se_auth_type type,\n }\n \n int\n-roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, roc_se_cipher_type type,\n-\t\t const uint8_t *key, uint16_t key_len, uint8_t *salt)\n+roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, roc_se_cipher_type type, const uint8_t *key,\n+\t\t uint16_t key_len)\n+\n {\n \tbool chained_op = se_ctx->ciph_then_auth || se_ctx->auth_then_ciph;\n \tstruct roc_se_zuc_snow3g_ctx *zs_ctx = &se_ctx->se_ctx.zs_ctx;\n@@ -520,18 +521,6 @@ roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, roc_se_cipher_type type,\n \t\tzuc_const = zs_ctx->zuc.otk_ctx.zuc_const;\n \t}\n \n-\t/* For AES-GCM, salt is taken from ctx even if IV source\n-\t * is from DPTR\n-\t */\n-\tif ((salt != NULL) && (type == ROC_SE_AES_GCM)) {\n-\t\tmemcpy(fctx->enc.encr_iv, salt, 4);\n-\t\t/* Assuming it was just salt update\n-\t\t * and nothing else\n-\t\t */\n-\t\tif (key == NULL)\n-\t\t\treturn 0;\n-\t}\n-\n \tif (type == ROC_SE_AES_GCM)\n \t\tse_ctx->template_w4.s.opcode_minor = BIT(5);\n \ndiff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h\nindex d1ef71577c..e9415f21a5 100644\n--- a/drivers/common/cnxk/roc_se.h\n+++ b/drivers/common/cnxk/roc_se.h\n@@ -370,7 +370,7 @@ int __roc_api roc_se_auth_key_set(struct roc_se_ctx *se_ctx, roc_se_auth_type ty\n \t\t\t\t const uint8_t *key, uint16_t key_len, uint16_t mac_len);\n \n int __roc_api roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, roc_se_cipher_type type,\n-\t\t\t\t const uint8_t *key, uint16_t key_len, uint8_t *salt);\n+\t\t\t\t const uint8_t *key, uint16_t key_len);\n \n void __roc_api roc_se_ctx_swap(struct roc_se_ctx *se_ctx);\n void __roc_api roc_se_ctx_init(struct roc_se_ctx *se_ctx);\ndiff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h\nindex 1827b0d7b3..0e5d2dde39 100644\n--- a/drivers/crypto/cnxk/cnxk_se.h\n+++ b/drivers/crypto/cnxk/cnxk_se.h\n@@ -1708,7 +1708,7 @@ fill_sess_aead(struct rte_crypto_sym_xform *xform, struct cnxk_se_sess *sess)\n \t}\n \n \tif (unlikely(roc_se_ciph_key_set(&sess->roc_se_ctx, enc_type, aead_form->key.data,\n-\t\t\t\t\t aead_form->key.length, NULL)))\n+\t\t\t\t\t aead_form->key.length)))\n \t\treturn -1;\n \n \tif (unlikely(roc_se_auth_key_set(&sess->roc_se_ctx, auth_type, NULL, 0,\n@@ -1866,7 +1866,7 @@ fill_sess_cipher(struct rte_crypto_sym_xform *xform, struct cnxk_se_sess *sess)\n \t\t}\n \n \tif (unlikely(roc_se_ciph_key_set(&sess->roc_se_ctx, enc_type, c_form->key.data,\n-\t\t\t\t\t c_form->key.length, NULL)))\n+\t\t\t\t\t c_form->key.length)))\n \t\treturn -1;\n \n \tif ((enc_type >= ROC_SE_ZUC_EEA3) && (enc_type <= ROC_SE_AES_CTR_EEA2))\n@@ -2072,7 +2072,7 @@ fill_sess_gmac(struct rte_crypto_sym_xform *xform, struct cnxk_se_sess *sess)\n \t}\n \n \tif (unlikely(roc_se_ciph_key_set(&sess->roc_se_ctx, enc_type, a_form->key.data,\n-\t\t\t\t\t a_form->key.length, NULL)))\n+\t\t\t\t\t a_form->key.length)))\n \t\treturn -1;\n \n \tif (unlikely(roc_se_auth_key_set(&sess->roc_se_ctx, auth_type, NULL, 0,\n", "prefixes": [ "17/17" ] }