Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/120021/?format=api
{ "id": 120021, "url": "http://patches.dpdk.org/api/patches/120021/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221121223208.1147154-8-okaya@kernel.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221121223208.1147154-8-okaya@kernel.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221121223208.1147154-8-okaya@kernel.org", "date": "2022-11-21T22:32:06", "name": "[v2,07/11] malloc: check result of rte_fbarray_get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f00c94827b810f34ccefd2b1700716334d95dace", "submitter": { "id": 2903, "url": "http://patches.dpdk.org/api/people/2903/?format=api", "name": "Sinan Kaya", "email": "okaya@kernel.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221121223208.1147154-8-okaya@kernel.org/mbox/", "series": [ { "id": 25843, "url": "http://patches.dpdk.org/api/series/25843/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25843", "date": "2022-11-21T22:31:59", "name": "codeql fixes for various subsystems", "version": 2, "mbox": "http://patches.dpdk.org/series/25843/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/120021/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/120021/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62D16A056D;\n\tMon, 21 Nov 2022 23:32:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A94D442D67;\n\tMon, 21 Nov 2022 23:32:23 +0100 (CET)", "from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])\n by mails.dpdk.org (Postfix) with ESMTP id 625FC42D4E\n for <dev@dpdk.org>; Mon, 21 Nov 2022 23:32:20 +0100 (CET)", "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by dfw.source.kernel.org (Postfix) with ESMTPS id D2CD6614BA\n for <dev@dpdk.org>; Mon, 21 Nov 2022 22:32:19 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 2C960C433C1;\n Mon, 21 Nov 2022 22:32:19 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1669069939;\n bh=b9XPdlFmqr0VZaZ/G6xeC3g+pdTGxgCDoDwiCqKPQLg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=NBhnhaLDXVgeYa+02fimQblcQLE0sfnJ0ENjVVFeMq4D470pO44Du8cjT7BzoOsRu\n vaEURWMFk9f/UTJ4Hf3cTV5VSocSeUp4k+9WDVZ8a3CvfbPvafQ8xT4b0+064CGAbK\n CTb1/x9taYSre8Cs5O40D6kXR1+h493x2A8TfXlHXJatmx/TLHnEltLd4V5howcp5f\n EAHxexQxnnwGfIjVoEVMiu/Us4Y9wQuJuf0kIY9xR/x0Qc7/Um3jy5RgbODK0jIsZS\n sojaeDXf3zGLdW7JmefYcakU3qdOxKH0JFO9y4RRWTrhFnHFZkmHuFiGtmGrXaB3wi\n wIBvNT1DRdW5A==", "From": "okaya@kernel.org", "To": "dev@dpdk.org", "Cc": "Sinan Kaya <okaya@kernel.org>", "Subject": "[PATCH v2 07/11] malloc: check result of rte_fbarray_get", "Date": "Mon, 21 Nov 2022 17:32:06 -0500", "Message-Id": "<20221121223208.1147154-8-okaya@kernel.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221121223208.1147154-1-okaya@kernel.org>", "References": "<20221121223208.1147154-1-okaya@kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sinan Kaya <okaya@kernel.org>\n\nIn eal_memalloc_is_contig result of call to rte_fbarray_get\nis dereferenced here and may be null.\n\nSigned-off-by: Sinan Kaya <okaya@kernel.org>\n---\n lib/eal/common/eal_common_memalloc.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/common/eal_common_memalloc.c b/lib/eal/common/eal_common_memalloc.c\nindex ab04479c1c..24506f8447 100644\n--- a/lib/eal/common/eal_common_memalloc.c\n+++ b/lib/eal/common/eal_common_memalloc.c\n@@ -126,6 +126,9 @@ eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,\n \n \t\t/* skip first iteration */\n \t\tms = rte_fbarray_get(&msl->memseg_arr, start_seg);\n+\t\tif (ms == NULL)\n+\t\t\treturn false;\n+\n \t\tcur = ms->iova;\n \t\texpected = cur + pgsz;\n \n@@ -137,7 +140,7 @@ eal_memalloc_is_contig(const struct rte_memseg_list *msl, void *start,\n \t\t\t\tcur_seg++, expected += pgsz) {\n \t\t\tms = rte_fbarray_get(&msl->memseg_arr, cur_seg);\n \n-\t\t\tif (ms->iova != expected)\n+\t\t\tif ((ms != NULL) && (ms->iova != expected))\n \t\t\t\treturn false;\n \t\t}\n \t}\n", "prefixes": [ "v2", "07/11" ] }