Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 120005,
    "url": "http://patches.dpdk.org/api/patches/120005/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221121204015.1135573-2-okaya@kernel.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20221121204015.1135573-2-okaya@kernel.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20221121204015.1135573-2-okaya@kernel.org",
    "date": "2022-11-21T20:40:07",
    "name": "[01/11] ethdev: check return result of rte_eth_dev_info_get",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "77b60fa63ce93b70486261623d3d8da8d030123c",
    "submitter": {
        "id": 2903,
        "url": "http://patches.dpdk.org/api/people/2903/?format=api",
        "name": "Sinan Kaya",
        "email": "okaya@kernel.org"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221121204015.1135573-2-okaya@kernel.org/mbox/",
    "series": [
        {
            "id": 25842,
            "url": "http://patches.dpdk.org/api/series/25842/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25842",
            "date": "2022-11-21T20:40:06",
            "name": "codeql fixes for various subsystems",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/25842/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/120005/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/120005/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CEC9EA056B;\n\tMon, 21 Nov 2022 21:40:36 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4441842D34;\n\tMon, 21 Nov 2022 21:40:34 +0100 (CET)",
            "from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])\n by mails.dpdk.org (Postfix) with ESMTP id 14EE442D2F\n for <dev@dpdk.org>; Mon, 21 Nov 2022 21:40:33 +0100 (CET)",
            "from smtp.kernel.org (relay.kernel.org [52.25.139.140])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by ams.source.kernel.org (Postfix) with ESMTPS id A8CCFB815DE\n for <dev@dpdk.org>; Mon, 21 Nov 2022 20:40:32 +0000 (UTC)",
            "by smtp.kernel.org (Postfix) with ESMTPSA id B40EFC433D7;\n Mon, 21 Nov 2022 20:40:30 +0000 (UTC)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1669063231;\n bh=RgYWMx2bXw0Kf6OSgrUuQ2FaHKOsqLyY7fKYUDdVLR4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Q4JHcw4egEEf/kwJQerUjEG0FZupMjsSfXoMXhFkRydBdIVYrzfkxLrn0v2oNBFQ0\n tSYSu/e+4qzAcGm1ZUQgHYqYDVj/1fNfsv2bc+YdIS+Qyr3zIBW+GlNlzcA9ug4D8a\n rRxRom/Wa4AdvwhhyNj5oqipXBCOwX6P+rd/Z09y8wVtlpm79FFB+IFvwDtjF6PEAc\n Jy1f8qhEHTt5S0F1+0VAowvfS4MQlECMcFKHiFN412NGcu+p8s1VCDRKk/R70TSotT\n GwFxnyfqIr/11hQCj+lrBo104mBVHYJav8Yf7Ohq5m14uf8j0hFMd59kG6iRSbZyr5\n AtZ69DPxEtQaQ==",
        "From": "okaya@kernel.org",
        "To": "dev@dpdk.org",
        "Cc": "Sinan Kaya <okaya@kernel.org>",
        "Subject": "[PATCH 01/11] ethdev: check return result of rte_eth_dev_info_get",
        "Date": "Mon, 21 Nov 2022 15:40:07 -0500",
        "Message-Id": "<20221121204015.1135573-2-okaya@kernel.org>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20221121204015.1135573-1-okaya@kernel.org>",
        "References": "<20221121204015.1135573-1-okaya@kernel.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Sinan Kaya <okaya@kernel.org>\n\nrte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get\nis not checked, potentially leaving dev_info uninitialized.\n\nSigned-off-by: Sinan Kaya <okaya@kernel.org>\n---\n lib/ethdev/rte_class_eth.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c\nindex 838b3a8f9f..8165e5adc0 100644\n--- a/lib/ethdev/rte_class_eth.c\n+++ b/lib/ethdev/rte_class_eth.c\n@@ -51,7 +51,9 @@ eth_mac_cmp(const char *key __rte_unused,\n \t\treturn -1; /* invalid devargs value */\n \n \t/* Return 0 if devargs MAC is matching one of the device MACs. */\n-\trte_eth_dev_info_get(data->port_id, &dev_info);\n+\tif (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)\n+\t\treturn -1;\n+\n \tfor (index = 0; index < dev_info.max_mac_addrs; index++)\n \t\tif (rte_is_same_ether_addr(&mac, &data->mac_addrs[index]))\n \t\t\treturn 0;\n",
    "prefixes": [
        "01/11"
    ]
}