Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119926/?format=api
{ "id": 119926, "url": "http://patches.dpdk.org/api/patches/119926/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221117072558.3582292-3-asekhar@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221117072558.3582292-3-asekhar@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221117072558.3582292-3-asekhar@marvell.com", "date": "2022-11-17T07:25:58", "name": "[v1,3/3] net/cnxk: add debug check for number of Tx descriptors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ea9f2a7952bb5caeea01e4c9cf337f8d6cf985a8", "submitter": { "id": 2125, "url": "http://patches.dpdk.org/api/people/2125/?format=api", "name": "Ashwin Sekhar T K", "email": "asekhar@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221117072558.3582292-3-asekhar@marvell.com/mbox/", "series": [ { "id": 25794, "url": "http://patches.dpdk.org/api/series/25794/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25794", "date": "2022-11-17T07:25:56", "name": "[v1,1/3] net/cnxk: rework no-fast-free offload handling", "version": 1, "mbox": "http://patches.dpdk.org/series/25794/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119926/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119926/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 90C06A00C2;\n\tThu, 17 Nov 2022 08:26:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1ABB342C4D;\n\tThu, 17 Nov 2022 08:26:19 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id E6E2B42C4D\n for <dev@dpdk.org>; Thu, 17 Nov 2022 08:26:17 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 2AH6pdSU026293 for <dev@dpdk.org>; Wed, 16 Nov 2022 23:26:17 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kwg2b030j-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 16 Nov 2022 23:26:17 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Wed, 16 Nov 2022 23:26:14 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Wed, 16 Nov 2022 23:26:14 -0800", "from localhost.localdomain (unknown [10.28.36.142])\n by maili.marvell.com (Postfix) with ESMTP id 65C8A5B6927;\n Wed, 16 Nov 2022 23:26:11 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=LekQVluYp7u/TPZb2lvzsOdtSoI7Bs9DJFE6rJAcycI=;\n b=VxCCDR8JUhRPb0i8HYMnNbfGlQSfxwejzByttLsgl3IeOi5UiUHel+cKJDamKUtAKEBQ\n lW7uLnYjUsAycB+59BRJCrxO/nSok1LYipouErHK2/ep5NhJb3ngJx0iDjQQRSkAYgPE\n QpUYGiNGgYCFn5XMlbqnqwguoHf+aMc5iK80Y3CxomfuHzUzs6a9d1R2dF6gq+cvpHv3\n k0f+rdvdmtVsneb8pf7HHxq2DCCcKyhc+Vu/l/pP3MJM8zxehZIy2eutGYPU7Ekumr0T\n UnZwah+gw8KXQbYq/maSl8zbzv8IHIVqAXJFVfAIYt5PQVR3h7DIgOCmSoOcaDTBigUs /A==", "From": "Ashwin Sekhar T K <asekhar@marvell.com>", "To": "<dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <pbhagavatula@marvell.com>, <psatheesh@marvell.com>,\n <asekhar@marvell.com>, <anoobj@marvell.com>, <gakhil@marvell.com>,\n <hkalra@marvell.com>", "Subject": "[PATCH v1 3/3] net/cnxk: add debug check for number of Tx descriptors", "Date": "Thu, 17 Nov 2022 12:55:58 +0530", "Message-ID": "<20221117072558.3582292-3-asekhar@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221117072558.3582292-1-asekhar@marvell.com>", "References": "<20221117072558.3582292-1-asekhar@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "diWbYHk0xcoF_zaWHs0UnDn2Hl5gfRJB", "X-Proofpoint-ORIG-GUID": "diWbYHk0xcoF_zaWHs0UnDn2Hl5gfRJB", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2022-11-17_04,2022-11-16_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When SG2 descriptors are used and more than 5 segments\nare present, in certain combination of segments the\nnumber of descriptors required will be greater than\n16.\n\nIn debug builds, add an assert to capture this scenario.\n\nSigned-off-by: Ashwin Sekhar T K <asekhar@marvell.com>\n---\n drivers/net/cnxk/cn10k_tx.h | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)", "diff": "diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h\nindex 3f08a8a473..09c332b2b5 100644\n--- a/drivers/net/cnxk/cn10k_tx.h\n+++ b/drivers/net/cnxk/cn10k_tx.h\n@@ -84,6 +84,22 @@ cn10k_nix_mbuf_sg_dwords(struct rte_mbuf *m)\n \treturn (segw + 1) / 2;\n }\n \n+static __plt_always_inline void\n+cn10k_nix_tx_mbuf_validate(struct rte_mbuf *m, const uint32_t flags)\n+{\n+#ifdef RTE_LIBRTE_MBUF_DEBUG\n+\tuint16_t segdw;\n+\n+\tsegdw = cn10k_nix_mbuf_sg_dwords(m);\n+\tsegdw += 1 + !!(flags & NIX_TX_NEED_EXT_HDR) + !!(flags & NIX_TX_OFFLOAD_TSTAMP_F);\n+\n+\tPLT_ASSERT(segdw <= 8);\n+#else\n+\tRTE_SET_USED(m);\n+\tRTE_SET_USED(flags);\n+#endif\n+}\n+\n static __plt_always_inline void\n cn10k_nix_vwqe_wait_fc(struct cn10k_eth_txq *txq, int64_t req)\n {\n@@ -1307,6 +1323,8 @@ cn10k_nix_xmit_pkts_mseg(void *tx_queue, uint64_t *ws,\n \t}\n \n \tfor (i = 0; i < burst; i++) {\n+\t\tcn10k_nix_tx_mbuf_validate(tx_pkts[i], flags);\n+\n \t\t/* Perform header writes for TSO, barrier at\n \t\t * lmt steorl will suffice.\n \t\t */\n@@ -1906,6 +1924,8 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws,\n \t\t\tfor (j = 0; j < NIX_DESCS_PER_LOOP; j++) {\n \t\t\t\tstruct rte_mbuf *m = tx_pkts[j];\n \n+\t\t\t\tcn10k_nix_tx_mbuf_validate(m, flags);\n+\n \t\t\t\t/* Get dwords based on nb_segs. */\n \t\t\t\tif (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F &&\n \t\t\t\t flags & NIX_TX_MULTI_SEG_F))\n", "prefixes": [ "v1", "3/3" ] }