Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1198,
    "url": "http://patches.dpdk.org/api/patches/1198/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1415362978-6306-3-git-send-email-declan.doherty@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1415362978-6306-3-git-send-email-declan.doherty@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1415362978-6306-3-git-send-email-declan.doherty@intel.com",
    "date": "2014-11-07T12:22:52",
    "name": "[dpdk-dev,v6,2/8] bond: removing switch statement from rx burst method",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "32546eca5aead0fb485ee3573249607c18fcfe3f",
    "submitter": {
        "id": 11,
        "url": "http://patches.dpdk.org/api/people/11/?format=api",
        "name": "Doherty, Declan",
        "email": "declan.doherty@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1415362978-6306-3-git-send-email-declan.doherty@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/1198/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/1198/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D660C7F2D;\n\tFri,  7 Nov 2014 13:13:37 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id BAADF7F2D\n\tfor <dev@dpdk.org>; Fri,  7 Nov 2014 13:13:35 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 07 Nov 2014 04:20:58 -0800",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Nov 2014 04:23:05 -0800",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tsA7CN4ON002831; Fri, 7 Nov 2014 12:23:04 GMT",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id sA7CN4aF007557;\n\tFri, 7 Nov 2014 12:23:04 GMT",
            "(from dwdohert@localhost)\n\tby sivswdev02.ir.intel.com with  id sA7CN49w007553;\n\tFri, 7 Nov 2014 12:23:04 GMT"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.07,332,1413270000\"; d=\"scan'208\";a=\"604086257\"",
        "From": "Declan Doherty <declan.doherty@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri,  7 Nov 2014 12:22:52 +0000",
        "Message-Id": "<1415362978-6306-3-git-send-email-declan.doherty@intel.com>",
        "X-Mailer": "git-send-email 1.7.12.2",
        "In-Reply-To": "<1415362978-6306-1-git-send-email-declan.doherty@intel.com>",
        "References": "<1413291597-27326-1-git-send-email-declan.doherty@intel.com>\n\t<1415362978-6306-1-git-send-email-declan.doherty@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v6 2/8] bond: removing switch statement from rx\n\tburst method",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Declan Doherty <declan.doherty@intel.com>\n---\n lib/librte_pmd_bond/rte_eth_bond_pmd.c | 65 +++++++++++++++++++---------------\n 1 file changed, 36 insertions(+), 29 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c\nindex de0cd56..f2fe930 100644\n--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c\n@@ -59,35 +59,38 @@ bond_ethdev_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \n \tinternals = bd_rx_q->dev_private;\n \n-\tswitch (internals->mode) {\n-\tcase BONDING_MODE_ROUND_ROBIN:\n-#ifdef RTE_MBUF_REFCNT\n-\tcase BONDING_MODE_BROADCAST:\n-#endif\n-\tcase BONDING_MODE_BALANCE:\n-\t\tfor (i = 0; i < internals->active_slave_count && nb_pkts; i++) {\n-\t\t\t/* Offset of pointer to *bufs increases as packets are received\n-\t\t\t * from other slaves */\n-\t\t\tnum_rx_slave = rte_eth_rx_burst(internals->active_slaves[i],\n-\t\t\t\t\tbd_rx_q->queue_id, bufs + num_rx_total, nb_pkts);\n-\t\t\tif (num_rx_slave) {\n-\t\t\t\tnum_rx_total += num_rx_slave;\n-\t\t\t\tnb_pkts -= num_rx_slave;\n-\t\t\t}\n+\n+\tfor (i = 0; i < internals->active_slave_count && nb_pkts; i++) {\n+\t\t/* Offset of pointer to *bufs increases as packets are received\n+\t\t * from other slaves */\n+\t\tnum_rx_slave = rte_eth_rx_burst(internals->active_slaves[i],\n+\t\t\t\tbd_rx_q->queue_id, bufs + num_rx_total, nb_pkts);\n+\t\tif (num_rx_slave) {\n+\t\t\tnum_rx_total += num_rx_slave;\n+\t\t\tnb_pkts -= num_rx_slave;\n \t\t}\n-\t\tbreak;\n-\tcase BONDING_MODE_ACTIVE_BACKUP:\n-\t\tnum_rx_slave = rte_eth_rx_burst(internals->current_primary_port,\n-\t\t\t\tbd_rx_q->queue_id, bufs, nb_pkts);\n-\t\tif (num_rx_slave)\n-\t\t\tnum_rx_total = num_rx_slave;\n-\t\tbreak;\n \t}\n+\n \treturn num_rx_total;\n }\n \n static uint16_t\n-bond_ethdev_tx_round_robin(void *queue, struct rte_mbuf **bufs,\n+bond_ethdev_rx_burst_active_backup(void *queue, struct rte_mbuf **bufs,\n+\t\tuint16_t nb_pkts)\n+{\n+\tstruct bond_dev_private *internals;\n+\n+\t/* Cast to structure, containing bonded device's port id and queue id */\n+\tstruct bond_rx_queue *bd_rx_q = (struct bond_rx_queue *)queue;\n+\n+\tinternals = bd_rx_q->dev_private;\n+\n+\treturn rte_eth_rx_burst(internals->current_primary_port,\n+\t\t\tbd_rx_q->queue_id, bufs, nb_pkts);\n+}\n+\n+static uint16_t\n+bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs,\n \t\tuint16_t nb_pkts)\n {\n \tstruct bond_dev_private *dev_private;\n@@ -136,7 +139,7 @@ bond_ethdev_tx_round_robin(void *queue, struct rte_mbuf **bufs,\n }\n \n static uint16_t\n-bond_ethdev_tx_active_backup(void *queue,\n+bond_ethdev_tx_burst_active_backup(void *queue,\n \t\tstruct rte_mbuf **bufs, uint16_t nb_pkts)\n {\n \tstruct bond_dev_private *internals;\n@@ -272,7 +275,8 @@ xmit_slave_hash(const struct rte_mbuf *buf, uint8_t slave_count, uint8_t policy)\n }\n \n static uint16_t\n-bond_ethdev_tx_balance(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n+bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs,\n+\t\tuint16_t nb_pkts)\n {\n \tstruct bond_dev_private *internals;\n \tstruct bond_tx_queue *bd_tx_q;\n@@ -486,24 +490,27 @@ bond_ethdev_mode_set(struct rte_eth_dev *eth_dev, int mode)\n \n \tswitch (mode) {\n \tcase BONDING_MODE_ROUND_ROBIN:\n-\t\teth_dev->tx_pkt_burst = bond_ethdev_tx_round_robin;\n+\t\teth_dev->tx_pkt_burst = bond_ethdev_tx_burst_round_robin;\n+\t\teth_dev->rx_pkt_burst = bond_ethdev_rx_burst;\n \t\tbreak;\n \tcase BONDING_MODE_ACTIVE_BACKUP:\n-\t\teth_dev->tx_pkt_burst = bond_ethdev_tx_active_backup;\n+\t\teth_dev->tx_pkt_burst = bond_ethdev_tx_burst_active_backup;\n+\t\teth_dev->rx_pkt_burst = bond_ethdev_rx_burst_active_backup;\n \t\tbreak;\n \tcase BONDING_MODE_BALANCE:\n-\t\teth_dev->tx_pkt_burst = bond_ethdev_tx_balance;\n+\t\teth_dev->tx_pkt_burst = bond_ethdev_tx_burst_balance;\n+\t\teth_dev->rx_pkt_burst = bond_ethdev_rx_burst;\n \t\tbreak;\n #ifdef RTE_MBUF_REFCNT\n \tcase BONDING_MODE_BROADCAST:\n \t\teth_dev->tx_pkt_burst = bond_ethdev_tx_burst_broadcast;\n+\t\teth_dev->rx_pkt_burst = bond_ethdev_rx_burst;\n \t\tbreak;\n #endif\n \tdefault:\n \t\treturn -1;\n \t}\n \n-\teth_dev->rx_pkt_burst = bond_ethdev_rx_burst;\n \tinternals->mode = mode;\n \n \treturn 0;\n",
    "prefixes": [
        "dpdk-dev",
        "v6",
        "2/8"
    ]
}