Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119688/?format=api
{ "id": 119688, "url": "http://patches.dpdk.org/api/patches/119688/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109234649.331942-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109234649.331942-5-stephen@networkplumber.org", "date": "2022-11-09T23:46:49", "name": "[4/4] examples: remove unnecessary null checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6036e0479a9008bc0ce7ae59476faf3add73c6ef", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 25680, "url": "http://patches.dpdk.org/api/series/25680/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25680", "date": "2022-11-09T23:46:45", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/25680/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119688/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7E2FA0093;\n\tThu, 10 Nov 2022 00:47:12 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 21FFF42D15;\n\tThu, 10 Nov 2022 00:47:01 +0100 (CET)", "from mail-pg1-f182.google.com (mail-pg1-f182.google.com\n [209.85.215.182])\n by mails.dpdk.org (Postfix) with ESMTP id D51A14114A\n for <dev@dpdk.org>; Thu, 10 Nov 2022 00:46:58 +0100 (CET)", "by mail-pg1-f182.google.com with SMTP id h193so97749pgc.10\n for <dev@dpdk.org>; Wed, 09 Nov 2022 15:46:58 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Nov 2022 15:46:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=nmrm3b9OhvEkvfnTnYQjrjZdM1u7QDkj4LQSw7hPXdc=;\n b=59W/cEEqMZQISAFdeh6T2rYAoS7JliGloL+ZzIPYGi1QiKYugjWurl4vDPmovY/VZ0\n XmBOjjBhYvrCnUbtU8r5DS10bzq/1GXLGgs7rnD/HV5hpSIgnFUqZve3ObO4KTsN0p2j\n K7DeKaWdElNvv/psMnucCMRrA6PxtzGvHBChbHA6VpYdnbvIQr25iBnRSMTqJJvIuzB8\n sqQpWS6RyY+2fwExPYqftKtYZJqQVekvpiy5NHDMxR/io3s+cqv08vx4foJStXp/ijox\n ubsueNY4fEFZC60YwArsosycxZaB5BpeEdWwzhylc+oEVDnl7VwFjjKeb0LwmxIyXksq\n UnIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=nmrm3b9OhvEkvfnTnYQjrjZdM1u7QDkj4LQSw7hPXdc=;\n b=wZJL5GByxb7upOg0x/yHgC/doAW69IFS35bQ6RnaMduI19VuX0ZrFuucHce6gwtTzF\n fUKuohtAAprn3pG/Tx7TwiFhyh7oIfoUUa3kmDJPvc/L8InIEVbu9ilWo9sdkvRnVGFs\n N3RhkvZaz/ANGLjAEZ0JwYDbofkaJaLBeZELbielKnK2+xHyrCAEZedfsANUL1MlktN5\n 54QubXglChm6eLwYVSK0D7rAW5AeEmW+zHXRs02oREB/5wKIQSQI8eX/aguAj7k2px6L\n oRvBGKOy85o+lodumfS2ekZuMIOpm2EN37EUbflPGwVH40b1Bhk+pB7lAJaJ1Ohqx+ka\n 4C+g==", "X-Gm-Message-State": "ACrzQf2Hy6jSoh3JWiiWCjiSpQtPk/IE7jlNTIVH1kPRDNVROIRptrtN\n veBk4dKg033Wl8RiN1TokomR5qjazfIUeA==", "X-Google-Smtp-Source": "\n AMsMyM5DBBQCPaqjHvpMhIPCrrmLaQiR0sBJ/3r9NQW83QebeTqehdp3fAoYT0LkLyVnpEay7STwBg==", "X-Received": "by 2002:a05:6a00:848:b0:56e:4e85:33fc with SMTP id\n q8-20020a056a00084800b0056e4e8533fcmr35049081pfk.40.1668037617729;\n Wed, 09 Nov 2022 15:46:57 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n David Hunt <david.hunt@intel.com>, Brian Dooley <brian.dooley@intel.com>", "Subject": "[PATCH 4/4] examples: remove unnecessary null checks", "Date": "Wed, 9 Nov 2022 15:46:49 -0800", "Message-Id": "<20221109234649.331942-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221109234649.331942-1-stephen@networkplumber.org>", "References": "<20221109234649.331942-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function rte_free() already handles NULL argument;\ntherefore the checks in this code are unnecessary.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n examples/distributor/main.c | 3 +--\n examples/fips_validation/main.c | 15 +++++----------\n 2 files changed, 6 insertions(+), 12 deletions(-)", "diff": "diff --git a/examples/distributor/main.c b/examples/distributor/main.c\nindex e767973ed8de..21304d661873 100644\n--- a/examples/distributor/main.c\n+++ b/examples/distributor/main.c\n@@ -1017,8 +1017,7 @@ main(int argc, char *argv[])\n \n \tprint_stats();\n \n-\tif (pd)\n-\t\trte_free(pd);\n+\trte_free(pd);\n \trte_free(pr);\n \n \t/* clean up the EAL */\ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex 40a5b70e073b..73caaffb7e7a 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -962,8 +962,7 @@ prepare_rsa_op(void)\n \t\tasym->rsa.message.data = msg.val;\n \t\tasym->rsa.message.length = msg.len;\n \n-\t\tif (vec.rsa.signature.val)\n-\t\t\trte_free(vec.rsa.signature.val);\n+\t\trte_free(vec.rsa.signature.val);\n \n \t\tvec.rsa.signature.val = rte_zmalloc(NULL, vec.rsa.n.len, 0);\n \t\tvec.rsa.signature.len = vec.rsa.n.len;\n@@ -1011,11 +1010,9 @@ prepare_ecdsa_op(void)\n \t\tasym->ecdsa.k.data = vec.ecdsa.k.val;\n \t\tasym->ecdsa.k.length = vec.ecdsa.k.len;\n \n-\t\tif (vec.ecdsa.r.val)\n-\t\t\trte_free(vec.ecdsa.r.val);\n+\t\trte_free(vec.ecdsa.r.val);\n \n-\t\tif (vec.ecdsa.s.val)\n-\t\t\trte_free(vec.ecdsa.s.val);\n+\t\trte_free(vec.ecdsa.s.val);\n \n \t\tvec.ecdsa.r.len = info.interim_info.ecdsa_data.curve_len;\n \t\tvec.ecdsa.r.val = rte_zmalloc(NULL, vec.ecdsa.r.len, 0);\n@@ -1060,11 +1057,9 @@ prepare_ecfpm_op(void)\n \tasym->ecpm.scalar.data = vec.ecdsa.pkey.val;\n \tasym->ecpm.scalar.length = vec.ecdsa.pkey.len;\n \n-\tif (vec.ecdsa.qx.val)\n-\t\trte_free(vec.ecdsa.qx.val);\n+\trte_free(vec.ecdsa.qx.val);\n \n-\tif (vec.ecdsa.qy.val)\n-\t\trte_free(vec.ecdsa.qy.val);\n+\trte_free(vec.ecdsa.qy.val);\n \n \tvec.ecdsa.qx.len = info.interim_info.ecdsa_data.curve_len;\n \tvec.ecdsa.qx.val = rte_zmalloc(NULL, vec.ecdsa.qx.len, 0);\n", "prefixes": [ "4/4" ] }