Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119687/?format=api
{ "id": 119687, "url": "http://patches.dpdk.org/api/patches/119687/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109234649.331942-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109234649.331942-4-stephen@networkplumber.org", "date": "2022-11-09T23:46:48", "name": "[3/4] idpf: remvoee unnecessary null checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "958ced4f3b501aea56efbe9526b86b2746598283", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 25680, "url": "http://patches.dpdk.org/api/series/25680/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25680", "date": "2022-11-09T23:46:45", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/25680/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119687/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119687/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 62392A0093;\n\tThu, 10 Nov 2022 00:47:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 40D6942D0C;\n\tThu, 10 Nov 2022 00:46:59 +0100 (CET)", "from mail-pj1-f48.google.com (mail-pj1-f48.google.com\n [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id 9D857400D4\n for <dev@dpdk.org>; Thu, 10 Nov 2022 00:46:57 +0100 (CET)", "by mail-pj1-f48.google.com with SMTP id\n l22-20020a17090a3f1600b00212fbbcfb78so3330055pjc.3\n for <dev@dpdk.org>; Wed, 09 Nov 2022 15:46:57 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Nov 2022 15:46:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/sluQM/YR/JUUSXg8kIj5TtFEM3ub/Ak2m/Sv78jozs=;\n b=wjqj8iDiNgQ2mug5zI+9Ii1Jvo1wubU+2igAvGOokwniCP1a7FXAGcKBOkDQm5E7tJ\n t6YQZAf6XvfQbyUgCD2m1zsD6LfC8fUsFDXkFJx6tpcy2fidc6iMC290VRlrlbOnaUus\n YQy3gfIySDHhGI0xpnRQvdzTrH4DpAfychTB/gx1z8np7WQam5jUIMpVrvZMFiZ59K9/\n OGSDFqoa+x2oCEa3vXZFIxY5g7HeMZovFbkbhuWvs7eZ3sxSuzAWM7P+onahb2QFuUYh\n USxdmHl1ogTNDLOb2u2HRrUIxqXnEhr40SRUg/neEE/wOunAMPbFYmTg3sZnL3rcU4Py\n /Fcw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=/sluQM/YR/JUUSXg8kIj5TtFEM3ub/Ak2m/Sv78jozs=;\n b=ecw44+5/gmAPyeVupvI8W0Cp4WPBlAsLx0o0VA2YiKv3wroWlZzk3jX9O7oTkHwvhK\n nFBQv2SZMBKeLVPK4p9n66jYkfN8qu47JpRedoPiL2Rm5IMSeMi5EvWQxBtD5uTDAENm\n dh4YLPcH0FDpqSKxByEs2wn1wYwwdAFnbOuJbt20cSjqAd0PVzd8pRFmby2tPTpGAel9\n ezdvIH4e2k1Z5YQeO/AO183Ck7A7eeJ8G0QnUdhC2kYzXCy8qjnsyLqgHAGyDDac+oo8\n viaoj3V1XK6xuK4ABnvcUki4tDFNONw7PYS5gwpCz+7zMV2oROmtRysYyaqvl4nH+xoN\n H/mA==", "X-Gm-Message-State": "ACrzQf0zBB5jgad5nKLEo2XHeTSnRalBpuPqiKwD8i23BybC5SzfGdAc\n sM0+nh2zbd/aC/CWZ+5D7Vfsi2jOUS4Jnw==", "X-Google-Smtp-Source": "\n AMsMyM5lj2E8XKuVvtFC+cl45TQZL1N3XRAFUVKqO7WbnAhu7L8FfM4YijP7D/H+UJZWgsvxqoL5xQ==", "X-Received": "by 2002:a17:90a:520c:b0:212:d135:4471 with SMTP id\n v12-20020a17090a520c00b00212d1354471mr83695244pjh.71.1668037616498;\n Wed, 09 Nov 2022 15:46:56 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH 3/4] idpf: remvoee unnecessary null checks", "Date": "Wed, 9 Nov 2022 15:46:48 -0800", "Message-Id": "<20221109234649.331942-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221109234649.331942-1-stephen@networkplumber.org>", "References": "<20221109234649.331942-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function rte_free() already handles NULL argument;\ntherefore the checks in this code are unnecessary.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/idpf/idpf_rxtx.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c\nindex bafa007faf85..b1f58089e031 100644\n--- a/drivers/net/idpf/idpf_rxtx.c\n+++ b/drivers/net/idpf/idpf_rxtx.c\n@@ -251,8 +251,7 @@ reset_single_rx_queue(struct idpf_rx_queue *rxq)\n \trxq->rx_tail = 0;\n \trxq->nb_rx_hold = 0;\n \n-\tif (rxq->pkt_first_seg != NULL)\n-\t\trte_pktmbuf_free(rxq->pkt_first_seg);\n+\trte_pktmbuf_free(rxq->pkt_first_seg);\n \n \trxq->pkt_first_seg = NULL;\n \trxq->pkt_last_seg = NULL;\n", "prefixes": [ "3/4" ] }