Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119686/?format=api
{ "id": 119686, "url": "http://patches.dpdk.org/api/patches/119686/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109234649.331942-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109234649.331942-3-stephen@networkplumber.org", "date": "2022-11-09T23:46:47", "name": "[2/4] mlx5: remove unnecessary null checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8d5de0b5819296dd15409f590f806fe94a0d8759", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 25680, "url": "http://patches.dpdk.org/api/series/25680/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25680", "date": "2022-11-09T23:46:45", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/25680/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119686/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119686/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2A03A0093;\n\tThu, 10 Nov 2022 00:47:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 73767410E7;\n\tThu, 10 Nov 2022 00:46:58 +0100 (CET)", "from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 63DFC40156\n for <dev@dpdk.org>; Thu, 10 Nov 2022 00:46:56 +0100 (CET)", "by mail-pj1-f52.google.com with SMTP id\n c15-20020a17090a1d0f00b0021365864446so191591pjd.4\n for <dev@dpdk.org>; Wed, 09 Nov 2022 15:46:56 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Nov 2022 15:46:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=j5co4SVnDs+RMKfasJ46cav5do5uDqVp8PfISy2ngLc=;\n b=cUxEAUMSHfqKrKq5ViYWMKLtiIU6UzvR79owJcWdvH8Q8IUazIuSPQbeN998Vxsr17\n DO9KhGuGyOxjdwFsMAf6/xeqouyKnS/C7SqpCyyV9thMqnZCO2239GkiA9KjmceGFwGf\n ZttdE/t0M3kco0FgwkdbQ11IwoWPJLOwY9FSTp4IACdwdZJTKOUOM237EN1/aC5ho1EK\n kVBjEX7RXf5qBr+DJGKABL4cLkQuHcirad8qeo3mmKULdsV+Ke4/PCKDo9x1XiBRnbJW\n E15/aVJiWEZ2hMDlzRWCDx1+AnfF5P54uXFAeMH+OLHcAA9lvct2+DRSEW0VjRFeGeFO\n k7tw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=j5co4SVnDs+RMKfasJ46cav5do5uDqVp8PfISy2ngLc=;\n b=W2kRbRbjUO3UDr8tUnqaE1qS2J+PR9YZ3pnj/rlmuKf0ideIzvEy6VeWYEOlvJ7y5H\n lU1EucAjxwRP3jSFqYlZehP9etA/ujqFT9aoOOIThtKZOK643OC+BcLABXPOIVeicWbk\n D9cPlhPiIHhICPSy3Lx4tyBLiMxNFVPhVKleqofJT52w0qeKmdPxlbiOYOIAJDTFG1Jo\n IcWV82O3f771O83xEr/xv7psGPa6l9Dn6rH2DxQl68EbtaB0XHsWcl+LwwBY5WO983vn\n 73Kz4Bph3jFMQLV/LvADsh+ixcnz19bcIUsD07h9fRTIMklpKv2Wwis4RPPnHXWeEA7/\n 289w==", "X-Gm-Message-State": "ACrzQf3DY9O++NJ1vMZNYbPcfzBnZflV9UsBXRvEmS2eRZZ0IZfcRan/\n BKP6D9C5XSD1F5D5WTIajd4X2YBkNY4WpA==", "X-Google-Smtp-Source": "\n AMsMyM4WLTZEBByqw+C39aIUOLo6mMUBRvP507tzaaTFKQGcOJOTNVyGr30yy0G7YRty+/xafgai6w==", "X-Received": "by 2002:a17:90a:d586:b0:213:de8f:4d6 with SMTP id\n v6-20020a17090ad58600b00213de8f04d6mr56551296pju.31.1668037615263;\n Wed, 09 Nov 2022 15:46:55 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Subject": "[PATCH 2/4] mlx5: remove unnecessary null checks", "Date": "Wed, 9 Nov 2022 15:46:47 -0800", "Message-Id": "<20221109234649.331942-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221109234649.331942-1-stephen@networkplumber.org>", "References": "<20221109234649.331942-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function rte_free() already handles NULL argument;\ntherefore the checks in this code are unnecessary.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/mlx5/hws/mlx5dr_pool.c | 3 +--\n drivers/net/mlx5/mlx5_flow_hw.c | 6 ++----\n 2 files changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_pool.c b/drivers/net/mlx5/hws/mlx5dr_pool.c\nindex 2bfda5b4a5be..fdbd3d438d08 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_pool.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_pool.c\n@@ -537,8 +537,7 @@ static void mlx5dr_onesize_element_db_uninit(struct mlx5dr_pool *pool)\n \tfor (i = 0; i < MLX5DR_POOL_RESOURCE_ARR_SZ; i++) {\n \t\telem = pool->db.element_manager->elements[i];\n \t\tif (elem) {\n-\t\t\tif (elem->bitmap)\n-\t\t\t\trte_free(elem->bitmap);\n+\t\t\trte_free(elem->bitmap);\n \t\t\tsimple_free(elem);\n \t\t\tpool->db.element_manager->elements[i] = NULL;\n \t\t}\ndiff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 2d275ad11127..bea7805ee267 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -7063,10 +7063,8 @@ flow_hw_configure(struct rte_eth_dev *dev,\n \tif (dr_ctx)\n \t\tclaim_zero(mlx5dr_context_close(dr_ctx));\n \tfor (i = 0; i < nb_q_updated; i++) {\n-\t\tif (priv->hw_q[i].indir_iq)\n-\t\t\trte_ring_free(priv->hw_q[i].indir_iq);\n-\t\tif (priv->hw_q[i].indir_cq)\n-\t\t\trte_ring_free(priv->hw_q[i].indir_cq);\n+\t\trte_ring_free(priv->hw_q[i].indir_iq);\n+\t\trte_ring_free(priv->hw_q[i].indir_cq);\n \t}\n \tmlx5_free(priv->hw_q);\n \tpriv->hw_q = NULL;\n", "prefixes": [ "2/4" ] }