Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119685/?format=api
{ "id": 119685, "url": "http://patches.dpdk.org/api/patches/119685/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109234649.331942-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109234649.331942-2-stephen@networkplumber.org", "date": "2022-11-09T23:46:46", "name": "[1/4] gve: remove unnecessary null checks", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "08e2572d52814b1b3132fc98d3554b12c9fc70e7", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109234649.331942-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 25680, "url": "http://patches.dpdk.org/api/series/25680/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25680", "date": "2022-11-09T23:46:45", "name": "remove unnecessary null checks", "version": 1, "mbox": "http://patches.dpdk.org/series/25680/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119685/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119685/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2222EA0093;\n\tThu, 10 Nov 2022 00:46:59 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 951F840156;\n\tThu, 10 Nov 2022 00:46:56 +0100 (CET)", "from mail-pf1-f173.google.com (mail-pf1-f173.google.com\n [209.85.210.173])\n by mails.dpdk.org (Postfix) with ESMTP id 2E5FE40150\n for <dev@dpdk.org>; Thu, 10 Nov 2022 00:46:55 +0100 (CET)", "by mail-pf1-f173.google.com with SMTP id m6so260153pfb.0\n for <dev@dpdk.org>; Wed, 09 Nov 2022 15:46:55 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n e18-20020a63e012000000b00470275c8d6dsm7895259pgh.10.2022.11.09.15.46.53\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Nov 2022 15:46:53 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=e8zBhTF4zO2j18HYPLKeG1ulVs3p7/kmyKRPOQvYC/g=;\n b=4kBdl+CfGoAiRQE7dXy8kkocTNqH3XWFY9KduOnaKyFDrMXsBlGheHydq7ggtXWP5q\n zwStc5NiPhVvpjg5/3KGCNB5UcyxjmAxxyYIYpiuf4QZucqbKzBGZaZRYpz7kRinUdnn\n f3PYctvUUsJ35Fcb9CBgvmw6vHoDO8GEK9gg9PHw0MnpDY5qDMLUPlwwp4zeqT+0wDS4\n WSVmBmdbk5Vi9HuVtzGmI0miH3G8xqAfNpU6U4OpdxydnLLCta5vafnlDVURtp9/FAjl\n StGH845QQdMD0FkQZbmnw3DRUiUC+gYTlO71wTNUAMeu2JRYToTgZsLauHMggltLnSn0\n HMKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=e8zBhTF4zO2j18HYPLKeG1ulVs3p7/kmyKRPOQvYC/g=;\n b=p1rwEgEqZaQF9ThABASIAOiObAy64xsNKvoua6ACDBnUIAlaD4DwDAqP5WBmAmax4O\n XcFJSsQONlk3g6+e3LK/MFMXYefUvSj/X7MUJtad/DY72tgj8giolmEJ0ltmZEwg7/3k\n ONhRt3XRLfL50Epip6npTsFtDkbQT8RZvBwtocRmuqExLw6xTsktD+Q6Q3J2G1SpCIpR\n XX5iVsTPA6JI1VZWp3pElMzz62wGFBZs6YtHtvAbz5FA7XFg9eOdCjUqu2kFvP++EcAf\n MGqW10mU4TvM6ZIZEAFeu0QeSau5BJFeEEvJw75Lg8UYxV9uIl/vLM5IgAil6sGv3tu5\n y56Q==", "X-Gm-Message-State": "ACrzQf2YkuqSB6zqW6W+Y/s3fexnUY71wQXHcWn3aoNBnhTBwo2Lr+uU\n HvIJH6PxgC3gpxTgBsVV+zeLVhr49PWXkQ==", "X-Google-Smtp-Source": "\n AMsMyM6O3jnW/nEsWigBhHKNSNv9piA5Q5LvVtPIKpboEm6yL/FQlPqnw5iT4ViWFkyFqZLd5CHrVA==", "X-Received": "by 2002:a65:628f:0:b0:43c:dac:646a with SMTP id\n f15-20020a65628f000000b0043c0dac646amr39497453pgv.397.1668037614076;\n Wed, 09 Nov 2022 15:46:54 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Junfeng Guo <junfeng.guo@intel.com>", "Subject": "[PATCH 1/4] gve: remove unnecessary null checks", "Date": "Wed, 9 Nov 2022 15:46:46 -0800", "Message-Id": "<20221109234649.331942-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221109234649.331942-1-stephen@networkplumber.org>", "References": "<20221109234649.331942-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function rte_free() already handles NULL argument;\ntherefore the checks in this code are unnecessary.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/gve/gve_ethdev.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex 0086162f63b3..a05e61feba1f 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -81,12 +81,10 @@ gve_free_qpls(struct gve_priv *priv)\n \tfor (i = 0; i < nb_txqs + nb_rxqs; i++) {\n \t\tif (priv->qpl[i].mz != NULL)\n \t\t\trte_memzone_free(priv->qpl[i].mz);\n-\t\tif (priv->qpl[i].page_buses != NULL)\n-\t\t\trte_free(priv->qpl[i].page_buses);\n+\t\trte_free(priv->qpl[i].page_buses);\n \t}\n \n-\tif (priv->qpl != NULL)\n-\t\trte_free(priv->qpl);\n+\trte_free(priv->qpl);\n }\n \n static int\n", "prefixes": [ "1/4" ] }