Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119681/?format=api
http://patches.dpdk.org/api/patches/119681/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109232451.265059-13-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109232451.265059-13-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109232451.265059-13-stephen@networkplumber.org", "date": "2022-11-09T23:24:49", "name": "[v3,12/14] net/e1000: fix whitespace", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "327d0ffb78d8d8122b7d5538ddce910a5657b432", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109232451.265059-13-stephen@networkplumber.org/mbox/", "series": [ { "id": 25679, "url": "http://patches.dpdk.org/api/series/25679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25679", "date": "2022-11-09T23:24:37", "name": "whitespace after keywords", "version": 3, "mbox": "http://patches.dpdk.org/series/25679/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119681/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119681/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3BBE3A0093;\n\tThu, 10 Nov 2022 00:26:02 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DDC0842D54;\n\tThu, 10 Nov 2022 00:25:12 +0100 (CET)", "from mail-pg1-f175.google.com (mail-pg1-f175.google.com\n [209.85.215.175])\n by mails.dpdk.org (Postfix) with ESMTP id 003B242D50\n for <dev@dpdk.org>; Thu, 10 Nov 2022 00:25:10 +0100 (CET)", "by mail-pg1-f175.google.com with SMTP id r18so50680pgr.12\n for <dev@dpdk.org>; Wed, 09 Nov 2022 15:25:10 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Nov 2022 15:25:09 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WWiooLfbtswlNemQYSlxEd+r0cBU/l7e2a1Q8UDr748=;\n b=NG7WLTXFrLr/jFIY+dkZiSnFIF/Ss/f7t9NeozZ3hnz0ITgtGC/Y3EHsMZDe7/cm+a\n eawg8z1XB7JZwnJRiqALRKS/HSaBjLMdzZw4TJD8y7Tb42C8v6aCrtPlHCmD/BQbggga\n bqp66v7d0/KfflnDYHW5q+jIqNLERyHxW9SPaHkGrrWt663Aw2xRd3q7dxKXdDXonkHU\n imMXgFnOuRsj2Ahw1fhyJBiAJ0Q+URX6NveCku/j8ygPq+l4jWvficxhWUvUtL+eo9Eq\n k8YHCnY81CohAVbes6HTFXWaJlganAeyOZpSIrl6CmboIzBHVfw42BFdmM34x2VNhRT6\n RXpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=WWiooLfbtswlNemQYSlxEd+r0cBU/l7e2a1Q8UDr748=;\n b=gr7v1jEbRwlnj/LsY5ru03f3+QIkyKLZb9w31+49SOBEDZQ4TUwmZIYEQfVo8gZhP4\n fGGsnvzqddHH+b/Cppo1SPCI7wHmkOEIoLmWDek5OyvduiPPpQeFrezBDa75tcG4atse\n uvvEo/fi6tvJBWB0xzWVhwI4SYK3WRUZa+LKH0pb5yLyOeJkxmgzG6Vbc77iks6aIVqd\n 0t9Lzizp+/udSfoODNsyT8/sxZ/1o7vegocRjDNsI5CJaplJ6Bq4Yb36+NUxtDjpPqDu\n SUbwih1VMdRPN+MoboinTcoz5sJbsO6IYpiquiilh7k3Z7wO9I11NbmylsVGJBlVagFu\n +69g==", "X-Gm-Message-State": "ANoB5plrip+sZSlWHX1tA03I9jD8v02pBY0rHBmXglN5yZ35X2O6Rq5I\n D1SwFq74YuNEVsIB7oUzRvjiBsKuMo37sg==", "X-Google-Smtp-Source": "\n AA0mqf56zvCvW3yKpAJxuZOVx0VfYEOrPaSvrangRGvGcCil622vbJpeWoBvAgvXAFtznlNsNPzFHQ==", "X-Received": "by 2002:a63:f353:0:b0:470:814c:f4ee with SMTP id\n t19-20020a63f353000000b00470814cf4eemr12531760pgj.8.1668036309945;\n Wed, 09 Nov 2022 15:25:09 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Simei Su <simei.su@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>", "Subject": "[PATCH v3 12/14] net/e1000: fix whitespace", "Date": "Wed, 9 Nov 2022 15:24:49 -0800", "Message-Id": "<20221109232451.265059-13-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221109232451.265059-1-stephen@networkplumber.org>", "References": "<20221109191445.140320-1-stephen@networkplumber.org>\n <20221109232451.265059-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add space after keywords.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/e1000/em_ethdev.c | 4 ++--\n drivers/net/e1000/igb_ethdev.c | 8 ++++----\n drivers/net/e1000/igb_pf.c | 2 +-\n drivers/net/e1000/igb_rxtx.c | 2 +-\n 4 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 8ee9be12ad19..146e74cfc76e 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -872,8 +872,8 @@ eth_em_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)\n \t\t\tE1000_DEV_PRIVATE_TO_STATS(dev->data->dev_private);\n \tint pause_frames;\n \n-\tif(hw->phy.media_type == e1000_media_type_copper ||\n-\t\t\t(E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) {\n+\tif (hw->phy.media_type == e1000_media_type_copper ||\n+\t (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) {\n \t\tstats->symerrs += E1000_READ_REG(hw,E1000_SYMERRS);\n \t\tstats->sec += E1000_READ_REG(hw, E1000_SEC);\n \t}\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 8858f975f8cc..67e82d708964 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -1683,7 +1683,7 @@ igb_read_stats_registers(struct e1000_hw *hw, struct e1000_hw_stats *stats)\n \tuint64_t old_rpthc = stats->rpthc;\n \tuint64_t old_hgptc = stats->hgptc;\n \n-\tif(hw->phy.media_type == e1000_media_type_copper ||\n+\tif (hw->phy.media_type == e1000_media_type_copper ||\n \t (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) {\n \t\tstats->symerrs +=\n \t\t E1000_READ_REG(hw,E1000_SYMERRS);\n@@ -3500,10 +3500,10 @@ static void igbvf_set_vfta_all(struct rte_eth_dev *dev, bool on)\n \n \tfor (i = 0; i < IGB_VFTA_SIZE; i++){\n \t\tvfta = shadow_vfta->vfta[i];\n-\t\tif(vfta){\n+\t\tif (vfta) {\n \t\t\tmask = 1;\n \t\t\tfor (j = 0; j < 32; j++){\n-\t\t\t\tif(vfta & mask)\n+\t\t\t\tif (vfta & mask)\n \t\t\t\t\tigbvf_set_vfta(hw,\n \t\t\t\t\t\t(uint16_t)((i<<5)+j), on);\n \t\t\t\tmask<<=1;\n@@ -3528,7 +3528,7 @@ igbvf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n \n \t/*vind is not used in VF driver, set to 0, check ixgbe_set_vfta_vf*/\n \tret = igbvf_set_vfta(hw, vlan_id, !!on);\n-\tif(ret){\n+\tif (ret) {\n \t\tPMD_INIT_LOG(ERR, \"Unable to set VF vlan\");\n \t\treturn ret;\n \t}\ndiff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c\nindex c7588ea57eaa..b1f74eb841d2 100644\n--- a/drivers/net/e1000/igb_pf.c\n+++ b/drivers/net/e1000/igb_pf.c\n@@ -78,7 +78,7 @@ void igb_pf_host_init(struct rte_eth_dev *eth_dev)\n \n \tif (hw->mac.type == e1000_i350)\n \t\tnb_queue = 1;\n-\telse if(hw->mac.type == e1000_82576)\n+\telse if (hw->mac.type == e1000_82576)\n \t\t/* per datasheet, it should be 2, but 1 seems correct */\n \t\tnb_queue = 1;\n \telse\ndiff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c\nindex f32dee46df82..f5677da6b931 100644\n--- a/drivers/net/e1000/igb_rxtx.c\n+++ b/drivers/net/e1000/igb_rxtx.c\n@@ -2276,7 +2276,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)\n \t\t/* 011b Def_Q ignore, according to VT_CTL.DEF_PL */\n \t\tmrqc |= 0x3 << E1000_MRQC_DEF_Q_SHIFT;\n \t\tE1000_WRITE_REG(hw, E1000_MRQC, mrqc);\n-\t} else if(RTE_ETH_DEV_SRIOV(dev).active == 0) {\n+\t} else if (RTE_ETH_DEV_SRIOV(dev).active == 0) {\n \t\t/*\n \t\t * SRIOV inactive scheme\n \t\t */\n", "prefixes": [ "v3", "12/14" ] }{ "id": 119681, "url": "