Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119671/?format=api
{ "id": 119671, "url": "http://patches.dpdk.org/api/patches/119671/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221109232451.265059-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221109232451.265059-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20221109232451.265059-3-stephen@networkplumber.org", "date": "2022-11-09T23:24:39", "name": "[v3,02/14] cmdline: fix whitespace", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "f38f5e9fd54e62660ba04ce8495046156767f676", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221109232451.265059-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 25679, "url": "http://patches.dpdk.org/api/series/25679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25679", "date": "2022-11-09T23:24:37", "name": "whitespace after keywords", "version": 3, "mbox": "http://patches.dpdk.org/series/25679/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119671/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119671/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9BE6EA0093;\n\tThu, 10 Nov 2022 00:25:06 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 955F7410EF;\n\tThu, 10 Nov 2022 00:24:59 +0100 (CET)", "from mail-pg1-f169.google.com (mail-pg1-f169.google.com\n [209.85.215.169])\n by mails.dpdk.org (Postfix) with ESMTP id 3C886410E6\n for <dev@dpdk.org>; Thu, 10 Nov 2022 00:24:58 +0100 (CET)", "by mail-pg1-f169.google.com with SMTP id f63so83106pgc.2\n for <dev@dpdk.org>; Wed, 09 Nov 2022 15:24:58 -0800 (PST)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 09 Nov 2022 15:24:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=IiZjGh6EYGuTuV9xZk6AoXRTZxfa+uP6Q3936gc9mD8=;\n b=eWqyprCJ2hvdq1eqY4+3cGnQQbcovrgmL1+NmHWw8eO5Ht8vqPpOVHQ6cS4wuLwvE1\n NqqkJZuarHaE9Vm2VmAEls1K3kP1FvDEC4YK06NTOLtCVGYUiIu0PHUzh5E/64ksAgoN\n 67xzkcEZIVyI4JP4Jkuab2+X9y5+oaMKQeKKRqLh9ObEP2jKhKliAC06Ut/TNEuRH56I\n eG/nLBjJjfsH1QUF5PjPLKNUkMaoa4lzPCdb7ggdFEM5z4FIdVqjaQ35xQLX5St1xWDd\n Mb2NP6ilkuTpWKSKgagi+HHKUk9+Zn28Rg9C3Fg30ZnHmOzBXG97yMv9i/ZTkfWIjQNV\n WCnQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=IiZjGh6EYGuTuV9xZk6AoXRTZxfa+uP6Q3936gc9mD8=;\n b=dvRZFxcRslytni+RI/8u7nLOvuJ/057aN3pFyE4tvAvvPGIu+eU8IpF9xQj1cXMWye\n JJcoAjLrU+jva4qL6eiFvzxYk1MHXWI8BgpPJs32nIFOFcn9xvoxCebrWs/MtFVa1vKi\n kyMGJeYukjdJMMkE0sYo6A+y6MqYqBDSUVxZH1AZuenwuTbBOQEx1oRtu2+vvzB+EvBL\n lVVkpO93e/bbt1DXcdiWKVf7Dg5wcq8pJ3phhaF6TK+LyOAuMViv7XMiPz7nonZ/HBzh\n viS19iFfOV1rpMWkT0/nDpe8+HEsTTSmDFEAJhI0mRCanuo2TNunqV619tgM/72UhpS2\n pV1Q==", "X-Gm-Message-State": "ACrzQf0ZT7sdcj7VW2Zmc01H8oFzBUMotxvPfeCsERbHbpCbhqiaZNxz\n m2e6r9W0y48dgyiVDyg8QFMij5LNeZ6dcg==", "X-Google-Smtp-Source": "\n AMsMyM444SaT9/gSLlTVtj6KY+c+WPpkFtYgwiTWQE7v64aqyDYen9JKf5eRzw8ykx1g/gC6pd53wA==", "X-Received": "by 2002:a65:42c8:0:b0:41a:8138:f47f with SMTP id\n l8-20020a6542c8000000b0041a8138f47fmr54127446pgp.476.1668036297118;\n Wed, 09 Nov 2022 15:24:57 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Olivier Matz <olivier.matz@6wind.com>", "Subject": "[PATCH v3 02/14] cmdline: fix whitespace", "Date": "Wed, 9 Nov 2022 15:24:39 -0800", "Message-Id": "<20221109232451.265059-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20221109232451.265059-1-stephen@networkplumber.org>", "References": "<20221109191445.140320-1-stephen@networkplumber.org>\n <20221109232451.265059-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add space after keywords.\nRemove unnecessary spaces in if expressions.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/cmdline/cmdline_parse_string.c | 17 +++++++----------\n lib/cmdline/cmdline_rdline.c | 12 ++++++------\n 2 files changed, 13 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/cmdline/cmdline_parse_string.c b/lib/cmdline/cmdline_parse_string.c\nindex d756638905a2..4224983d2e73 100644\n--- a/lib/cmdline/cmdline_parse_string.c\n+++ b/lib/cmdline/cmdline_parse_string.c\n@@ -73,20 +73,17 @@ cmdline_parse_string(cmdline_parse_token_hdr_t *tk, const char *buf, void *res,\n \t\t\ttoken_len = get_token_len(str);\n \n \t\t\t/* if token is too big... */\n-\t\t\tif (token_len >= STR_TOKEN_SIZE - 1) {\n+\t\t\tif (token_len >= STR_TOKEN_SIZE - 1)\n \t\t\t\tcontinue;\n-\t\t\t}\n \n-\t\t\tif ( strncmp(buf, str, token_len) ) {\n+\t\t\tif (strncmp(buf, str, token_len))\n \t\t\t\tcontinue;\n-\t\t\t}\n \n-\t\t\tif ( !cmdline_isendoftoken(*(buf+token_len)) ) {\n+\t\t\tif (!cmdline_isendoftoken(*(buf+token_len)))\n \t\t\t\tcontinue;\n-\t\t\t}\n \n \t\t\tbreak;\n-\t\t} while ( (str = get_next_token(str)) != NULL );\n+\t\t} while ((str = get_next_token(str)) != NULL);\n \n \t\tif (!str)\n \t\t\treturn -1;\n@@ -108,7 +105,7 @@ cmdline_parse_string(cmdline_parse_token_hdr_t *tk, const char *buf, void *res,\n \t/* unspecified string (unknown single token) */\n \telse {\n \t\ttoken_len = 0;\n-\t\twhile(!cmdline_isendoftoken(buf[token_len]) &&\n+\t\twhile (!cmdline_isendoftoken(buf[token_len]) &&\n \t\t token_len < (STR_TOKEN_SIZE-1))\n \t\t\ttoken_len++;\n \n@@ -149,9 +146,9 @@ int cmdline_complete_get_nb_string(cmdline_parse_token_hdr_t *tk)\n \t\treturn 0;\n \n \tstr = sd->str;\n-\twhile( (str = get_next_token(str)) != NULL ) {\n+\twhile ((str = get_next_token(str)) != NULL)\n \t\tret++;\n-\t}\n+\n \treturn ret;\n }\n \ndiff --git a/lib/cmdline/cmdline_rdline.c b/lib/cmdline/cmdline_rdline.c\nindex 5cf723a0126a..b5927879d48f 100644\n--- a/lib/cmdline/cmdline_rdline.c\n+++ b/lib/cmdline/cmdline_rdline.c\n@@ -301,7 +301,7 @@ rdline_char_in(struct rdline *rdl, char c)\n \t\t/* delete 1 char from the left */\n \t\tcase CMDLINE_KEY_BKSPACE:\n \t\tcase CMDLINE_KEY_BKSPACE2:\n-\t\t\tif(!cirbuf_del_tail_safe(&rdl->left)) {\n+\t\t\tif (!cirbuf_del_tail_safe(&rdl->left)) {\n \t\t\t\trdline_puts(rdl, vt100_bs);\n \t\t\t\tdisplay_right_buffer(rdl, 1);\n \t\t\t}\n@@ -354,7 +354,7 @@ rdline_char_in(struct rdline *rdl, char c)\n \t\t/* paste contents of kill buffer to the left side of caret */\n \t\tcase CMDLINE_KEY_CTRL_Y:\n \t\t\ti=0;\n-\t\t\twhile(CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) <\n+\t\t\twhile (CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) <\n \t\t\t RDLINE_BUF_SIZE &&\n \t\t\t i < rdl->kill_size) {\n \t\t\t\tcirbuf_add_tail(&rdl->left, rdl->kill_buf[i]);\n@@ -403,10 +403,10 @@ rdline_char_in(struct rdline *rdl, char c)\n \t\t\t\ttmp_size = strnlen(tmp_buf, sizeof(tmp_buf));\n \t\t\t\t/* add chars */\n \t\t\t\tif (ret == RDLINE_RES_COMPLETE) {\n-\t\t\t\t\ti=0;\n-\t\t\t\t\twhile(CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) <\n-\t\t\t\t\t RDLINE_BUF_SIZE &&\n-\t\t\t\t\t i < tmp_size) {\n+\t\t\t\t\ti = 0;\n+\t\t\t\t\twhile (CIRBUF_GET_LEN(&rdl->right) +\n+\t\t\t\t\t CIRBUF_GET_LEN(&rdl->left) <\n+\t\t\t\t\t RDLINE_BUF_SIZE && i < tmp_size) {\n \t\t\t\t\t\tcirbuf_add_tail(&rdl->left, tmp_buf[i]);\n \t\t\t\t\t\trdl->write_char(rdl, tmp_buf[i]);\n \t\t\t\t\t\ti++;\n", "prefixes": [ "v3", "02/14" ] }