Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119535/?format=api
{ "id": 119535, "url": "http://patches.dpdk.org/api/patches/119535/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221108101226.712574-2-mingjinx.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221108101226.712574-2-mingjinx.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221108101226.712574-2-mingjinx.ye@intel.com", "date": "2022-11-08T10:12:26", "name": "[v5,2/2] net/ice: fix vlan offload of rxq", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "619dc5b57450ca07937aebfd6b43c6de08989eac", "submitter": { "id": 2862, "url": "http://patches.dpdk.org/api/people/2862/?format=api", "name": "Mingjin Ye", "email": "mingjinx.ye@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221108101226.712574-2-mingjinx.ye@intel.com/mbox/", "series": [ { "id": 25611, "url": "http://patches.dpdk.org/api/series/25611/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25611", "date": "2022-11-08T10:12:26", "name": "[v5,1/2] net/ice: fix vlan offload", "version": 5, "mbox": "http://patches.dpdk.org/series/25611/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119535/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119535/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF0A5A00C4;\n\tTue, 8 Nov 2022 03:25:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 838B5400D7;\n\tTue, 8 Nov 2022 03:25:49 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id AC7534003C;\n Tue, 8 Nov 2022 03:25:47 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Nov 2022 18:25:39 -0800", "from unknown (HELO yemj..) ([10.239.252.253])\n by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Nov 2022 18:25:36 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1667874348; x=1699410348;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=efamDdCi19Syh+JptkOKUcR7qn2ERmCkQxTYiuxXdo8=;\n b=kP8RziSWOfMOs8vwFnbDF9/PtiAFhyNnD7r8x5kvFwtuZPRFHffWNB/l\n S0+lsAmQdqmn2h8ZPqejKfQtZVl38i9cUVnUs2k2mx7P9g7bYdPt4fteU\n nmdud5BvoFWaoNZpCQm6xL8pVH9iJCWJ9tQx0EKLUrDlz5GTAXDsjs5jQ\n o1CNSLQ89CQ9i07DZ/Xw2LT+oZL1dNNSh4TE/pMMBNTR/kXNdjcdnMWuY\n s8X96pDMw1Ki7D2HZYiYvzUnsLizm4rX9lw9ZjXw5VWM3V3sHuzJy+p45\n g9SkJwCBet0Jl9WZ5IdJYKg8Hbx2wE8gY/gnvB3ZnDqLwBBQe7hMOsxEk Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10524\"; a=\"311734189\"", "E=Sophos;i=\"5.96,145,1665471600\"; d=\"scan'208\";a=\"311734189\"", "E=McAfee;i=\"6500,9779,10524\"; a=\"587203577\"", "E=Sophos;i=\"5.96,145,1665471600\"; d=\"scan'208\";a=\"587203577\"" ], "From": "Mingjin Ye <mingjinx.ye@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, yidingx.zhou@intel.com,\n Mingjin Ye <mingjinx.ye@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Subject": "[PATCH v5 2/2] net/ice: fix vlan offload of rxq", "Date": "Tue, 8 Nov 2022 10:12:26 +0000", "Message-Id": "<20221108101226.712574-2-mingjinx.ye@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221108101226.712574-1-mingjinx.ye@intel.com>", "References": "<20221108101226.712574-1-mingjinx.ye@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "After setting \"vlan offload\" in pmd, the configuration of rxq is not\nupdated.\n\nThis patch is to sync the rxmode offload config with rxq.\n\nFixes: e0dcf94a0d7f (\"net/ice: support VLAN ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mingjin Ye <mingjinx.ye@intel.com>\n---\n drivers/net/ice/ice_dcf_ethdev.c | 15 +++++++++++++++\n drivers/net/ice/ice_ethdev.c | 7 +++++++\n 2 files changed, 22 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c\nindex dcbf2af5b0..c32bf4ec03 100644\n--- a/drivers/net/ice/ice_dcf_ethdev.c\n+++ b/drivers/net/ice/ice_dcf_ethdev.c\n@@ -1227,6 +1227,8 @@ dcf_dev_vlan_offload_set_v2(struct rte_eth_dev *dev, int mask)\n \tstruct ice_dcf_hw *hw = &adapter->real_hw;\n \tbool enable;\n \tint err;\n+\tsize_t queue_idx;\n+\tstruct ice_rx_queue *rxq;\n \n \tif (mask & RTE_ETH_VLAN_FILTER_MASK) {\n \t\tenable = !!(rxmode->offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER);\n@@ -1245,6 +1247,11 @@ dcf_dev_vlan_offload_set_v2(struct rte_eth_dev *dev, int mask)\n \t\t\treturn -EIO;\n \t}\n \n+\tfor (queue_idx = 0; queue_idx < dev->data->nb_rx_queues; queue_idx++) {\n+\t\trxq = dev->data->rx_queues[queue_idx];\n+\t\trxq->offloads = rxmode->offloads;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -1287,6 +1294,8 @@ dcf_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \tstruct ice_dcf_adapter *adapter = dev->data->dev_private;\n \tstruct ice_dcf_hw *hw = &adapter->real_hw;\n \tint err;\n+\tsize_t queue_idx;\n+\tstruct ice_rx_queue *rxq;\n \n \tif (hw->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN_V2)\n \t\treturn dcf_dev_vlan_offload_set_v2(dev, mask);\n@@ -1305,6 +1314,12 @@ dcf_dev_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \t\tif (err)\n \t\t\treturn -EIO;\n \t}\n+\n+\tfor (queue_idx = 0; queue_idx < dev->data->nb_rx_queues; queue_idx++) {\n+\t\trxq = dev->data->rx_queues[queue_idx];\n+\t\trxq->offloads = dev_conf->rxmode.offloads;\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 8618a3e6b7..5562ceb671 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -4501,6 +4501,8 @@ ice_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct ice_vsi *vsi = pf->main_vsi;\n \tstruct rte_eth_rxmode *rxmode;\n+\tsize_t queue_idx;\n+\tstruct ice_rx_queue *rxq;\n \n \trxmode = &dev->data->dev_conf.rxmode;\n \tif (mask & RTE_ETH_VLAN_FILTER_MASK) {\n@@ -4517,6 +4519,11 @@ ice_vlan_offload_set(struct rte_eth_dev *dev, int mask)\n \t\t\tice_vsi_config_vlan_stripping(vsi, false);\n \t}\n \n+\tfor (queue_idx = 0; queue_idx < dev->data->nb_rx_queues; queue_idx++) {\n+\t\trxq = dev->data->rx_queues[queue_idx];\n+\t\trxq->offloads = rxmode->offloads;\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "v5", "2/2" ] }