Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119090/?format=api
{ "id": 119090, "url": "http://patches.dpdk.org/api/patches/119090/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221025090052.429232-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221025090052.429232-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221025090052.429232-4-david.marchand@redhat.com", "date": "2022-10-25T09:00:51", "name": "[v3,3/4] trace: enable trace operations via telemetry", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c246a24c8f288b2a0e17bfb242c10abc83923218", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221025090052.429232-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 25415, "url": "http://patches.dpdk.org/api/series/25415/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25415", "date": "2022-10-25T09:00:48", "name": "Telemetry support for traces", "version": 3, "mbox": "http://patches.dpdk.org/series/25415/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119090/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/119090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 53849A0543;\n\tTue, 25 Oct 2022 11:01:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 459E642BF8;\n\tTue, 25 Oct 2022 11:01:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 248C242BEC\n for <dev@dpdk.org>; Tue, 25 Oct 2022 11:01:15 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-288-HZhKCad8OQmGI-8l0gne-w-1; Tue, 25 Oct 2022 05:01:12 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com\n [10.11.54.4])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A7BD8027EC;\n Tue, 25 Oct 2022 09:01:12 +0000 (UTC)", "from localhost.localdomain (ovpn-193-2.brq.redhat.com [10.40.193.2])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 64B0320290A5;\n Tue, 25 Oct 2022 09:01:11 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1666688474;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=QUkpo5T9hq6xl/4QFpB5x5z+4JErmsoJ/KivBCngiM0=;\n b=iGjsBdiOvM+2Et8vq5gPb5IpXq0TAorofrRPfQVF2G0gG09H5P7QC+/apxSsMaaoYbcjQA\n 2aHe2Q+pzaXCZ8/WCw6Sbb+h5G57YjVzvEvHDbVAEN8zYH1/9g8KXkSv78yVYlhPzLal9S\n FoKD7vhU70SX9uUzIemX6dF2M1p+2v0=", "X-MC-Unique": "HZhKCad8OQmGI-8l0gne-w-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Jerin Jacob <jerinj@marvell.com>,\n\tSunil Kumar Kori <skori@marvell.com>", "Subject": "[PATCH v3 3/4] trace: enable trace operations via telemetry", "Date": "Tue, 25 Oct 2022 11:00:51 +0200", "Message-Id": "<20221025090052.429232-4-david.marchand@redhat.com>", "In-Reply-To": "<20221025090052.429232-1-david.marchand@redhat.com>", "References": "<20221013074928.3062458-1-david.marchand@redhat.com>\n <20221025090052.429232-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Register telemetry commands to list and configure trace points and later\nsave traces for a running DPDK application.\n\nExample with testpmd running with two net/null ports (startup command\nfrom devtools/test-null.sh):\n\n--> /trace/list,lib.ethdev.*\n{\"/trace/list\": {\"lib.ethdev.configure\": false,\n \"lib.ethdev.rxq.setup\": false,\n \"lib.ethdev.txq.setup\": false,\n \"lib.ethdev.start\": false,\n \"lib.ethdev.stop\": false,\n \"lib.ethdev.close\": false,\n \"lib.ethdev.rx.burst\": false,\n \"lib.ethdev.tx.burst\": false}}\n\n--> /trace/enable,lib.ethdev.st*\n{\"/trace/enable\": {\"Count\": 2}}\n--> /trace/enable,lib.ethdev.st*\n{\"/trace/enable\": {\"Count\": 0}}\n\n--> /trace/list,lib.ethdev.*\n{\"/trace/list\": {\"lib.ethdev.configure\": false,\n \"lib.ethdev.rxq.setup\": false,\n \"lib.ethdev.txq.setup\": false,\n \"lib.ethdev.start\": true,\n \"lib.ethdev.stop\": true,\n \"lib.ethdev.close\": false,\n \"lib.ethdev.rx.burst\": false,\n \"lib.ethdev.tx.burst\": false}}\n\ntestpmd> stop\n...\ntestpmd> port stop all\n...\ntestpmd> port start all\n...\ntestpmd> start\n...\n\n--> /trace/save\n{\"/trace/save\": {\"Status\": \"OK\",\n \"Path\": \".../dpdk-traces/rte-2022-10-12-AM-10-51-48\"}}\n\n$ babeltrace .../dpdk-traces/rte-2022-10-12-AM-10-51-48\n[10:51:36.229878723] (+?.?????????) lib.ethdev.stop:\n { cpu_id = 0x0, name = \"dpdk-testpmd\" }, { port_id = 0x0, ret = 0 }\n[10:51:36.229880251] (+0.000001528) lib.ethdev.stop:\n { cpu_id = 0x0, name = \"dpdk-testpmd\" }, { port_id = 0x1, ret = 0 }\n[10:51:40.449359774] (+4.219479523) lib.ethdev.start:\n { cpu_id = 0x0, name = \"dpdk-testpmd\" }, { port_id = 0x0 }\n[10:51:40.449377877] (+0.000018103) lib.ethdev.start:\n { cpu_id = 0x0, name = \"dpdk-testpmd\" }, { port_id = 0x1 }\n\n--> /trace/disable,*\n{\"/trace/disable\": {\"Count\": 2}}\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\nChanges since v2:\n- separated telemetry change in a dedicated patch,\n- switched to boolean types,\n\nChanges since v1:\n- added a note in the documentation,\n\n---\n doc/guides/prog_guide/trace_lib.rst | 39 +++++++++++++++\n lib/eal/common/eal_common_trace.c | 78 +++++++++++++++++++++++++++++\n 2 files changed, 117 insertions(+)", "diff": "diff --git a/doc/guides/prog_guide/trace_lib.rst b/doc/guides/prog_guide/trace_lib.rst\nindex 9a8f38073d..d0a6bdae4c 100644\n--- a/doc/guides/prog_guide/trace_lib.rst\n+++ b/doc/guides/prog_guide/trace_lib.rst\n@@ -233,6 +233,45 @@ This section steps you through the details of generating trace and viewing it.\n \n babeltrace $HOME/dpdk-traces/rte-yyyy-mm-dd-[AP]M-hh-mm-ss/\n \n+Configuring traces on a running DPDK application\n+------------------------------------------------\n+\n+The DPDK trace library can be configured using the Telemetry interface.\n+\n+Examples::\n+\n+ --> /trace/list,lib.ethdev.*\n+ {\"/trace/list\": {\"lib.ethdev.configure\": false,\n+ \"lib.ethdev.rxq.setup\": false,\n+ \"lib.ethdev.txq.setup\": false,\n+ \"lib.ethdev.start\": false,\n+ \"lib.ethdev.stop\": false,\n+ \"lib.ethdev.close\": false,\n+ \"lib.ethdev.rx.burst\": false,\n+ \"lib.ethdev.tx.burst\": false}}\n+\n+ --> /trace/enable,lib.ethdev.st*\n+ {\"/trace/enable\": {\"Count\": 2}}\n+ --> /trace/enable,lib.ethdev.st*\n+ {\"/trace/enable\": {\"Count\": 0}}\n+\n+ --> /trace/list,lib.ethdev.*\n+ {\"/trace/list\": {\"lib.ethdev.configure\": false,\n+ \"lib.ethdev.rxq.setup\": false,\n+ \"lib.ethdev.txq.setup\": false,\n+ \"lib.ethdev.start\": true,\n+ \"lib.ethdev.stop\": true,\n+ \"lib.ethdev.close\": false,\n+ \"lib.ethdev.rx.burst\": false,\n+ \"lib.ethdev.tx.burst\": false}}\n+\n+ --> /trace/save\n+ {\"/trace/save\": {\"Status\": \"OK\",\n+ \"Path\": \".../dpdk-traces/rte-2022-10-12-AM-10-51-48\"}}\n+\n+For more information on how to use the Telemetry interface, see\n+the :doc:`../howto/telemetry`.\n+\n Implementation details\n ----------------------\n \ndiff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex 5caaac8e59..bb26af618a 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -12,6 +12,7 @@\n #include <rte_lcore.h>\n #include <rte_per_lcore.h>\n #include <rte_string_fns.h>\n+#include <rte_telemetry.h>\n \n #include \"eal_trace.h\"\n \n@@ -521,3 +522,80 @@ __rte_trace_point_register(rte_trace_point_t *handle, const char *name,\n \n \treturn -rte_errno;\n }\n+\n+static int\n+trace_telemetry_enable(const char *cmd __rte_unused,\n+\tconst char *params, struct rte_tel_data *d)\n+{\n+\tunsigned int count;\n+\n+\tif (params == NULL || strlen(params) == 0)\n+\t\treturn -1;\n+\trte_tel_data_start_dict(d);\n+\tcount = __atomic_load_n(&trace.status, __ATOMIC_RELAXED);\n+\trte_trace_pattern(params, true);\n+\trte_tel_data_add_dict_int(d, \"Count\",\n+\t\t__atomic_load_n(&trace.status, __ATOMIC_RELAXED) - count);\n+\treturn 0;\n+\n+}\n+\n+static int\n+trace_telemetry_disable(const char *cmd __rte_unused,\n+\tconst char *params, struct rte_tel_data *d)\n+{\n+\tunsigned int count;\n+\n+\tif (params == NULL || strlen(params) == 0)\n+\t\treturn -1;\n+\trte_tel_data_start_dict(d);\n+\tcount = __atomic_load_n(&trace.status, __ATOMIC_RELAXED);\n+\trte_trace_pattern(params, false);\n+\trte_tel_data_add_dict_int(d, \"Count\",\n+\t\tcount - __atomic_load_n(&trace.status, __ATOMIC_RELAXED));\n+\treturn 0;\n+\n+}\n+\n+static int\n+trace_telemetry_list(const char *cmd __rte_unused,\n+\tconst char *params, struct rte_tel_data *d)\n+{\n+\tstruct trace_point *tp;\n+\n+\trte_tel_data_start_dict(d);\n+\tSTAILQ_FOREACH(tp, &tp_list, next) {\n+\t\tif (params != NULL && fnmatch(params, tp->name, 0) != 0)\n+\t\t\tcontinue;\n+\n+\t\trte_tel_data_add_dict_bool(d, tp->name,\n+\t\t\trte_trace_point_is_enabled(tp->handle));\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+trace_telemetry_save(const char *cmd __rte_unused,\n+\tconst char *params __rte_unused, struct rte_tel_data *d)\n+{\n+\tstruct trace *trace = trace_obj_get();\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_string(d, \"Status\", rte_trace_save() == 0 ? \"OK\" : \"KO\");\n+\trte_tel_data_add_dict_string(d, \"Path\", trace->dir);\n+\n+\treturn 0;\n+}\n+\n+RTE_INIT(trace_telemetry)\n+{\n+\trte_telemetry_register_cmd(\"/trace/enable\", trace_telemetry_enable,\n+\t\t\"Enable trace points matching the provided pattern. Parameters: string pattern.\");\n+\trte_telemetry_register_cmd(\"/trace/disable\", trace_telemetry_disable,\n+\t\t\"Disable trace points matching the provided pattern. Parameters: string pattern.\");\n+\trte_telemetry_register_cmd(\"/trace/list\", trace_telemetry_list,\n+\t\t\"List trace points. Parameters: string pattern.\");\n+\trte_telemetry_register_cmd(\"/trace/save\", trace_telemetry_save,\n+\t\t\"Save current traces. Takes no parameter.\");\n+}\n", "prefixes": [ "v3", "3/4" ] }