Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119039/?format=api
{ "id": 119039, "url": "http://patches.dpdk.org/api/patches/119039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221017154507.934995-2-mpiszczek@ddn.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221017154507.934995-2-mpiszczek@ddn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221017154507.934995-2-mpiszczek@ddn.com", "date": "2022-10-17T15:45:07", "name": "[v6] pci: read amd iommu virtual address width", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "90709e6811716a16ae15b5d2f9ac7380a49117eb", "submitter": { "id": 2840, "url": "http://patches.dpdk.org/api/people/2840/?format=api", "name": "Michael Piszczek", "email": "mpiszczek@ddn.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221017154507.934995-2-mpiszczek@ddn.com/mbox/", "series": [ { "id": 25396, "url": "http://patches.dpdk.org/api/series/25396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25396", "date": "2022-10-17T15:45:07", "name": "[v6] pci: read amd iommu virtual address width", "version": 6, "mbox": "http://patches.dpdk.org/series/25396/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119039/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/119039/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E33AEA0542;\n\tMon, 24 Oct 2022 17:34:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 67F8942BFA;\n\tMon, 24 Oct 2022 17:33:17 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])\n by mails.dpdk.org (Postfix) with ESMTP id 996394021E\n for <dev@dpdk.org>; Mon, 17 Oct 2022 17:45:17 +0200 (CEST)", "from BN9PR03CA0375.namprd03.prod.outlook.com (2603:10b6:408:f7::20)\n by DM6PR19MB3996.namprd19.prod.outlook.com (2603:10b6:5:240::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Mon, 17 Oct\n 2022 15:45:16 +0000", "from BN8NAM04FT068.eop-NAM04.prod.protection.outlook.com\n (2603:10b6:408:f7:cafe::b3) by BN9PR03CA0375.outlook.office365.com\n (2603:10b6:408:f7::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31 via Frontend\n Transport; Mon, 17 Oct 2022 15:45:16 +0000", "from uww-mx01.datadirectnet.com (50.222.100.11) by\n BN8NAM04FT068.mail.protection.outlook.com (10.13.160.153) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 15:45:15 +0000", "from localhost (unknown [10.68.0.8])\n by uww-mx01.datadirectnet.com (Postfix) with ESMTP id 70ACF20C687A;\n Mon, 17 Oct 2022 09:46:25 -0600 (MDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=F1BN/LJ0n9hDDnzWsoQRxzdsIXi1hEvx1KKw7EkJ00rg3kAUU+rulJLYwrxR5EQLMr0WovIgHc0+ISp6pemK6zjfvn9ohJHOMgEHIdgqOoLjQU45MLyXjju3oVjRWmoL97KcuLh8WPxwX24dHtI2ncOS42JKn1xUfmw5au8uwF5EL9tNjNbl70ayG7EBw29emHl4LOZCAqminBrU+2Il1Bv7gzYqXat7MXgmzPY4kWA5OXdCIRGckEGNfePoA8s6wB8vwkqTUwGdIQ70A8y/1jusbdr2l1A/ld9ev2b0CjImc78M7l5xQDzB8A1qMNd/PUwifaHKOg09R1IDz59gxw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=P/QgIsfJNQJZWj7D2U65f+unczDVrzhgcShhpM2IABk=;\n b=dOqbfcwFqPoiVQWNgw4QVEbFPDGSk0GzfDXt2pS9rMESrlO9HsQ3BiuiLMYUavset9SOeXARYrfrz2amIYl2GW2obLdsAYaPsEFLXQFJiex29Ygv7EeusnOS27NH1ctw2adjVn3qukMIvE6Mb/Cla4YJTLZth8+QefkN19WvpEIOLHVP4XSDP76s3VdCFS3GdRNgeKxtgJG86hMDZlIue/mZOq+EAZL5FzmwXlFJ8LEptARs/WfQoNZ5Im4JPjR4C3gw5y0m6LCowWzMEOZyPbjrLaOHVHzRD4iqDs8saEk491hXUUcTU179lqKuW0T2QedoPv4wvB9nilmgHPDmKQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 50.222.100.11) smtp.rcpttodomain=ddn.com smtp.mailfrom=ddn.com; dmarc=pass\n (p=reject sp=none pct=100) action=none header.from=ddn.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddn.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=P/QgIsfJNQJZWj7D2U65f+unczDVrzhgcShhpM2IABk=;\n b=ShblwrFlOXrJe/zjrZHVH0dTD2o9yc3QBLg22An97oc7k6+xZzV9Xdq4TzXVlIc0Kp+89z7yYnnBhHSAvLzH4u5SmID+X5SxP0JfBPrN2Aj/N3nXmFudqAtDxpUDruNq1qYxhFmB961+FzSjOvebXhKl7xnoVLOtPENjeF0p1rM=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 50.222.100.11)\n smtp.mailfrom=ddn.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ddn.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ddn.com designates\n 50.222.100.11 as permitted sender) receiver=protection.outlook.com;\n client-ip=50.222.100.11; helo=uww-mx01.datadirectnet.com; pr=C", "From": "Michael Piszczek <mpiszczek@ddn.com>", "To": "dev@dpdk.org", "Cc": "Michael Piszczek <mpiszczek@ddn.com>", "Subject": "[PATCH v6] pci: read amd iommu virtual address width", "Date": "Mon, 17 Oct 2022 17:45:07 +0200", "Message-Id": "<20221017154507.934995-2-mpiszczek@ddn.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221017154507.934995-1-mpiszczek@ddn.com>", "References": "<20220912160157.3642968-2-mpiszczek@ddn.com>\n <20221017154507.934995-1-mpiszczek@ddn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BN8NAM04FT068:EE_|DM6PR19MB3996:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "7496191e-0406-4adf-0ae1-08dab0569624", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n hDjVl/cluxgvTQF43/s22ZqkCyFWalveG8AHPjzBu5Zd6TGDsp5i3ETfNwKmOLfgQ4+mHJaIPp9pCWf7qMpPuVIZtsEil8e3Y+NW7boYzL5Cx8RuJb/4960syKcf2nTPa0i3FXEpUzCzZcQs3tAWrjtA6WpHotYioDa6IKcHr00wUaxoLZ697EN4nEzs6sxYj9OAPTvh8OuJyM8zBZe0onjDoWvqdWVKb3VNNxV2uw79KltP+MtqwYTFW3YudMuMmVHKJ+uIsWNC86tDWnz3bgkXU0AePH3NGTKCBK035Uc//fM6cS43BrMf/+liCOgUS4sHmzUQ7zTMQhU2m4S8dy6weuCK0eQyIsNckTpoBnOSAoujx3FvdgEYSJjAF+PocdyqYUDxr8rN36UD7udp/sHWbmVCnEwkqDurEIkULvSbEEv0nTUKGNbXNp4aBsskGcBK+0GRAhMCuUnRr/SziZqWceFziOQ4ECQ058LbGqD1mVxN1vHseVtE7ACYpPJ4fJv0RCnNakkYeFJsPPR0IraCS9fpdzR1GZkaDx8s6sgL1kfTFXy0zqA573UfaRfHM3AcdJg7pTtjV0GG8yPBZtDF+hgsWOdlm9qPtxNRilnEX3zgjvLDUDwUaivqs43YRWnB9/IMnEWQge4+L/1H5TC3sNl7jGJALfVLipR4myHkoFSifuBEMYwspl25XXBGtD8ZANuQzWv2CURcfQR7qTcIJKebrv9JKxbElMj3SKR00ctb91sYLHLndoOAx16z3iLHVP5PBHYHv9bqkPyTlA==", "X-Forefront-Antispam-Report": "CIP:50.222.100.11; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:uww-mx01.datadirectnet.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230022)(4636009)(346002)(39850400004)(396003)(136003)(376002)(451199015)(46966006)(36840700001)(6916009)(8676002)(316002)(478600001)(41300700001)(4326008)(6266002)(26005)(1076003)(186003)(336012)(2906002)(5660300002)(8936002)(2616005)(82740400003)(36756003)(356005)(81166007)(82310400005)(47076005)(6666004)(36860700001)(83380400001)(70206006)(70586007)(40480700001)(86362001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ddn.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Oct 2022 15:45:15.7404 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7496191e-0406-4adf-0ae1-08dab0569624", "X-MS-Exchange-CrossTenant-Id": "753b6e26-6fd3-43e6-8248-3f1735d59bb4", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=753b6e26-6fd3-43e6-8248-3f1735d59bb4; Ip=[50.222.100.11];\n Helo=[uww-mx01.datadirectnet.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM04FT068.eop-NAM04.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR19MB3996", "X-Mailman-Approved-At": "Mon, 24 Oct 2022 17:33:01 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add code to read the virtual address width for AMD processors.\nUpdated pci_device_iommu_support_va() to use glob to find iommu\ncapability files.\n\nSigned-off-by: Michael Piszczek <mpiszczek@ddn.com>\n---\n drivers/bus/pci/linux/pci.c | 58 ++++++++++++++++++++++---------------\n 1 file changed, 35 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex ebd1395502..291090ba7b 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -4,6 +4,7 @@\n \n #include <string.h>\n #include <dirent.h>\n+#include <glob.h>\n \n #include <rte_log.h>\n #include <rte_pci.h>\n@@ -480,42 +481,53 @@ rte_pci_scan(void)\n }\n \n #if defined(RTE_ARCH_X86)\n+\n bool\n pci_device_iommu_support_va(const struct rte_pci_device *dev)\n {\n-#define VTD_CAP_MGAW_SHIFT\t16\n-#define VTD_CAP_MGAW_MASK\t(0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define VTD_CAP_MGAW_SHIFT 16\n+#define VTD_CAP_MGAW_MASK (0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define RD_AMD_CAP_VASIZE_SHIFT 15\n+#define RD_AMD_CAP_VASIZE_MASK (0x7F << RD_AMD_CAP_VASIZE_SHIFT)\n+\tint rc;\n \tconst struct rte_pci_addr *addr = &dev->addr;\n-\tchar filename[PATH_MAX];\n-\tFILE *fp;\n-\tuint64_t mgaw, vtd_cap_reg = 0;\n+\tchar pattern[PATH_MAX];\n+\tglob_t glob_results;\n+\tuint64_t mgaw = 0;\n \n-\tsnprintf(filename, sizeof(filename),\n-\t\t \"%s/\" PCI_PRI_FMT \"/iommu/intel-iommu/cap\",\n+\tsnprintf(pattern, sizeof(pattern),\n+\t\t \"%s/\" PCI_PRI_FMT \"/iommu/*-iommu/cap\",\n \t\t rte_pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid,\n \t\t addr->function);\n \n-\tfp = fopen(filename, \"r\");\n-\tif (fp == NULL) {\n-\t\t/* We don't have an Intel IOMMU, assume VA supported */\n-\t\tif (errno == ENOENT)\n-\t\t\treturn true;\n+\trc = glob(pattern, 0, NULL, &glob_results);\n+\tif (rc != 0 && glob_results.gl_pathc == 1) {\n+\t\tconst char *filename = glob_results.gl_pathv[0];\n+\t\tFILE *fp = fopen(filename, \"r\");\n \n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't open %s: %s\\n\",\n-\t\t\t__func__, filename, strerror(errno));\n-\t\treturn false;\n-\t}\n+\t\tif (fp != NULL) {\n+\t\t\tuint64_t cap_reg = 0;\n \n-\t/* We have an Intel IOMMU */\n-\tif (fscanf(fp, \"%\" PRIx64, &vtd_cap_reg) != 1) {\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n-\t\tfclose(fp);\n-\t\treturn false;\n+\t\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\t}\n+\t\t\telse if (strstr(filename, \"intel-iommu\") != NULL) {\n+\t\t\t\t/* We have an Intel IOMMU */\n+\t\t\t\tmgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\t\t\t}\n+\t\t\telse if (strstr(filename, \"amd-iommu\") != NULL) {\n+\t\t\t\t/* We have an Amd IOMMU */\n+\t\t\t\tmgaw = ((cap_reg & RD_AMD_CAP_VASIZE_MASK) >> RD_AMD_CAP_VASIZE_SHIFT) + 1;\n+\t\t\t}\n+\n+\t\t\tfclose(fp);\n+\t\t}\n \t}\n \n-\tfclose(fp);\n+\tglobfree(&glob_results);\n \n-\tmgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\tif (mgaw == 0)\n+\t\treturn false;\n \n \t/*\n \t * Assuming there is no limitation by now. We can not know at this point\n", "prefixes": [ "v6" ] }