Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119038/?format=api
{ "id": 119038, "url": "http://patches.dpdk.org/api/patches/119038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221017154507.934995-1-mpiszczek@ddn.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221017154507.934995-1-mpiszczek@ddn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221017154507.934995-1-mpiszczek@ddn.com", "date": "2022-10-17T15:45:06", "name": "[v6] pci: read amd iommu virtual address width", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "90709e6811716a16ae15b5d2f9ac7380a49117eb", "submitter": { "id": 2840, "url": "http://patches.dpdk.org/api/people/2840/?format=api", "name": "Michael Piszczek", "email": "mpiszczek@ddn.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221017154507.934995-1-mpiszczek@ddn.com/mbox/", "series": [ { "id": 25395, "url": "http://patches.dpdk.org/api/series/25395/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25395", "date": "2022-10-17T15:45:06", "name": "[v6] pci: read amd iommu virtual address width", "version": 6, "mbox": "http://patches.dpdk.org/series/25395/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119038/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/119038/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC9A0A0542;\n\tMon, 24 Oct 2022 17:34:21 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 50B8E42BF7;\n\tMon, 24 Oct 2022 17:33:16 +0200 (CEST)", "from NAM02-DM3-obe.outbound.protection.outlook.com\n (mail-dm3nam02on2068.outbound.protection.outlook.com [40.107.95.68])\n by mails.dpdk.org (Postfix) with ESMTP id 28F6E40143\n for <dev@dpdk.org>; Mon, 17 Oct 2022 17:45:16 +0200 (CEST)", "from MW4PR03CA0292.namprd03.prod.outlook.com (2603:10b6:303:b5::27)\n by SA0PR19MB4285.namprd19.prod.outlook.com (2603:10b6:806:8f::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Mon, 17 Oct\n 2022 15:45:13 +0000", "from MW2NAM04FT059.eop-NAM04.prod.protection.outlook.com\n (2603:10b6:303:b5:cafe::40) by MW4PR03CA0292.outlook.office365.com\n (2603:10b6:303:b5::27) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31 via Frontend\n Transport; Mon, 17 Oct 2022 15:45:12 +0000", "from uww-mx01.datadirectnet.com (50.222.100.11) by\n MW2NAM04FT059.mail.protection.outlook.com (10.13.30.132) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 15:45:12 +0000", "from localhost (unknown [10.68.0.8])\n by uww-mx01.datadirectnet.com (Postfix) with ESMTP id 5EA6B20C687A;\n Mon, 17 Oct 2022 09:46:22 -0600 (MDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=HjWEmWxRygzA42bThmtNwlv6LqKHd9Vg77Gg19hI7jf0jdZ+qBBnsCu+cHk7yeSZGlWYK5GrIafUNPWCzfUiF/pfzN6Je33hKCHNVikJlzTH2huDbqTr7kabzuwOUVRAWZCLm8iomksT6lG/zbX9uucMVO0RyzzQ4jPoLLGdlVBm1a/ovB0Yjt2I53w1T6rhYkS/ejq4DjFI3UnXjncQRL47G3Q72Kjait2r8J+7W0ZLmHaXuMhOcmCOd/X6uafc6L+10a6hiC29T+fQEl3RAUCJVlmFNi+6bocZXnUOk68tC21xorvuJPeVpCNwPL2ByiJewePORgJl0zaqAUf+Iw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=P/QgIsfJNQJZWj7D2U65f+unczDVrzhgcShhpM2IABk=;\n b=iMy60cptgHGDOfOxKNhPw005LRjsLiAS03WmJ5Gzjw67K/Rin6IOPg3SGfRBl8xtSafAVsoAOECtwSN/PUEUPvl25eVnNBOqULVc3Tow/ad9gA5VIKTYVJlNqdoVZjmtONOVxlZO8G1vttvC1eWilLiJCXfVy+HXKxYj0uqEYWEOTcqpi7CX3XmAjGJt6m14RRCMW5SUYmt8Jh4nWys50oxU/ZXPhec3P3mgKricSfVKJFEaSV0CQfreaO81qISbcj4plv+GoY2wH31wBms2e1SY62oojFODAmHwg4C3nUaVeBhY/0omVm1ySx/A8E81i54M7RT3mMM0I5rMyRSadw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 50.222.100.11) smtp.rcpttodomain=ddn.com smtp.mailfrom=ddn.com; dmarc=pass\n (p=reject sp=none pct=100) action=none header.from=ddn.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddn.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=P/QgIsfJNQJZWj7D2U65f+unczDVrzhgcShhpM2IABk=;\n b=ruiCMVmC5G9q7Mnx83FFx6ypQwY0fOM+zD7LII0Z+vqU/Hu0uupRhJju8MxV/1K6eMWxFSszb3gLOFCNXyHehMIoppD3ekFQfq/GmQmBvlSfUGsDEd3H6DAQJmqHSUVEMfGe1YNmouy0IqZhv4M0E0uXt6mvfWPaSUfV6jt5+go=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 50.222.100.11)\n smtp.mailfrom=ddn.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ddn.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ddn.com designates\n 50.222.100.11 as permitted sender) receiver=protection.outlook.com;\n client-ip=50.222.100.11; helo=uww-mx01.datadirectnet.com; pr=C", "From": "Michael Piszczek <mpiszczek@ddn.com>", "To": "dev@dpdk.org", "Cc": "Michael Piszczek <mpiszczek@ddn.com>", "Subject": "[PATCH v6] pci: read amd iommu virtual address width", "Date": "Mon, 17 Oct 2022 17:45:06 +0200", "Message-Id": "<20221017154507.934995-1-mpiszczek@ddn.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220912160157.3642968-2-mpiszczek@ddn.com>", "References": "<20220912160157.3642968-2-mpiszczek@ddn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MW2NAM04FT059:EE_|SA0PR19MB4285:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "8f413ff4-a1b2-4a2b-183d-08dab056941f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 7BoxcDaRzvUJONRM1U7KT5EXyw2JK/aw9zQYZn4xvVbpt2Xr4yBeFnqpnsIxmTJR4MdIMq2rAMMj4mNXpF8e1a7ELjqEbVf+joIdhKLNPsUVe4I8sYs5bCEMeQaSvDp4HU+Rgp4nZownrFTwIWqFiK7L/As+T1zFqVIwfK2dxAGfuqPOZQNY7LIfb6u+JWWUmQxLvAhIc4cYeZ1IRKfIAImB2RpvaeE+kGi3MZIiQFTnsuAkgRp9UwPLgcYVrbuMk2A/4Y+6OcYUhTBPq6fHB5zxW3nrIz/vRozgcz75nrJ9FiA3Xq7qFbIquayr76mqGiXGaXCqUMS6pm6D8z8VsJ6zH7HYyauFb6oPv3gCIeh5CqjJ3u9d3wSg42/+bLPWkEDfQ7dkIQ8AoP4UKa3OpR1VL0UDRD12JTiZo/FfkTcQLrJSDyqpiftOuEXJH2mA4nIzmTqVXeolOk9lCwtFaY7axFjKkPbl7T2xMH0oUx30AMjikpvZ40eBWc+WkNQT50LlCYHUyggZmIYPrWMlmFgua3RbS8Fp8WwYgh1yHoKQemSuZQdhum14YjTOLeWSNcdsnzU2sy9XxPc7efdzZNFtJUtuGKoffHUJeg9fxxY8XNs2kqDzLut3P6FNJQVXH7cB4flpL3Kv8glA8RqzY0BRGYiBHsF6v2DSXNB2pCUJ5VLRXjh4ziA/vtt7o9PP8/ej3B4R9Fhz0QkBRQpqX3cJ4k3jHyTbhKxuBKvDCSj00GNARH3cq1o+iRkgjzQFDqTWpoB0XAmdHJoQAIsROw==", "X-Forefront-Antispam-Report": "CIP:50.222.100.11; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:uww-mx01.datadirectnet.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230022)(4636009)(39850400004)(136003)(346002)(376002)(396003)(451199015)(46966006)(36840700001)(36756003)(36860700001)(86362001)(5660300002)(2906002)(82740400003)(336012)(1076003)(186003)(47076005)(2616005)(81166007)(356005)(83380400001)(6266002)(26005)(316002)(478600001)(6916009)(70586007)(70206006)(82310400005)(40480700001)(41300700001)(4326008)(8936002)(6666004)(8676002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ddn.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Oct 2022 15:45:12.4307 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8f413ff4-a1b2-4a2b-183d-08dab056941f", "X-MS-Exchange-CrossTenant-Id": "753b6e26-6fd3-43e6-8248-3f1735d59bb4", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=753b6e26-6fd3-43e6-8248-3f1735d59bb4; Ip=[50.222.100.11];\n Helo=[uww-mx01.datadirectnet.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MW2NAM04FT059.eop-NAM04.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA0PR19MB4285", "X-Mailman-Approved-At": "Mon, 24 Oct 2022 17:33:01 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add code to read the virtual address width for AMD processors.\nUpdated pci_device_iommu_support_va() to use glob to find iommu\ncapability files.\n\nSigned-off-by: Michael Piszczek <mpiszczek@ddn.com>\n---\n drivers/bus/pci/linux/pci.c | 58 ++++++++++++++++++++++---------------\n 1 file changed, 35 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex ebd1395502..291090ba7b 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -4,6 +4,7 @@\n \n #include <string.h>\n #include <dirent.h>\n+#include <glob.h>\n \n #include <rte_log.h>\n #include <rte_pci.h>\n@@ -480,42 +481,53 @@ rte_pci_scan(void)\n }\n \n #if defined(RTE_ARCH_X86)\n+\n bool\n pci_device_iommu_support_va(const struct rte_pci_device *dev)\n {\n-#define VTD_CAP_MGAW_SHIFT\t16\n-#define VTD_CAP_MGAW_MASK\t(0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define VTD_CAP_MGAW_SHIFT 16\n+#define VTD_CAP_MGAW_MASK (0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define RD_AMD_CAP_VASIZE_SHIFT 15\n+#define RD_AMD_CAP_VASIZE_MASK (0x7F << RD_AMD_CAP_VASIZE_SHIFT)\n+\tint rc;\n \tconst struct rte_pci_addr *addr = &dev->addr;\n-\tchar filename[PATH_MAX];\n-\tFILE *fp;\n-\tuint64_t mgaw, vtd_cap_reg = 0;\n+\tchar pattern[PATH_MAX];\n+\tglob_t glob_results;\n+\tuint64_t mgaw = 0;\n \n-\tsnprintf(filename, sizeof(filename),\n-\t\t \"%s/\" PCI_PRI_FMT \"/iommu/intel-iommu/cap\",\n+\tsnprintf(pattern, sizeof(pattern),\n+\t\t \"%s/\" PCI_PRI_FMT \"/iommu/*-iommu/cap\",\n \t\t rte_pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid,\n \t\t addr->function);\n \n-\tfp = fopen(filename, \"r\");\n-\tif (fp == NULL) {\n-\t\t/* We don't have an Intel IOMMU, assume VA supported */\n-\t\tif (errno == ENOENT)\n-\t\t\treturn true;\n+\trc = glob(pattern, 0, NULL, &glob_results);\n+\tif (rc != 0 && glob_results.gl_pathc == 1) {\n+\t\tconst char *filename = glob_results.gl_pathv[0];\n+\t\tFILE *fp = fopen(filename, \"r\");\n \n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't open %s: %s\\n\",\n-\t\t\t__func__, filename, strerror(errno));\n-\t\treturn false;\n-\t}\n+\t\tif (fp != NULL) {\n+\t\t\tuint64_t cap_reg = 0;\n \n-\t/* We have an Intel IOMMU */\n-\tif (fscanf(fp, \"%\" PRIx64, &vtd_cap_reg) != 1) {\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n-\t\tfclose(fp);\n-\t\treturn false;\n+\t\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\t}\n+\t\t\telse if (strstr(filename, \"intel-iommu\") != NULL) {\n+\t\t\t\t/* We have an Intel IOMMU */\n+\t\t\t\tmgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\t\t\t}\n+\t\t\telse if (strstr(filename, \"amd-iommu\") != NULL) {\n+\t\t\t\t/* We have an Amd IOMMU */\n+\t\t\t\tmgaw = ((cap_reg & RD_AMD_CAP_VASIZE_MASK) >> RD_AMD_CAP_VASIZE_SHIFT) + 1;\n+\t\t\t}\n+\n+\t\t\tfclose(fp);\n+\t\t}\n \t}\n \n-\tfclose(fp);\n+\tglobfree(&glob_results);\n \n-\tmgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\tif (mgaw == 0)\n+\t\treturn false;\n \n \t/*\n \t * Assuming there is no limitation by now. We can not know at this point\n", "prefixes": [ "v6" ] }