Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119032/?format=api
{ "id": 119032, "url": "http://patches.dpdk.org/api/patches/119032/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221013181602.873166-1-mpiszczek@ddn.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221013181602.873166-1-mpiszczek@ddn.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221013181602.873166-1-mpiszczek@ddn.com", "date": "2022-10-13T18:16:01", "name": "[v5] pci: read amd iommu virtual address width", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "90709e6811716a16ae15b5d2f9ac7380a49117eb", "submitter": { "id": 2840, "url": "http://patches.dpdk.org/api/people/2840/?format=api", "name": "Michael Piszczek", "email": "mpiszczek@ddn.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221013181602.873166-1-mpiszczek@ddn.com/mbox/", "series": [ { "id": 25389, "url": "http://patches.dpdk.org/api/series/25389/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25389", "date": "2022-10-13T18:16:01", "name": "[v5] pci: read amd iommu virtual address width", "version": 5, "mbox": "http://patches.dpdk.org/series/25389/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/119032/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/119032/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD60CA0542;\n\tMon, 24 Oct 2022 17:33:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 691CD42BBB;\n\tMon, 24 Oct 2022 17:33:03 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2076.outbound.protection.outlook.com [40.107.93.76])\n by mails.dpdk.org (Postfix) with ESMTP id 0E4D540041\n for <dev@dpdk.org>; Thu, 13 Oct 2022 20:16:09 +0200 (CEST)", "from DS7PR05CA0037.namprd05.prod.outlook.com (2603:10b6:8:2f::24) by\n DM4PR19MB6438.namprd19.prod.outlook.com (2603:10b6:8:a3::8) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5709.19; Thu, 13 Oct 2022 18:16:05 +0000", "from DM6NAM04FT050.eop-NAM04.prod.protection.outlook.com\n (2603:10b6:8:2f:cafe::c2) by DS7PR05CA0037.outlook.office365.com\n (2603:10b6:8:2f::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.6 via Frontend\n Transport; Thu, 13 Oct 2022 18:16:05 +0000", "from uww-mx01.datadirectnet.com (50.222.100.11) by\n DM6NAM04FT050.mail.protection.outlook.com (10.13.159.146) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5723.20 via Frontend Transport; Thu, 13 Oct 2022 18:16:05 +0000", "from localhost (unknown [10.68.0.8])\n by uww-mx01.datadirectnet.com (Postfix) with ESMTP id B863220C685C;\n Thu, 13 Oct 2022 12:17:15 -0600 (MDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Cxy9Do8HG3J1CJZOFPAGISM8xk4Mp96DYBV2X43VYt0qU/F6rScmutNphrORRt54H1fMd92RVxjC2NCkzJ4KiREbAfKhTpxhjGSV1spwK01EpRw1nIALwvAU+W8B0TE4rn3uKpRKwjEn0ysyqD+fLzMVGfwM9/nassoqcmw7N9QtpjGLT4UYqN1Dg3ksPDW/k4ueq7wLId0Mr7jZm8Py2dHEC9z5ZJZ1hXSA1guVmQRCX0k9LFbcToRtNQITEiPP/uA8OXWFkoIm0I54F0ok9+pFh9GjJMOzYLBIl/khK0I8ADAnoIpRIJExNuvBAMNybdP8k3yxEJ5chwQ2nai8gQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=P/QgIsfJNQJZWj7D2U65f+unczDVrzhgcShhpM2IABk=;\n b=Ck8lUjTcL/E6MxJgo6KkdGUPb8+HAIVwAM3Ik20CIZ0CQp5vQ9+mwgPxC4ljpzZIcApwQvXWo/fivwsoASshNMW3eltqjFzM4XFsFLlGVSrOKjHMYFMwM3rAn+HRuwGduhMa+m3gbdQjh2wxwXUABLzOG4Y6WqOLwnSuNi4ZZGSGdjCRZmvY+7ETHTlEyb+ZRh4Zs2oNQ2OLQWsfXvaGRKXOefR2on9iak9D4vadkPOwwM5df7OzdWX+MeUU7jdR9FxQVFmyS+TpAEMBlptmWVNnhGBF96KmNc46HHUfrwX8Z5DwXbDyu/Mk6sfGY3vtswhhkHCkuHH7Y8sed/1yYg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 50.222.100.11) smtp.rcpttodomain=amd.com smtp.mailfrom=ddn.com; dmarc=pass\n (p=reject sp=none pct=100) action=none header.from=ddn.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ddn.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=P/QgIsfJNQJZWj7D2U65f+unczDVrzhgcShhpM2IABk=;\n b=nl+rAquoXK2FkEEJk+P4eLYLEKIWril0SP5QtSGbx/RK7cqNe5F7I+8fd9vdmCxyjQHvVitHmLnVYyi+c9MD47KoCgxdTmphYAVaLocqFYGGMXZrWQyK3pnFfyEyfEobDnEkTq5OIJmYIAC2xfCGxFBh4YHy0/6SUrgFoFbgdxo=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 50.222.100.11)\n smtp.mailfrom=ddn.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ddn.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ddn.com designates\n 50.222.100.11 as permitted sender) receiver=protection.outlook.com;\n client-ip=50.222.100.11; helo=uww-mx01.datadirectnet.com; pr=C", "From": "Michael Piszczek <mpiszczek@ddn.com>", "To": "dev@dpdk.org", "Cc": "Vipin.Varghese@amd.com,\n\tMichael Piszczek <mpiszczek@ddn.com>", "Subject": "[PATCH v5] pci: read amd iommu virtual address width", "Date": "Thu, 13 Oct 2022 20:16:01 +0200", "Message-Id": "<20221013181602.873166-1-mpiszczek@ddn.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220912160157.3642968-2-mpiszczek@ddn.com>", "References": "<20220912160157.3642968-2-mpiszczek@ddn.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM04FT050:EE_|DM4PR19MB6438:EE_", "Content-Type": "text/plain", "X-MS-Office365-Filtering-Correlation-Id": "8fa856aa-7b9f-4686-a2e6-08daad46fe8f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n SmF6/m9H9FeRtLLfNsHV/ctqzgkXnB+eoszzviSIYCb8+9A+LnIf+UCya8unEFOgGZY5zUQbbX8m4uel+HxtKWgPYOCxN1e9C6JWD7G4H1r0Pf6NohhpIZXGw295TK0Ys1Kh/0YVaz9t3jA0tVojAp7D28RsyRdngtgKov7LgbAoDTljj0p/sg/IW6/lPU9FFd7sQoqykGok/1+TBznau4dGbAS+l6AWF5GJvoVg0kSv9mnleru2SM8z6RCfBTLrpX/Zm5igFvwMg22RCjvdLj65+RbU+CMPEotEHklB0fRVpinQ2h0IwoKaoLfsD10XZcjlPOFa0mSntjF5BFo+XqUHD9SprNo/aFPCUqSQfYp2z41AYOEhZxUZ917WmUPRjKIlMnrSwHP1q7l9fJINS6IK7nnaqFzwO6J7FOIC6vJTkNRQ08xz1bC/C8SbZgdPj+Lb6ZLtgG1xnUBTFblmo8PKISxaW9DbSiBD7EsfO088AmWiL7LXcP7FdOzNl8c3jICcJzwOmQvbzDYwWX5c+rIhkhvpgUTHjaUclakixt/ojnPEbOzGDro+G2hK/KkglvHF7IHc7vnjrE21+jFsaDT/yXM8csNaNLMS5mrD9OM3kmeh+iC3FYTbeHzG5OVbRIwmGMrFRqihKpzs2olSPTrfiG+sZtgFJFXAs6QoDggK+9VY3UN7whzSA0ri29GcJFAkk7nfGEGcrYS8IVCfeejFcfEAqNypHGmL397KUuAvjPyo/OJCGIqBz7UX/GNU8LLDghBQEcp5h0Fp/fr0Yw==", "X-Forefront-Antispam-Report": "CIP:50.222.100.11; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:uww-mx01.datadirectnet.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230022)(4636009)(39850400004)(136003)(346002)(376002)(396003)(451199015)(36840700001)(46966006)(36860700001)(36756003)(82740400003)(356005)(6666004)(81166007)(86362001)(316002)(40480700001)(478600001)(8676002)(6266002)(26005)(83380400001)(70206006)(70586007)(2906002)(5660300002)(82310400005)(41300700001)(6916009)(1076003)(336012)(47076005)(8936002)(186003)(4326008)(2616005)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ddn.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "13 Oct 2022 18:16:05.5707 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8fa856aa-7b9f-4686-a2e6-08daad46fe8f", "X-MS-Exchange-CrossTenant-Id": "753b6e26-6fd3-43e6-8248-3f1735d59bb4", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=753b6e26-6fd3-43e6-8248-3f1735d59bb4; Ip=[50.222.100.11];\n Helo=[uww-mx01.datadirectnet.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM04FT050.eop-NAM04.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR19MB6438", "X-Mailman-Approved-At": "Mon, 24 Oct 2022 17:33:01 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add code to read the virtual address width for AMD processors.\nUpdated pci_device_iommu_support_va() to use glob to find iommu\ncapability files.\n\nSigned-off-by: Michael Piszczek <mpiszczek@ddn.com>\n---\n drivers/bus/pci/linux/pci.c | 58 ++++++++++++++++++++++---------------\n 1 file changed, 35 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex ebd1395502..291090ba7b 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -4,6 +4,7 @@\n \n #include <string.h>\n #include <dirent.h>\n+#include <glob.h>\n \n #include <rte_log.h>\n #include <rte_pci.h>\n@@ -480,42 +481,53 @@ rte_pci_scan(void)\n }\n \n #if defined(RTE_ARCH_X86)\n+\n bool\n pci_device_iommu_support_va(const struct rte_pci_device *dev)\n {\n-#define VTD_CAP_MGAW_SHIFT\t16\n-#define VTD_CAP_MGAW_MASK\t(0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define VTD_CAP_MGAW_SHIFT 16\n+#define VTD_CAP_MGAW_MASK (0x3fULL << VTD_CAP_MGAW_SHIFT)\n+#define RD_AMD_CAP_VASIZE_SHIFT 15\n+#define RD_AMD_CAP_VASIZE_MASK (0x7F << RD_AMD_CAP_VASIZE_SHIFT)\n+\tint rc;\n \tconst struct rte_pci_addr *addr = &dev->addr;\n-\tchar filename[PATH_MAX];\n-\tFILE *fp;\n-\tuint64_t mgaw, vtd_cap_reg = 0;\n+\tchar pattern[PATH_MAX];\n+\tglob_t glob_results;\n+\tuint64_t mgaw = 0;\n \n-\tsnprintf(filename, sizeof(filename),\n-\t\t \"%s/\" PCI_PRI_FMT \"/iommu/intel-iommu/cap\",\n+\tsnprintf(pattern, sizeof(pattern),\n+\t\t \"%s/\" PCI_PRI_FMT \"/iommu/*-iommu/cap\",\n \t\t rte_pci_get_sysfs_path(), addr->domain, addr->bus, addr->devid,\n \t\t addr->function);\n \n-\tfp = fopen(filename, \"r\");\n-\tif (fp == NULL) {\n-\t\t/* We don't have an Intel IOMMU, assume VA supported */\n-\t\tif (errno == ENOENT)\n-\t\t\treturn true;\n+\trc = glob(pattern, 0, NULL, &glob_results);\n+\tif (rc != 0 && glob_results.gl_pathc == 1) {\n+\t\tconst char *filename = glob_results.gl_pathv[0];\n+\t\tFILE *fp = fopen(filename, \"r\");\n \n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't open %s: %s\\n\",\n-\t\t\t__func__, filename, strerror(errno));\n-\t\treturn false;\n-\t}\n+\t\tif (fp != NULL) {\n+\t\t\tuint64_t cap_reg = 0;\n \n-\t/* We have an Intel IOMMU */\n-\tif (fscanf(fp, \"%\" PRIx64, &vtd_cap_reg) != 1) {\n-\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n-\t\tfclose(fp);\n-\t\treturn false;\n+\t\t\tif (fscanf(fp, \"%\" PRIx64, &cap_reg) != 1) {\n+\t\t\t\tRTE_LOG(ERR, EAL, \"%s(): can't read %s\\n\", __func__, filename);\n+\t\t\t}\n+\t\t\telse if (strstr(filename, \"intel-iommu\") != NULL) {\n+\t\t\t\t/* We have an Intel IOMMU */\n+\t\t\t\tmgaw = ((cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\t\t\t}\n+\t\t\telse if (strstr(filename, \"amd-iommu\") != NULL) {\n+\t\t\t\t/* We have an Amd IOMMU */\n+\t\t\t\tmgaw = ((cap_reg & RD_AMD_CAP_VASIZE_MASK) >> RD_AMD_CAP_VASIZE_SHIFT) + 1;\n+\t\t\t}\n+\n+\t\t\tfclose(fp);\n+\t\t}\n \t}\n \n-\tfclose(fp);\n+\tglobfree(&glob_results);\n \n-\tmgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n+\tif (mgaw == 0)\n+\t\treturn false;\n \n \t/*\n \t * Assuming there is no limitation by now. We can not know at this point\n", "prefixes": [ "v5" ] }