Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118975/?format=api
{ "id": 118975, "url": "http://patches.dpdk.org/api/patches/118975/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221024031403.1572010-1-spiked@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221024031403.1572010-1-spiked@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221024031403.1572010-1-spiked@nvidia.com", "date": "2022-10-24T03:14:03", "name": "app/testpmd: fix testpmd crash when quit with mlx5 avail_thresh enabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "77df2bb2d22d1552c9dc1f4516878c70928b43bf", "submitter": { "id": 2637, "url": "http://patches.dpdk.org/api/people/2637/?format=api", "name": "Spike Du", "email": "spiked@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221024031403.1572010-1-spiked@nvidia.com/mbox/", "series": [ { "id": 25375, "url": "http://patches.dpdk.org/api/series/25375/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25375", "date": "2022-10-24T03:14:03", "name": "app/testpmd: fix testpmd crash when quit with mlx5 avail_thresh enabled", "version": 1, "mbox": "http://patches.dpdk.org/series/25375/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/118975/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/118975/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1AC99A00C5;\n\tMon, 24 Oct 2022 05:14:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE29F40A89;\n\tMon, 24 Oct 2022 05:14:27 +0200 (CEST)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam04on2088.outbound.protection.outlook.com [40.107.101.88])\n by mails.dpdk.org (Postfix) with ESMTP id 6B30140A7E\n for <dev@dpdk.org>; Mon, 24 Oct 2022 05:14:26 +0200 (CEST)", "from DM6PR11CA0059.namprd11.prod.outlook.com (2603:10b6:5:14c::36)\n by SJ0PR12MB6781.namprd12.prod.outlook.com (2603:10b6:a03:44b::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Mon, 24 Oct\n 2022 03:14:24 +0000", "from DM6NAM11FT099.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:14c:cafe::51) by DM6PR11CA0059.outlook.office365.com\n (2603:10b6:5:14c::36) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35 via Frontend\n Transport; Mon, 24 Oct 2022 03:14:24 +0000", "from mail.nvidia.com (216.228.117.160) by\n DM6NAM11FT099.mail.protection.outlook.com (10.13.172.241) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 03:14:23 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Sun, 23 Oct\n 2022 20:14:23 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Sun, 23 Oct\n 2022 20:14:20 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FhJ/mPeKw+YuaaVcf66mVeWp20OizcZFeiXCdNJPJIR/f3Gcbmh3Dxljw8Fn6wscgCT3Ug6NZwCFj57I9Yq7VSnz31w0fKeMKG1mC7vDEsW1cS4Xe0DH+nORBcW/MJeVxHzzLD3gpMaWibzA/BdPZTKiEGHp5WAckrYDQDtx2iR9I9TiwCrRUJ2VIUEh6Ky85HHU3c1g1UKvsLopdiKMvhpOW5kso+Rg0Euk/F1TQ+8dH59IveKGkhiNWvvTT9KsONQAReCrONriRvSr6VMWutwhl45rRhPI67o1Sxz/Xao70v6VwEo5yJ244v360alDiKlNzIQcpLPueCE48eicng==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ApfbAnsw7mNNkg6iMwqtL+v2erl1PP4j1BLSj+BqPm8=;\n b=moAetvw4Pvo5Xqqg2LFIFBuGtozSszsnUTKr9Tb/24bLWM1yJXfpQajwLqAZEE1HhTfEt0oPmbwUdKrjFB0eWc0wqX7HeSSUGQO4XtcXN53njSezVMHagY5gCOVlX3Nj+ZM6kRhdHEUFOH5kkr0LfEaHvkLni6SeJv9kqKuCPWHhFVli3bJCBKuePtIODEEPxJFhudz/pkib6qGD0xNMyhPIwK5e2Sc+uzjHF0ayqCCt/9n3E+EphKyw2z9u292lxXrigux6+pBtTtf2LzDyAdztFLVjYDqKaW76HcmpwXmg8XP1SR5NU8P3oWHUnBi2uVKkepLJwMba3kIMe3PEaA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ApfbAnsw7mNNkg6iMwqtL+v2erl1PP4j1BLSj+BqPm8=;\n b=QmzqdYfmSVY8958TVlPxaqtlTFD71cfLbb+DYbR/I3zqRPW0njxVs4ARmrHPGqk+/ArhNgxEemYYAbAHADFSLOScdg0ZJU5IspM4mixSZbTwh1M1BR7bZnO4zkLyHrT0yFBMGtkompV8QizqY+MUl9zELbYJ6svadY2QIoyGB6YsxCOmmCVb/8DE/zPMT6SrJio6l3d5T/xYBM2Egh1tNwSOtN6uVK4VkJmBXqS9MbPqLKZfoCGWKhGISt8K+oY70Og+JXu3VXtWr989ZYpH47A0FUk9bv3lxzA5d2bWUxlMXz+oy9rNad/qCbhM9lsRmBzI5FEZHlJEyR66UA4n6Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Spike Du <spiked@nvidia.com>", "To": "<matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,\n <thomas@monjalon.net>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>", "Subject": "[PATCH] app/testpmd: fix testpmd crash when quit with mlx5\n avail_thresh enabled", "Date": "Mon, 24 Oct 2022 06:14:03 +0300", "Message-ID": "<20221024031403.1572010-1-spiked@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT099:EE_|SJ0PR12MB6781:EE_", "X-MS-Office365-Filtering-Correlation-Id": "f172dc0f-f95f-4fe2-be21-08dab56dda01", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 0w1Zs38p86aOKAKDtioiB27IlxlrdINdFSPn3hrVFp4TryL/+yAAwuOyb8RpKdR+UQ3BTwgN8mvr7c8KygWsb9z2Z+2PCo6v+Vvfp1l/MnhRA5dUH/U56vtcg2xfDcYTWycc9DdbLi8tEFTR+W0s34E1T16JIDPsJ3skwTTx1Eo2qB6fsi4jVZObPfYKp0Dv0fKEgfq/BN5MzrPJFqT/yuaFHbW938Dc16j5kBMhVaAPWq5SvjlLH18z/TodjkZcNI3TOuby46/JUfy0TBCmWyywwVtpkTa7MbEKB7wLPYM71eag59i9IK1qAZoknNhns2Jv/bmjgZqccjI1NB+YS//5xKWWT2qJuM2TuBNfD1dvs99oNinWsaWZzQRVMSI22EuvtOsX52XH0hSYS0cB3S/DO8QTxaQvLzRGn/y8v6aTC0nPM/V9xShQXGOMTKOTCY8dJAb0chyfPALDD0FhTHRJ72Ra50M5b2hn8MxvS6XvHZ1qflDAztbxyABSaRr8ii8UNK47s+4ty+KLKFpA8PxQxCuv5WoSp0JYwestZl9Abtmv7lvfR8zHBGSS1VFPN2SyUDJgKZv8hurPfWhnXJC7XPZmf9wE/FWNVryHCj1wIMsxa/qbARFtnUuXnW153Af5AVYsFKS3jJtjYXU3I5NszyEtDvf4r80uzFSgJYkbzfO9V1XKLJhpkTCQDh89E3fKaZdRJA3YmXzdEnji1zaqYRq0/Xewr0Syb1qufA3aKf4kPWO/1A7JvU4NZbs2P+yyXVYbakHFO+tzYc1tQg==", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(451199015)(36840700001)(46966006)(40470700004)(7636003)(356005)(478600001)(82310400005)(82740400003)(36756003)(54906003)(47076005)(426003)(8936002)(40480700001)(55016003)(6666004)(107886003)(110136005)(36860700001)(316002)(6286002)(26005)(41300700001)(86362001)(336012)(70586007)(2616005)(16526019)(1076003)(40460700003)(186003)(2906002)(5660300002)(7696005)(4326008)(8676002)(70206006);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Oct 2022 03:14:23.8237 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n f172dc0f-f95f-4fe2-be21-08dab56dda01", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT099.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR12MB6781", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler\ndelays to reconfigure rx queue to re-arm this event. However at the same\ntime, testpmd is destroying rx queues.\nIt's never a valid use case for mlx5 avail_thresh. Before testpmd quit,\nuser should disable avail_thresh configuration to not handle the events.\nThis is documented in mlx5 driver guide.\n\nTo avoid the crash in such use case, check port status, if it is not\nRTE_PORT_STARTED, don't process the avail_thresh event.\n\nFixes: 0edfc9b08316 (\"app/testpmd: add Host Shaper command\")\n\nSigned-off-by: Spike Du <spiked@nvidia.com>\n---\n drivers/net/mlx5/mlx5_testpmd.c | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_testpmd.c b/drivers/net/mlx5/mlx5_testpmd.c\nindex ed84583..1a9ec78 100644\n--- a/drivers/net/mlx5/mlx5_testpmd.c\n+++ b/drivers/net/mlx5/mlx5_testpmd.c\n@@ -25,6 +25,7 @@\n \n static uint8_t host_shaper_avail_thresh_triggered[RTE_MAX_ETHPORTS];\n #define SHAPER_DISABLE_DELAY_US 100000 /* 100ms */\n+extern struct rte_port *ports;\n \n /**\n * Disable the host shaper and re-arm available descriptor threshold event.\n@@ -39,7 +40,15 @@\n \tuint16_t port_id = port_rxq_id & 0xffff;\n \tuint16_t qid = (port_rxq_id >> 16) & 0xffff;\n \tstruct rte_eth_rxq_info qinfo;\n+\tstruct rte_port *port;\n \n+\tport = &ports[port_id];\n+\tif (port->port_status != RTE_PORT_STARTED) {\n+\t\tprintf(\"%s port_status(%d) is incorrect, stop avail_thresh \"\n+\t\t \"event processing.\\n\",\n+\t\t __func__, port->port_status);\n+\t\treturn;\n+\t}\n \tprintf(\"%s disable shaper\\n\", __func__);\n \tif (rte_eth_rx_queue_info_get(port_id, qid, &qinfo)) {\n \t\tprintf(\"rx_queue_info_get returns error\\n\");\n", "prefixes": [] }