Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118834/?format=api
{ "id": 118834, "url": "http://patches.dpdk.org/api/patches/118834/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221020175040.4100014-1-abdullah.sevincer@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221020175040.4100014-1-abdullah.sevincer@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221020175040.4100014-1-abdullah.sevincer@intel.com", "date": "2022-10-20T17:50:40", "name": "[v4] event/dlb2: fix port COS range allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "238a8b3e4e06e2d178de4a70af9e346aabfb330a", "submitter": { "id": 2843, "url": "http://patches.dpdk.org/api/people/2843/?format=api", "name": "Sevincer, Abdullah", "email": "abdullah.sevincer@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221020175040.4100014-1-abdullah.sevincer@intel.com/mbox/", "series": [ { "id": 25350, "url": "http://patches.dpdk.org/api/series/25350/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25350", "date": "2022-10-20T17:50:40", "name": "[v4] event/dlb2: fix port COS range allocation", "version": 4, "mbox": "http://patches.dpdk.org/series/25350/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/118834/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/118834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48BA6A0553;\n\tThu, 20 Oct 2022 19:50:47 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB4F8410FC;\n\tThu, 20 Oct 2022 19:50:46 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id D9B0F40FAE;\n Thu, 20 Oct 2022 19:50:44 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Oct 2022 10:50:43 -0700", "from txanpdk02.an.intel.com ([10.123.117.76])\n by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2022 10:50:42 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666288245; x=1697824245;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=2rcRJiznIHgrpH8FeS8NIG3kTlROgbCMYK8kQdwdQ6c=;\n b=VUgbjAaKz6h3CxZjd7HHH5QS6oDcNEXmYyjpkEn7zNEYu02D+rJ/5h0B\n vuXdETEAk8oGHGCn4f2ji5XHf4DK8GBVKs1EI6LPJP40GrV5UVdLWnXS5\n tNEsJejBduMM9tAB/rlcImszJ5nSTiB5xdMgzLVY45TkQm02fBDR8weER\n i3h41m6lcxyojGyS2mq9US8+ytz5aXQnsSvcRnbw5A+xR/kRZ8s/OjLiI\n IyXGEPdSwSZ+H9I0gX5PPnN4JIp6YboeOlNN8UB52qBBCRpzPmiZ2jmK0\n tmLFIkRz1tJBqYgV/s8CS3YHgs8RzN6Ts4Hz8T0xHi4/uIs5x2Hio/5fu A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10506\"; a=\"371002427\"", "E=Sophos;i=\"5.95,199,1661842800\"; d=\"scan'208\";a=\"371002427\"", "E=McAfee;i=\"6500,9779,10506\"; a=\"698815435\"", "E=Sophos;i=\"5.95,199,1661842800\"; d=\"scan'208\";a=\"698815435\"" ], "X-ExtLoop1": "1", "From": "Abdullah Sevincer <abdullah.sevincer@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com, Abdullah Sevincer <abdullah.sevincer@intel.com>,\n stable@dpdk.org", "Subject": "[PATCH v4] event/dlb2: fix port COS range allocation", "Date": "Thu, 20 Oct 2022 12:50:40 -0500", "Message-Id": "<20221020175040.4100014-1-abdullah.sevincer@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221019194734.4009186-1-abdullah.sevincer@intel.com>", "References": "<20221019194734.4009186-1-abdullah.sevincer@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit fixes allocation of port COS\nwhen application requested port COS exceeds\n(e.g. beyond 0-15) the number of LDB ports for\nthe domain.\n\nWe limit application specified ports from a\nCOS to the max ports allocated for the COS\nso that the rest of the of the ports can be\nallocated from default(best) COS.\n\nFixes: bec8901bfe9f (\"event/dlb2: support ldb port specific COS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>\n---\n drivers/event/dlb2/dlb2.c | 9 ++++++---\n drivers/event/dlb2/dlb2_priv.h | 2 ++\n 2 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c\nindex 02f0e57208..60c5cd4804 100644\n--- a/drivers/event/dlb2/dlb2.c\n+++ b/drivers/event/dlb2/dlb2.c\n@@ -182,8 +182,10 @@ dlb2_init_port_cos(struct dlb2_eventdev *dlb2, int *port_cos)\n \n \tfor (q = 0; q < DLB2_MAX_NUM_PORTS_ALL; q++) {\n \t\tdlb2->ev_ports[q].cos_id = port_cos[q];\n-\t\tif (port_cos[q] != DLB2_COS_DEFAULT) {\n+\t\tif (port_cos[q] != DLB2_COS_DEFAULT &&\n+\t\t dlb2->cos_ports[port_cos[q]] < DLB2_MAX_NUM_LDB_PORTS_PER_COS) {\n \t\t\tdlb2->cos_ports[port_cos[q]]++;\n+\t\t\tdlb2->max_cos_port = q;\n \t\t}\n \t}\n }\n@@ -841,8 +843,9 @@ dlb2_hw_create_sched_domain(struct dlb2_eventdev *dlb2,\n \tcos_ports = dlb2->cos_ports[0] + dlb2->cos_ports[1] +\n \t\t dlb2->cos_ports[2] + dlb2->cos_ports[3];\n \n-\tif (cos_ports > resources_asked->num_ldb_ports) {\n-\t\tDLB2_LOG_ERR(\"dlb2: num_ldb_ports < nonzero cos_ports\\n\");\n+\tif (cos_ports > resources_asked->num_ldb_ports ||\n+\t (cos_ports && dlb2->max_cos_port >= resources_asked->num_ldb_ports)) {\n+\t\tDLB2_LOG_ERR(\"dlb2: num_ldb_ports < cos_ports\\n\");\n \t\tret = EINVAL;\n \t\tgoto error_exit;\n \t}\ndiff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h\nindex ac20c5a179..f4b9e7f9ff 100644\n--- a/drivers/event/dlb2/dlb2_priv.h\n+++ b/drivers/event/dlb2/dlb2_priv.h\n@@ -92,6 +92,7 @@\n #define DLB2_NUM_SN_GROUPS 2\n #define DLB2_MAX_LDB_SN_ALLOC 1024\n #define DLB2_MAX_QUEUE_DEPTH_THRESHOLD 8191\n+#define DLB2_MAX_NUM_LDB_PORTS_PER_COS (DLB2_MAX_NUM_LDB_PORTS/DLB2_COS_NUM_VALS)\n \n /* 2048 total hist list entries and 64 total ldb ports, which\n * makes for 2048/64 == 32 hist list entries per port. However, CQ\n@@ -635,6 +636,7 @@ struct dlb2_eventdev {\n \t};\n \tuint32_t cos_ports[DLB2_COS_NUM_VALS]; /* total ldb ports in each class */\n \tuint32_t cos_bw[DLB2_COS_NUM_VALS]; /* bandwidth per cos domain */\n+\tuint8_t max_cos_port; /* Max LDB port from any cos */\n };\n \n /* used for collecting and passing around the dev args */\n", "prefixes": [ "v4" ] }