Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118522/?format=api
{ "id": 118522, "url": "http://patches.dpdk.org/api/patches/118522/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1666168884-104665-11-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1666168884-104665-11-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1666168884-104665-11-git-send-email-andy.pei@intel.com", "date": "2022-10-19T08:41:22", "name": "[v9,10/12] vhost: add type to rte vdpa device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ad408cce269ea5c3b3202e36379764526a5ee913", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1666168884-104665-11-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 25297, "url": "http://patches.dpdk.org/api/series/25297/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25297", "date": "2022-10-19T08:41:12", "name": "vdpa/ifc: add multi queue support", "version": 9, "mbox": "http://patches.dpdk.org/series/25297/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/118522/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/118522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD421A0581;\n\tWed, 19 Oct 2022 11:32:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 62A1142B83;\n\tWed, 19 Oct 2022 11:32:03 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id AA3DD42B76\n for <dev@dpdk.org>; Wed, 19 Oct 2022 11:31:57 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Oct 2022 02:31:57 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.251])\n by fmsmga001.fm.intel.com with ESMTP; 19 Oct 2022 02:31:55 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666171917; x=1697707917;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=fcSXDElms2+7KDr9YjcXui/7J9c9ra3ZARXK96LWNKw=;\n b=j8S4vUvioBKS3hesB84HxLUxqn84rkqFkHB/GTV8+MxN5dfX5HAadjzS\n 9o34lYNfKncpdYyFcweqkgRIMaMa7mBHKARg6k5STQgUhq7/nxmN1Sej8\n /bCsydhKJQmRjRstDeUGnlD/apy6QjuQ7WUEmm1bCFD2hgjY7VKicZ+H+\n Xtu9Dgk8E6r8gA/ZRHj10xuku2ZrsKG0xkdOY/Yjkgmp9NLffJ16Hi3DD\n WmXrn6TUzC+uPZkhCODk4mcqP+rOsx1JJg5IZYW6QEe6NVXV0TF6Bp++m\n KRK/jCqRShEUEwsMpNupM5ydzQkgLKwNlgnJdaVykoQ4/wcpz+xZM/P61 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10504\"; a=\"303976952\"", "E=Sophos;i=\"5.95,195,1661842800\"; d=\"scan'208\";a=\"303976952\"", "E=McAfee;i=\"6500,9779,10504\"; a=\"771691042\"", "E=Sophos;i=\"5.95,195,1661842800\"; d=\"scan'208\";a=\"771691042\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com,\n gang.cao@intel.com, maxime.coquelin@redhat.com", "Subject": "[PATCH v9 10/12] vhost: add type to rte vdpa device", "Date": "Wed, 19 Oct 2022 16:41:22 +0800", "Message-Id": "<1666168884-104665-11-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1666168884-104665-1-git-send-email-andy.pei@intel.com>", "References": "<1661229305-240952-2-git-send-email-andy.pei@intel.com>\n <1666168884-104665-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add type to rte_vdpa_device to store device type.\nCall vdpa ops get_dev_type to fill type when register\nvdpa device.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/socket.c | 15 +--------------\n lib/vhost/vdpa.c | 15 +++++++++++++++\n lib/vhost/vdpa_driver.h | 2 ++\n 3 files changed, 18 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c\nindex 608ae57..863a6f6 100644\n--- a/lib/vhost/socket.c\n+++ b/lib/vhost/socket.c\n@@ -627,7 +627,6 @@ struct rte_vdpa_device *\n {\n \tstruct vhost_user_socket *vsocket;\n \tstruct rte_vdpa_device *vdpa_dev;\n-\tuint32_t vdpa_type = 0;\n \tint ret = 0;\n \n \tpthread_mutex_lock(&vhost_user.mutex);\n@@ -644,19 +643,7 @@ struct rte_vdpa_device *\n \t\tgoto unlock_exit;\n \t}\n \n-\tif (vdpa_dev->ops->get_dev_type) {\n-\t\tret = vdpa_dev->ops->get_dev_type(vdpa_dev, &vdpa_type);\n-\t\tif (ret) {\n-\t\t\tVHOST_LOG_CONFIG(path, ERR,\n-\t\t\t\t\"failed to get vdpa dev type for socket file.\\n\");\n-\t\t\tret = -1;\n-\t\t\tgoto unlock_exit;\n-\t\t}\n-\t} else {\n-\t\tvdpa_type = RTE_VHOST_VDPA_DEVICE_TYPE_NET;\n-\t}\n-\n-\t*type = vdpa_type;\n+\t*type = vdpa_dev->type;\n \n unlock_exit:\n \tpthread_mutex_unlock(&vhost_user.mutex);\ndiff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c\nindex bb82857..577cb00 100644\n--- a/lib/vhost/vdpa.c\n+++ b/lib/vhost/vdpa.c\n@@ -73,6 +73,7 @@ struct rte_vdpa_device *\n \t\tstruct rte_vdpa_dev_ops *ops)\n {\n \tstruct rte_vdpa_device *dev;\n+\tint ret = 0;\n \n \tif (ops == NULL)\n \t\treturn NULL;\n@@ -101,6 +102,20 @@ struct rte_vdpa_device *\n \n \tdev->device = rte_dev;\n \tdev->ops = ops;\n+\n+\tif (ops->get_dev_type) {\n+\t\tret = ops->get_dev_type(dev, &dev->type);\n+\t\tif (ret) {\n+\t\t\tVHOST_LOG_CONFIG(rte_dev->name, ERR,\n+\t\t\t\t\t \"Failed to get vdpa dev type.\\n\");\n+\t\t\tret = -1;\n+\t\t\tgoto out_unlock;\n+\t\t}\n+\t} else {\n+\t\t/** by default, we assume vdpa device is a net device */\n+\t\tdev->type = RTE_VHOST_VDPA_DEVICE_TYPE_NET;\n+\t}\n+\n \tTAILQ_INSERT_TAIL(&vdpa_device_list, dev, next);\n out_unlock:\n \trte_spinlock_unlock(&vdpa_device_list_lock);\ndiff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h\nindex 8b88a53..8db4ab9 100644\n--- a/lib/vhost/vdpa_driver.h\n+++ b/lib/vhost/vdpa_driver.h\n@@ -92,6 +92,8 @@ struct rte_vdpa_device {\n \tstruct rte_device *device;\n \t/** vdpa device operations */\n \tstruct rte_vdpa_dev_ops *ops;\n+\t/** vdpa device type: net, blk... */\n+\tuint32_t type;\n };\n \n /**\n", "prefixes": [ "v9", "10/12" ] }