Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118498/?format=api
{ "id": 118498, "url": "http://patches.dpdk.org/api/patches/118498/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221018194131.23006-32-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221018194131.23006-32-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221018194131.23006-32-andrew.boyer@amd.com", "date": "2022-10-18T19:41:26", "name": "[v2,31/36] net/ionic: add alignment and socket info in allocations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "aff1c0529e05f61edccbf30b1c23cff8ff606859", "submitter": { "id": 2861, "url": "http://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221018194131.23006-32-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25088, "url": "http://patches.dpdk.org/api/series/25088/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25088", "date": "2022-10-11T00:49:57", "name": "net/ionic: updates for 22.11 release", "version": 1, "mbox": "http://patches.dpdk.org/series/25088/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/118498/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/118498/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7885AA0560;\n\tTue, 18 Oct 2022 21:47:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1C41142B7E;\n\tTue, 18 Oct 2022 21:47:26 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66])\n by mails.dpdk.org (Postfix) with ESMTP id 1AAA74284D\n for <dev@dpdk.org>; Tue, 18 Oct 2022 21:47:25 +0200 (CEST)", "from DS7PR05CA0087.namprd05.prod.outlook.com (2603:10b6:8:56::9) by\n PH7PR12MB6811.namprd12.prod.outlook.com (2603:10b6:510:1b5::9) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.5723.29; Tue, 18 Oct 2022 19:47:23 +0000", "from DM6NAM11FT115.eop-nam11.prod.protection.outlook.com\n (2603:10b6:8:56:cafe::bb) by DS7PR05CA0087.outlook.office365.com\n (2603:10b6:8:56::9) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.14 via Frontend\n Transport; Tue, 18 Oct 2022 19:47:23 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n DM6NAM11FT115.mail.protection.outlook.com (10.13.173.33) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5746.16 via Frontend Transport; Tue, 18 Oct 2022 19:47:23 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct\n 2022 14:47:22 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=TNVqgMlDvSwmaO+ArXdjdYmj7NYg2Uiq9lvezIQiG+YC+/k7rDwXvgZI7BjQYoqwG0+o2rkE0okcoV/X8xc+eaTkgUVuywjqpdv8uqRBTC8XL014hVSWI4338jeO0fLIx6o+WhnZ6FDvftOJg4k1jButEUwTdKLgvK0A5moOZWCFw325lF88aYAWyvJz+IXFPXI7z00U/dGpJLc6xFlwLmTkqoVu/z/D437II1tgFmtEE5fnjfLTBU4pNVOVrc5XZWno9RN5wwbxkmfw4Y0K68u3EmsN6jO7UalTDVpuqh2AKgBEHtLDwMSfOsJBR0GZbcd3aHX+6CGbYJLLdIWi7g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=U6vYHqv5ZDhhB1KH1ABCDdp9AYPDyvFRdEe4Tpmz8Fg=;\n b=fMtRM7PmZGh3qbbmw3mNHqkPj6nqX2RqKx8qPxFod13LQ1U2uOG693qJ/uUrpu1OD6cFKQrnABlHe63XQDOPwzYP6vRotFbtfnyr4IuMwnz6gAlstB9CLIwrRgcAVy4g0Gen5oHRUSizUmstxqtMqB9g/feQ+6cwqdv/qCidx8YgCbGO7C/XomL8MywqX1pfOaBi+uoLKzbvbt6tSXawRzbPEwz+7xtkleHRDC+6IPa2LnULAuoSGicUTCd7o5Bw5yWrh3/3tnpc5kTNd6Fp0519b++nd1uNBZ5fl3ZJhMsf9X91xiaGzVWjxh/6BNGioeDnfzRw4gCaHIvUsm7V/A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=U6vYHqv5ZDhhB1KH1ABCDdp9AYPDyvFRdEe4Tpmz8Fg=;\n b=xRUWaJxlwxjRxAsFKc1MxU7vdDJf6gXrk9vwFw4qiS4SyJR9d/Ashag6OGE0+Bgx4quaUq0Ch0O2hWuXVTqUOlNnSTM5ZAGcmtv5fyEHs7FoZD5BneiER6vhiaoWPbtGMPFF5JvwkBQpyvcOkF4PYgcw7LNHsNoxKWisape3e4w=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH v2 31/36] net/ionic: add alignment and socket info in\n allocations", "Date": "Tue, 18 Oct 2022 12:41:26 -0700", "Message-ID": "<20221018194131.23006-32-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221011005032.47584-1-andrew.boyer@amd.com>", "References": "<20221011005032.47584-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DM6NAM11FT115:EE_|PH7PR12MB6811:EE_", "X-MS-Office365-Filtering-Correlation-Id": "05e67ac3-1405-46ce-4700-08dab141937f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n gcp//ubpERo1eMeiKwtYrp3ZKdW2608AnrhgMY/PcJcCY2EXVxVZ1aYdHV5z5eI7KdA/8RIV1fd4DDQxFj7TP9nvnDiNBqy5AxgxZ4jlCw5Ovuix6tUxuTR7NKft9xY4plhw4tkmcyjJkz6zMsI5jUb2DFXNqtl3+1O3HbL7XGekNy9y9ZgsMTbFmtwQC6pnJrX6R+AAUTekCdfSS0HlBWOCcznhY9/KhZuvKn118U8qWxKrMnqXXoM6yy04H6TkkXHUz0SiW3Z0oyF7rJ+Q3doYsCmHdBTq34sQU0cZgTNy/EKaJmaYVBdJrJtkyeLSAPolpWDlZtVQr4MCKub1gE73b5JBLNoutmAp1NKE62BkZXz9ZEN59grf3mME1xFZ2xWXkmbhe+dqInEnt4TU/vBbE96LxkQ7yRCL1+TACvF13LDK9dOFSrpAcjz7I/8hKLFJ7QXGtM+euMsulgDrD/rwpB9hWHDNWwTkDWebsn4MBKmW0B78CtRpmxSQ9qf/Zr7oYaXjqlcMOULFnZSQum53rnru5cC/bS9Wk4tGIPiyvj4BXRJMjSZ9Tn3JnSUrZ9GhsthdDGpE9N/BnxVogkaJw4QihJlNALlu6ELLs2XYYzYp9DiCDuecshs02AJOQuK/+7XPSnEZ5OJL8yS4yh0zdcGn7Z0cRVRylUr3s/MxJEGUSWMOiXS2mQaW8RJWbceMyTfEeZcHTJHRw+nK99dFyl2CJGTByg9dKO0xAY7jtV0lKFAQ5oQ4zlpibgTDt10FFshkWPg6uOf18tV30w35Z530pYVWjVKdCnlhy/0LnpiPc7PDm6PhevDeugdD", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(81166007)(356005)(47076005)(426003)(336012)(2616005)(82740400003)(1076003)(16526019)(82310400005)(2906002)(186003)(70586007)(6916009)(44832011)(36756003)(316002)(478600001)(40480700001)(41300700001)(83380400001)(86362001)(26005)(5660300002)(70206006)(36860700001)(40460700003)(4326008)(8676002)(8936002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Oct 2022 19:47:23.1304 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 05e67ac3-1405-46ce-4700-08dab141937f", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT115.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR12MB6811", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This will avoid memory access penalties on NUMA systems.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_ethdev.c | 5 +++--\n drivers/net/ionic/ionic_lif.c | 13 ++++++++-----\n drivers/net/ionic/ionic_rx_filter.c | 3 +--\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex b1d8663329..2f720315c3 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -1005,7 +1005,8 @@ eth_ionic_dev_init(struct rte_eth_dev *eth_dev, void *init_params)\n \t/* Allocate memory for storing MAC addresses */\n \teth_dev->data->mac_addrs = rte_calloc(\"ionic\",\n \t\t\t\t\tadapter->max_mac_addrs,\n-\t\t\t\t\tRTE_ETHER_ADDR_LEN, 0);\n+\t\t\t\t\tRTE_ETHER_ADDR_LEN,\n+\t\t\t\t\tRTE_CACHE_LINE_SIZE);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tIONIC_PRINT(ERR, \"Failed to allocate %u bytes needed to \"\n \t\t\t\"store MAC addresses\",\n@@ -1083,7 +1084,7 @@ eth_ionic_dev_probe(void *bus_dev, struct rte_device *rte_dev,\n \t\tgoto err;\n \t}\n \n-\tadapter = rte_zmalloc(\"ionic\", sizeof(*adapter), 0);\n+\tadapter = rte_zmalloc(\"ionic\", sizeof(*adapter), RTE_CACHE_LINE_SIZE);\n \tif (!adapter) {\n \t\tIONIC_PRINT(ERR, \"OOM\");\n \t\terr = -ENOMEM;\ndiff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 8b10b26266..eeec4860ba 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -598,7 +598,8 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \t\ttotal_size += rte_mem_page_size();\n \t}\n \n-\tnew = rte_zmalloc(\"ionic\", struct_size, 0);\n+\tnew = rte_zmalloc_socket(\"ionic\", struct_size,\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (!new) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate queue structure\");\n \t\treturn -ENOMEM;\n@@ -1037,17 +1038,19 @@ ionic_lif_alloc(struct ionic_lif *lif)\n \t\treturn -ENOMEM;\n \t}\n \n-\tlif->txqcqs = rte_calloc(\"ionic\",\n+\tlif->txqcqs = rte_calloc_socket(\"ionic\",\n \t\t\t\tadapter->max_ntxqs_per_lif,\n-\t\t\t\tsizeof(*lif->txqcqs), 0);\n+\t\t\t\tsizeof(*lif->txqcqs),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (!lif->txqcqs) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate tx queues array\");\n \t\treturn -ENOMEM;\n \t}\n \n-\tlif->rxqcqs = rte_calloc(\"ionic\",\n+\tlif->rxqcqs = rte_calloc_socket(\"ionic\",\n \t\t\t\tadapter->max_nrxqs_per_lif,\n-\t\t\t\tsizeof(*lif->rxqcqs), 0);\n+\t\t\t\tsizeof(*lif->rxqcqs),\n+\t\t\t\tRTE_CACHE_LINE_SIZE, socket_id);\n \tif (!lif->rxqcqs) {\n \t\tIONIC_PRINT(ERR, \"Cannot allocate rx queues array\");\n \t\treturn -ENOMEM;\ndiff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c\nindex bbfc217826..cfcfd2a1ea 100644\n--- a/drivers/net/ionic/ionic_rx_filter.c\n+++ b/drivers/net/ionic/ionic_rx_filter.c\n@@ -55,8 +55,7 @@ ionic_rx_filter_save(struct ionic_lif *lif, uint32_t flow_id,\n \tstruct ionic_rx_filter *f;\n \tuint32_t key;\n \n-\tf = rte_zmalloc(\"ionic\", sizeof(*f), 0);\n-\n+\tf = rte_zmalloc(\"ionic\", sizeof(*f), RTE_CACHE_LINE_SIZE);\n \tif (!f)\n \t\treturn -ENOMEM;\n \n", "prefixes": [ "v2", "31/36" ] }