Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118065/?format=api
{ "id": 118065, "url": "http://patches.dpdk.org/api/patches/118065/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221012123112.2951802-8-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221012123112.2951802-8-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221012123112.2951802-8-david.marchand@redhat.com", "date": "2022-10-12T12:31:10", "name": "[v3,7/9] trace: fix metadata dump", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e3e3fdb02c982384cc4b7cf96a7cb0c288cbfacf", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221012123112.2951802-8-david.marchand@redhat.com/mbox/", "series": [ { "id": 25183, "url": "http://patches.dpdk.org/api/series/25183/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25183", "date": "2022-10-12T12:31:03", "name": "Trace subsystem fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/25183/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/118065/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/118065/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CB62A00C4;\n\tWed, 12 Oct 2022 14:32:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BA5D443073;\n\tWed, 12 Oct 2022 14:31:54 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 26E134306F\n for <dev@dpdk.org>; Wed, 12 Oct 2022 14:31:53 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-569-UQGP_XShMSKhfBonM2QY1Q-1; Wed, 12 Oct 2022 08:31:49 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A5681C08969;\n Wed, 12 Oct 2022 12:31:49 +0000 (UTC)", "from localhost.localdomain (ovpn-193-115.brq.redhat.com\n [10.40.193.115])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 6A9B41111C60;\n Wed, 12 Oct 2022 12:31:48 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1665577912;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=yAnb8nAy0I8jLxTXVVkYpc9Z3EH50hkfLpL1EZ5BU+w=;\n b=i8ApledtC3Uv2ovaF7zUFzvPuDuykfA24PTMETbM0yQBeXNz2dAHPTwZbuqFqNGVS2nr2U\n FeA0jZ1it1FmWAy5jwOM7abGMgqMx/xerEUnrL46Jo/oGpfOigKWyge+KiUkEfVhAyohll\n 0eij7XSqQAMxYbIIgSgmVZGJyDSjQr4=", "X-MC-Unique": "UQGP_XShMSKhfBonM2QY1Q-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com,\n\tskori@marvell.com,\n\tstable@dpdk.org", "Subject": "[PATCH v3 7/9] trace: fix metadata dump", "Date": "Wed, 12 Oct 2022 14:31:10 +0200", "Message-Id": "<20221012123112.2951802-8-david.marchand@redhat.com>", "In-Reply-To": "<20221012123112.2951802-1-david.marchand@redhat.com>", "References": "<20220921120359.2201131-1-david.marchand@redhat.com>\n <20221012123112.2951802-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The API does not describe that metadata dump is conditioned to enabling\nany trace points.\n\nWhile at it, merge dump unit tests into the generic trace_autotest to\nenhance coverage.\n\nFixes: f6b2d65dcd5d (\"trace: implement debug dump\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Sunil Kumar Kori <skori@marvell.com>\n---\n app/test/test_trace.c | 44 +++++++++------------------\n lib/eal/common/eal_common_trace_ctf.c | 3 --\n 2 files changed, 15 insertions(+), 32 deletions(-)", "diff": "diff --git a/app/test/test_trace.c b/app/test/test_trace.c\nindex 2660f52f1d..6bedf14024 100644\n--- a/app/test/test_trace.c\n+++ b/app/test/test_trace.c\n@@ -20,20 +20,6 @@ test_trace(void)\n \treturn TEST_SKIPPED;\n }\n \n-static int\n-test_trace_dump(void)\n-{\n-\tprintf(\"trace_dump not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n-static int\n-test_trace_metadata_dump(void)\n-{\n-\tprintf(\"trace_metadata_dump not supported on Windows, skipping test\\n\");\n-\treturn TEST_SKIPPED;\n-}\n-\n #else\n \n static int32_t\n@@ -214,6 +200,19 @@ test_generic_trace_points(void)\n \treturn TEST_SUCCESS;\n }\n \n+static int\n+test_trace_dump(void)\n+{\n+\trte_trace_dump(stdout);\n+\treturn 0;\n+}\n+\n+static int\n+test_trace_metadata_dump(void)\n+{\n+\treturn rte_trace_metadata_dump(stdout);\n+}\n+\n static struct unit_test_suite trace_tests = {\n \t.suite_name = \"trace autotest\",\n \t.setup = NULL,\n@@ -226,6 +225,8 @@ static struct unit_test_suite trace_tests = {\n \t\tTEST_CASE(test_trace_point_globbing),\n \t\tTEST_CASE(test_trace_point_regex),\n \t\tTEST_CASE(test_trace_points_lookup),\n+\t\tTEST_CASE(test_trace_dump),\n+\t\tTEST_CASE(test_trace_metadata_dump),\n \t\tTEST_CASES_END()\n \t}\n };\n@@ -236,21 +237,6 @@ test_trace(void)\n \treturn unit_test_suite_runner(&trace_tests);\n }\n \n-static int\n-test_trace_dump(void)\n-{\n-\trte_trace_dump(stdout);\n-\treturn 0;\n-}\n-\n-static int\n-test_trace_metadata_dump(void)\n-{\n-\treturn rte_trace_metadata_dump(stdout);\n-}\n-\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \n REGISTER_TEST_COMMAND(trace_autotest, test_trace);\n-REGISTER_TEST_COMMAND(trace_dump, test_trace_dump);\n-REGISTER_TEST_COMMAND(trace_metadata_dump, test_trace_metadata_dump);\ndiff --git a/lib/eal/common/eal_common_trace_ctf.c b/lib/eal/common/eal_common_trace_ctf.c\nindex 335932a271..c6775c3b4d 100644\n--- a/lib/eal/common/eal_common_trace_ctf.c\n+++ b/lib/eal/common/eal_common_trace_ctf.c\n@@ -358,9 +358,6 @@ rte_trace_metadata_dump(FILE *f)\n \tchar *ctf_meta = trace->ctf_meta;\n \tint rc;\n \n-\tif (!rte_trace_is_enabled())\n-\t\treturn 0;\n-\n \tif (ctf_meta == NULL)\n \t\treturn -EINVAL;\n \n", "prefixes": [ "v3", "7/9" ] }