Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118061/?format=api
{ "id": 118061, "url": "http://patches.dpdk.org/api/patches/118061/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221012123112.2951802-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221012123112.2951802-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221012123112.2951802-3-david.marchand@redhat.com", "date": "2022-10-12T12:31:05", "name": "[v3,2/9] trace: fix mode change", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "143257d798724c15a8b1711a86a04315c805730b", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221012123112.2951802-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 25183, "url": "http://patches.dpdk.org/api/series/25183/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25183", "date": "2022-10-12T12:31:03", "name": "Trace subsystem fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/25183/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/118061/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/118061/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3EAF8A00C4;\n\tWed, 12 Oct 2022 14:31:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 49DFB43074;\n\tWed, 12 Oct 2022 14:31:44 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id D5E6843070\n for <dev@dpdk.org>; Wed, 12 Oct 2022 14:31:41 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-614-ROx5gBNKPN63wH6tJm36gg-1; Wed, 12 Oct 2022 08:31:35 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com\n [10.11.54.8])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4FB02382ECE0;\n Wed, 12 Oct 2022 12:31:34 +0000 (UTC)", "from localhost.localdomain (ovpn-193-115.brq.redhat.com\n [10.40.193.115])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 5BB98C8E40E;\n Wed, 12 Oct 2022 12:31:33 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1665577901;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=EX6bedBJRMIFWwVTXxurdlnS3wy6PWSviCKn1ubkE7Y=;\n b=E+JGMP03pN3QpySBWG/zbZ2q6K7awJ7Cb9AbahQl0xGwClipjhEmqsSRcBdLvQyL02doPY\n 1g7uxslRwRgBwEwPSeH4Mls+61YQ4rhvwwqZR5NYbsIdKcdMH97aVNfS9yNPYBlU1mbUwK\n zU5ziuM1yHF/1YNPHPikWkUkDmrhS7s=", "X-MC-Unique": "ROx5gBNKPN63wH6tJm36gg-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com,\n\tskori@marvell.com,\n\tstable@dpdk.org", "Subject": "[PATCH v3 2/9] trace: fix mode change", "Date": "Wed, 12 Oct 2022 14:31:05 +0200", "Message-Id": "<20221012123112.2951802-3-david.marchand@redhat.com>", "In-Reply-To": "<20221012123112.2951802-1-david.marchand@redhat.com>", "References": "<20220921120359.2201131-1-david.marchand@redhat.com>\n <20221012123112.2951802-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The API does not state that changing mode should be refused if no trace\npoint is enabled. Remove this limitation.\n\nFixes: 84c4fae4628f (\"trace: implement operation APIs\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Sunil Kumar Kori <skori@marvell.com>\n---\n app/test/test_trace.c | 3 ---\n lib/eal/common/eal_common_trace.c | 3 ---\n 2 files changed, 6 deletions(-)", "diff": "diff --git a/app/test/test_trace.c b/app/test/test_trace.c\nindex 76af79162b..44ac38a4fa 100644\n--- a/app/test/test_trace.c\n+++ b/app/test/test_trace.c\n@@ -126,9 +126,6 @@ test_trace_mode(void)\n \n \tcurrent = rte_trace_mode_get();\n \n-\tif (!rte_trace_is_enabled())\n-\t\treturn TEST_SKIPPED;\n-\n \trte_trace_mode_set(RTE_TRACE_MODE_DISCARD);\n \tif (rte_trace_mode_get() != RTE_TRACE_MODE_DISCARD)\n \t\tgoto failed;\ndiff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex d5dbc7d667..1b86f5d2d2 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -127,9 +127,6 @@ rte_trace_mode_set(enum rte_trace_mode mode)\n {\n \tstruct trace_point *tp;\n \n-\tif (!rte_trace_is_enabled())\n-\t\treturn;\n-\n \tSTAILQ_FOREACH(tp, &tp_list, next)\n \t\ttrace_mode_set(tp->handle, mode);\n \n", "prefixes": [ "v3", "2/9" ] }