Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 117941,
    "url": "http://patches.dpdk.org/api/patches/117941/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221012025346.204394-4-hernan.vargas@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20221012025346.204394-4-hernan.vargas@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20221012025346.204394-4-hernan.vargas@intel.com",
    "date": "2022-10-12T02:53:19",
    "name": "[v3,03/30] baseband/acc100: memory leak fix",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "6dfefe3119c52229a15e1539802643e1b31ecb30",
    "submitter": {
        "id": 2659,
        "url": "http://patches.dpdk.org/api/people/2659/?format=api",
        "name": "Hernan Vargas",
        "email": "hernan.vargas@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221012025346.204394-4-hernan.vargas@intel.com/mbox/",
    "series": [
        {
            "id": 25150,
            "url": "http://patches.dpdk.org/api/series/25150/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25150",
            "date": "2022-10-12T02:53:16",
            "name": "baseband/acc100: changes for 22.11",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/25150/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/117941/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/117941/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0AC8FA0548;\n\tTue, 11 Oct 2022 20:57:39 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B1FA242B9D;\n\tTue, 11 Oct 2022 20:57:25 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 2740D40146;\n Tue, 11 Oct 2022 20:57:22 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Oct 2022 11:57:21 -0700",
            "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by orsmga006.jf.intel.com with ESMTP; 11 Oct 2022 11:57:20 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1665514642; x=1697050642;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=3/hW9HZKFTnjuI2MxuJE6JxzjnNkV0qjOtdhn77fDOk=;\n b=g6MDHSafQVxRqkp2hgoDHqpniINUK5xmoQMhtAzBvm0xBUwTm+NW0Reo\n s8kDFIAjZyrIkAVdm7w0E2M2GiromjR0XprmKea6rMR5TnQDqxlHIblg5\n FWAf2Mj7oDhLSiNR7m+o524VPoNPCtRe4coKPhPXMWGEJ15vRWRCWHdVO\n xoYZMi6wqNsxFFXifd4ahi/My0RCbx6rewoUIIAcayaMCC++YkwR35Fvz\n F9Q7y5LTdmKxL8w9l7XijkrkCKgpv6Y4FZK4mrGoXVXaselWx31fcyhRg\n 6BHpEm9zD2yq0g6QTzJgKS2cLs7Pylsx1LLIfTnJ9f0d/6E8hjXUyk94U g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6500,9779,10497\"; a=\"284981613\"",
            "E=Sophos;i=\"5.95,177,1661842800\"; d=\"scan'208\";a=\"284981613\"",
            "E=McAfee;i=\"6500,9779,10497\"; a=\"604261516\"",
            "E=Sophos;i=\"5.95,177,1661842800\"; d=\"scan'208\";a=\"604261516\""
        ],
        "X-ExtLoop1": "1",
        "From": "Hernan Vargas <hernan.vargas@intel.com>",
        "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com",
        "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org",
        "Subject": "[PATCH v3 03/30] baseband/acc100: memory leak fix",
        "Date": "Tue, 11 Oct 2022 19:53:19 -0700",
        "Message-Id": "<20221012025346.204394-4-hernan.vargas@intel.com>",
        "X-Mailer": "git-send-email 2.37.1",
        "In-Reply-To": "<20221012025346.204394-1-hernan.vargas@intel.com>",
        "References": "<20221012025346.204394-1-hernan.vargas@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Move check for undefined device before allocating queue data structure.\n\nCoverity issue: 375803, 375813, 375819, 375827, 375831\nFixes: 060e7672930 (\"baseband/acc100: add queue configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/baseband/acc/rte_acc100_pmd.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c\nindex b436bd9078..436af977e4 100644\n--- a/drivers/baseband/acc/rte_acc100_pmd.c\n+++ b/drivers/baseband/acc/rte_acc100_pmd.c\n@@ -662,6 +662,10 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,\n \tstruct acc_queue *q;\n \tint16_t q_idx;\n \n+\tif (d == NULL) {\n+\t\trte_bbdev_log(ERR, \"Undefined device\");\n+\t\treturn -ENODEV;\n+\t}\n \t/* Allocate the queue data structure. */\n \tq = rte_zmalloc_socket(dev->device->driver->name, sizeof(*q),\n \t\t\tRTE_CACHE_LINE_SIZE, conf->socket);\n@@ -669,10 +673,6 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,\n \t\trte_bbdev_log(ERR, \"Failed to allocate queue memory\");\n \t\treturn -ENOMEM;\n \t}\n-\tif (d == NULL) {\n-\t\trte_bbdev_log(ERR, \"Undefined device\");\n-\t\treturn -ENODEV;\n-\t}\n \n \tq->d = d;\n \tq->ring_addr = RTE_PTR_ADD(d->sw_rings, (d->sw_ring_size * queue_id));\n",
    "prefixes": [
        "v3",
        "03/30"
    ]
}