Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117604/?format=api
{ "id": 117604, "url": "http://patches.dpdk.org/api/patches/117604/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221007174336.54354-25-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007174336.54354-25-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007174336.54354-25-andrew.boyer@amd.com", "date": "2022-10-07T17:43:25", "name": "[24/35] net/ionic: add a lookup table for checksum flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "888bacc4a12126a76dac120324a7f022a6d58dde", "submitter": { "id": 2861, "url": "http://patches.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221007174336.54354-25-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25037, "url": "http://patches.dpdk.org/api/series/25037/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25037", "date": "2022-10-07T17:43:01", "name": "net/ionic: updates for 22.11 release", "version": 1, "mbox": "http://patches.dpdk.org/series/25037/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117604/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117604/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 20674A04FD;\n\tFri, 7 Oct 2022 19:47:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CA20E42BA7;\n\tFri, 7 Oct 2022 19:45:02 +0200 (CEST)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2087.outbound.protection.outlook.com [40.107.220.87])\n by mails.dpdk.org (Postfix) with ESMTP id B686C42BD9\n for <dev@dpdk.org>; Fri, 7 Oct 2022 19:44:59 +0200 (CEST)", "from MW4PR03CA0338.namprd03.prod.outlook.com (2603:10b6:303:dc::13)\n by BL1PR12MB5031.namprd12.prod.outlook.com (2603:10b6:208:31a::5)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct\n 2022 17:44:57 +0000", "from CO1NAM11FT068.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:dc:cafe::b0) by MW4PR03CA0338.outlook.office365.com\n (2603:10b6:303:dc::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend\n Transport; Fri, 7 Oct 2022 17:44:57 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT068.mail.protection.outlook.com (10.13.175.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:44:56 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct\n 2022 12:44:54 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=MRFEGHVDPOmg0M/255ZOgFtJM5WoX/Va39zwDxkDEbM4Nyj6DD9jAY1aS/6QsXNy8ttzM8p4Esd+EUNm67tffkB6SR+HI/lkULEu8nimy6uMvdpbXA00r7lsVnwCp7eP2nt/5pWV8kflvkfH/cuvBnztlyE7L15zqKZWWH86+sRpZFuhy/Ilx3QkYUgvNTsYLIWN0iXXRCArDQ/LwldW7K7ay6G+zhu/MP9lGU+OSFH6okO/7i4IkRW0+/gnnX3heJb1qWHr0K50MnUVoXnZoQpfvKsUu3p1/tyctVmseKeWHIcdtEFkw3TzcUqdXDlJTMD/LvvU+ujwj6ImXi7PjQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=gTK7Sor/BMl2wxnOP9118Iy8VLGPVx81QazNn7+qVBc=;\n b=nb9krYG2BfRAJ1flLBqPWGXoWSFD2tUS9X9znnOffd3XG3pJ2WonsGRpkHJ737/ZA5qOimvVraag4mzBPZjKwnyIL4I80O4cnB3qlB4l0OoaKPGR9+pWTzNJtdjrY8NWQZKuZwacM53bQTWlUdRyCdfzyG2vWoi9pZ0j0z5AIGQNX3Oumk1jP8/4bqRjJvQfm/EY/mlbFU2EpiuGbFbT19B5dZRuqLUUOwqAerYLBlGZuz5ihutszVtPAGIk+nygyQpbtKWCqHR4xNValEQ5FdF8hIaJ6Zia51H60uiyJ8yxWzDWWMn3tFM5Hk5T3R6VFLzPJBLo0gBLyyNj6cLD2g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=gTK7Sor/BMl2wxnOP9118Iy8VLGPVx81QazNn7+qVBc=;\n b=j9nN5OqNwiJQnfch193GCYTReWeMapvKeYSxOuZKkVlyBGudyswPC6GsoGkwsHtAvEDM/vq8U/TZTxGwOT8k6f/7gOizv4ieDdZurR3xREbKAbvL3PBPMmQiUxp8eslDUhwTkAvWONFK3OoKuIdcz1ayOxAdzqSGnHjzr9oDi7Y=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH 24/35] net/ionic: add a lookup table for checksum flags", "Date": "Fri, 7 Oct 2022 10:43:25 -0700", "Message-ID": "<20221007174336.54354-25-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221007174336.54354-1-andrew.boyer@amd.com>", "References": "<20221007174336.54354-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT068:EE_|BL1PR12MB5031:EE_", "X-MS-Office365-Filtering-Correlation-Id": "23e82313-d2b4-4172-7730-08daa88ba652", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n w8N3E3SGQxIiw35o2NjaVz94OXWDNshlWLsUt0DYPSdn8PNSaik6cvKgIJ+GQwNfhT+OccWPnfhuQ7vL7B1EWZniqEWHcsR6jIJUxeHCOcwiPjAF1CPZDKl1BFN0rSF1wTAX6E9/5bhx+crWMSDhYr7elnpf2wzR2IOiptQwWgU30tewnl10szRag6emOzfDU9ASRfKbTTIDLJPkS3oHV7ltaSn4N81s03MhID0s2DDvqphU0IhWHdR8an/pJXb2PARZXfxsCLCmuA2qkIzGpv8/JoKnTnC7r+/2hxv8FD0Den0srsCG+0tnH8kGCj7RiEWe6oAMuuZEZWj53IyijKCNH1VmQtw06vpDVv+RiHv+XTu89MFH0JqEWbvMeYU1ctA2YVYFOb2pwoMNAcdkEIdu3q+dNuWkGRLBasXzDjmPj9wwuRaod5vYOoVJ67X1R0xvopJZ7mWajZsOM6XW5xs8VhTlv85kX5YBiIp+4I4YEO+8XffNorsU8wHNwXLQNW2+TBnKUqWsqwhKiNsan2hfE+0/Zt5F0cNhrx1Vq3rC+CEHNH6shB4RQ5ckz24ZtFvOynt7y4ScEIZBGSd4HltIZ9Nrz5hu+pGiQieuCeYlV1VBMggRvpu+iTjPanXGoIzKafl/NOQeBXTUfVi05S62cUOElrtAAevr7GfgCr4NvAEVsb3qE/tSe1gpXWL7TX5jPPbUlPMqUNxfBSEvWV/weSEmTvXa3L+Xg+JAd1oNO4pUyyI4bme4VDyyLubWNe+Da8azMfOGf8VxEyeWlSkxByzlGoXJdITmmEBJa7V4aCmcb7XeMaZ42aECWNpb", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(39860400002)(396003)(376002)(346002)(136003)(451199015)(46966006)(40470700004)(36840700001)(82740400003)(426003)(40460700003)(36860700001)(478600001)(36756003)(356005)(81166007)(82310400005)(44832011)(4326008)(316002)(5660300002)(8676002)(26005)(8936002)(6666004)(41300700001)(2616005)(40480700001)(70586007)(186003)(70206006)(86362001)(47076005)(6916009)(336012)(1076003)(2906002)(16526019)(83380400001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Oct 2022 17:44:56.9126 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 23e82313-d2b4-4172-7730-08daa88ba652", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT068.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL1PR12MB5031", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This improves performance by reducing branching.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n drivers/net/ionic/ionic_rxtx.c | 47 ++++++++++++++++++++++++----------\n 1 file changed, 33 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex bb09c4eb1f..134589b016 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -804,6 +804,36 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \treturn 0;\n }\n \n+#define IONIC_CSUM_FLAG_MASK (IONIC_RXQ_COMP_CSUM_F_VLAN - 1)\n+static const uint64_t ionic_csum_flags[IONIC_CSUM_FLAG_MASK]\n+\t\t__rte_cache_aligned = {\n+\t/* IP_BAD set */\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_BAD] = RTE_MBUF_F_RX_IP_CKSUM_BAD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_BAD | IONIC_RXQ_COMP_CSUM_F_TCP_OK] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_BAD | RTE_MBUF_F_RX_L4_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_BAD | IONIC_RXQ_COMP_CSUM_F_TCP_BAD] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_BAD | RTE_MBUF_F_RX_L4_CKSUM_BAD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_BAD | IONIC_RXQ_COMP_CSUM_F_UDP_OK] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_BAD | RTE_MBUF_F_RX_L4_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_BAD | IONIC_RXQ_COMP_CSUM_F_UDP_BAD] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_BAD | RTE_MBUF_F_RX_L4_CKSUM_BAD,\n+\t/* IP_OK set */\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_OK] = RTE_MBUF_F_RX_IP_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_OK | IONIC_RXQ_COMP_CSUM_F_TCP_OK] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_GOOD | RTE_MBUF_F_RX_L4_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_OK | IONIC_RXQ_COMP_CSUM_F_TCP_BAD] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_GOOD | RTE_MBUF_F_RX_L4_CKSUM_BAD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_OK | IONIC_RXQ_COMP_CSUM_F_UDP_OK] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_GOOD | RTE_MBUF_F_RX_L4_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_IP_OK | IONIC_RXQ_COMP_CSUM_F_UDP_BAD] =\n+\t\t\tRTE_MBUF_F_RX_IP_CKSUM_GOOD | RTE_MBUF_F_RX_L4_CKSUM_BAD,\n+\t/* No IP flag set */\n+\t[IONIC_RXQ_COMP_CSUM_F_TCP_OK] = RTE_MBUF_F_RX_L4_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_TCP_BAD] = RTE_MBUF_F_RX_L4_CKSUM_BAD,\n+\t[IONIC_RXQ_COMP_CSUM_F_UDP_OK] = RTE_MBUF_F_RX_L4_CKSUM_GOOD,\n+\t[IONIC_RXQ_COMP_CSUM_F_UDP_BAD] = RTE_MBUF_F_RX_L4_CKSUM_BAD,\n+};\n+\n /* RTE_PTYPE_UNKNOWN is 0x0 */\n static const uint32_t ionic_ptype_table[IONIC_RXQ_COMP_PKT_TYPE_MASK]\n \t\t__rte_cache_aligned = {\n@@ -836,7 +866,7 @@ ionic_rx_clean_one(struct ionic_rx_qcq *rxq,\n \tuint32_t pkt_type;\n \tuint32_t left, i;\n \tuint16_t cq_desc_len;\n-\tuint8_t ptype;\n+\tuint8_t ptype, cflags;\n \tvoid **info;\n \n \tcq_desc_len = rte_le_to_cpu_16(cq_desc->len);\n@@ -894,19 +924,8 @@ ionic_rx_clean_one(struct ionic_rx_qcq *rxq,\n \n \t/* Checksum */\n \tif (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_CALC) {\n-\t\tif (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_IP_OK)\n-\t\t\tpkt_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;\n-\t\telse if (cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_IP_BAD)\n-\t\t\tpkt_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;\n-\n-\t\tif ((cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_TCP_OK) ||\n-\t\t\t(cq_desc->csum_flags & IONIC_RXQ_COMP_CSUM_F_UDP_OK))\n-\t\t\tpkt_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;\n-\t\telse if ((cq_desc->csum_flags &\n-\t\t\t\tIONIC_RXQ_COMP_CSUM_F_TCP_BAD) ||\n-\t\t\t\t(cq_desc->csum_flags &\n-\t\t\t\tIONIC_RXQ_COMP_CSUM_F_UDP_BAD))\n-\t\t\tpkt_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;\n+\t\tcflags = cq_desc->csum_flags & IONIC_CSUM_FLAG_MASK;\n+\t\tpkt_flags |= ionic_csum_flags[cflags];\n \t}\n \n \trxm->ol_flags = pkt_flags;\n", "prefixes": [ "24/35" ] }