Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117560/?format=api
{ "id": 117560, "url": "http://patches.dpdk.org/api/patches/117560/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221007134653.929034-2-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007134653.929034-2-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007134653.929034-2-ciara.power@intel.com", "date": "2022-10-07T13:46:50", "name": "[v5,1/4] test/crypto: fix wireless auth digest segment", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3a12202aa02ceccf221ac92c0852ad2b38bd9258", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221007134653.929034-2-ciara.power@intel.com/mbox/", "series": [ { "id": 25030, "url": "http://patches.dpdk.org/api/series/25030/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25030", "date": "2022-10-07T13:46:49", "name": "add remaining SGL support to AESNI_MB", "version": 5, "mbox": "http://patches.dpdk.org/series/25030/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117560/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/117560/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A3B8A00C3;\n\tFri, 7 Oct 2022 15:47:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AFED842B82;\n\tFri, 7 Oct 2022 15:47:07 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id AE48D40042\n for <dev@dpdk.org>; Fri, 7 Oct 2022 15:47:05 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Oct 2022 06:47:05 -0700", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.163])\n by orsmga002.jf.intel.com with ESMTP; 07 Oct 2022 06:47:03 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1665150425; x=1696686425;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Kqub+7FKR/7XKv8tN0wbaFn5+qRhVItfGHksWl6lWjc=;\n b=FQsvX8+1rSKugi1gpHtFa78AdHkJK1RYA6oRcn/Fwz0Iohh51zql3EuB\n Rk1O4cGJ0ES73X4X+HVm2Og9GGk8jxw5SPqY25iIUMCGHRCbr7X04iAp+\n hHmgvQ94zjW8YO1F54hxKgIieqTVptGY2dwYBRe23HyDZBqu5S/x8xPcl\n AyEe2iMvXyTJ/1l2EMAq6VZr0Mc1eUhRB4BtMoxCpNe+JD38OUmQ2+K/y\n ZA9rP2OJhRmSTLLtS90M0JoMeiMYjFU9fOHLpS6kA1gGMnlD1e3u6MUMr\n cTyVzzdguBGpv01zhvKo0gwU9mAceIcwm43euB2but8f2pHKZHfM43bW0 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10493\"; a=\"390032310\"", "E=Sophos;i=\"5.95,166,1661842800\"; d=\"scan'208\";a=\"390032310\"", "E=McAfee;i=\"6500,9779,10493\"; a=\"625150221\"", "E=Sophos;i=\"5.95,166,1661842800\"; d=\"scan'208\";a=\"625150221\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "Akhil Goyal <gakhil@marvell.com>,\n\tFan Zhang <royzhang1980@gmail.com>", "Cc": "dev@dpdk.org, kai.ji@intel.com, Ciara Power <ciara.power@intel.com>,\n Fan Zhang <roy.fan.zhang@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Subject": "[PATCH v5 1/4] test/crypto: fix wireless auth digest segment", "Date": "Fri, 7 Oct 2022 13:46:50 +0000", "Message-Id": "<20221007134653.929034-2-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221007134653.929034-1-ciara.power@intel.com>", "References": "<20220812132334.75707-1-ciara.power@intel.com>\n <20221007134653.929034-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The segment size for some tests was too small to hold the auth digest.\nThis caused issues when using op->sym->auth.digest.data for comparisons\nin AESNI_MB PMD after a subsequent patch enables SGL.\n\nFor example, if segment size is 2, and digest size is 4, then 4 bytes\nare read from op->sym->auth.digest.data, which overflows into the memory\nafter the segment, rather than using the second segment that contains\nthe remaining half of the digest.\n\nFixes: 11c5485bb276 (\"test/crypto: add scatter-gather tests for IP and OOP\")\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nAcked-by: Fan Zhang <roy.fan.zhang@intel.com>\nAcked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n\n---\nv4: Added failure check when appending digest size to buffer.\n---\n app/test/test_cryptodev.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex c6d47a035e..203b8b61fa 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -2990,6 +2990,16 @@ create_wireless_algo_auth_cipher_operation(\n \t\t\tremaining_off -= rte_pktmbuf_data_len(sgl_buf);\n \t\t\tsgl_buf = sgl_buf->next;\n \t\t}\n+\n+\t\t/* The last segment should be large enough to hold full digest */\n+\t\tif (sgl_buf->data_len < auth_tag_len) {\n+\t\t\trte_pktmbuf_free(sgl_buf->next);\n+\t\t\tsgl_buf->next = NULL;\n+\t\t\tTEST_ASSERT_NOT_NULL(rte_pktmbuf_append(sgl_buf,\n+\t\t\t\t\tauth_tag_len - sgl_buf->data_len),\n+\t\t\t\t\t\"No room to append auth tag\");\n+\t\t}\n+\n \t\tsym_op->auth.digest.data = rte_pktmbuf_mtod_offset(sgl_buf,\n \t\t\t\tuint8_t *, remaining_off);\n \t\tsym_op->auth.digest.phys_addr = rte_pktmbuf_iova_offset(sgl_buf,\n", "prefixes": [ "v5", "1/4" ] }