Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117437/?format=api
{ "id": 117437, "url": "http://patches.dpdk.org/api/patches/117437/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr>", "list_archive_url": "https://inbox.dpdk.org/dev/20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr", "date": "2022-10-06T07:19:22", "name": "[1/2] drivers: suggestion on meson without version file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "550fbc577bae931ed3e7d0eed2654141b8aff918", "submitter": { "id": 2668, "url": "http://patches.dpdk.org/api/people/2668/?format=api", "name": "Abdullah Ömer Yamaç", "email": "omer.yamac@ceng.metu.edu.tr" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr/mbox/", "series": [ { "id": 25002, "url": "http://patches.dpdk.org/api/series/25002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=25002", "date": "2022-10-06T07:19:22", "name": "[1/2] drivers: suggestion on meson without version file", "version": 1, "mbox": "http://patches.dpdk.org/series/25002/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117437/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117437/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6159AA00C2;\n\tThu, 6 Oct 2022 09:19:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02F674280E;\n\tThu, 6 Oct 2022 09:19:42 +0200 (CEST)", "from guvercin.ceng.metu.edu.tr (guvercin.ceng.metu.edu.tr\n [144.122.171.43])\n by mails.dpdk.org (Postfix) with ESMTP id CB87E41153\n for <dev@dpdk.org>; Thu, 6 Oct 2022 09:19:40 +0200 (CEST)", "from localhost (localhost [127.0.0.1])\n by guvercin.ceng.metu.edu.tr (Postfix) with ESMTP id DC5452C171;\n Thu, 6 Oct 2022 10:19:38 +0300 (+03)", "from guvercin.ceng.metu.edu.tr ([127.0.0.1])\n by localhost (guvercin.ceng.metu.edu.tr [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id iAfGw4AEZzOJ; Thu, 6 Oct 2022 10:19:27 +0300 (+03)", "from dmu.otak.ist (unknown [212.156.37.190])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested) (Authenticated sender: e1885458)\n by guvercin.ceng.metu.edu.tr (Postfix) with ESMTPSA id 1C3222C061;\n Thu, 6 Oct 2022 10:19:25 +0300 (+03)" ], "X-Virus-Scanned": "Debian amavisd-new at ceng.metu.edu.tr", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ceng.metu.edu.tr;\n s=mail; t=1665040767;\n bh=TV71SxeUI1HXwQujbarM6ZBZaeyTeWnlihuCfFT3gS4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=hHZXdY616CY/e+84tHzYaCTkV5AL5058kBXMhbPe+ozhmqEOXje3I+o+Xiw3rBSNf\n o3TAG6HjasfzIZYp1D+2mJBMS+F1xm8ZDGJ7qzDgNJ7RF4gwDMaCFJmsH4x4kQ3jIv\n y8tQWrTGamBUNSonB8kCGk1ctMSS5x/zxYQx6cU4=", "From": "=?utf-8?b?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= <omer.yamac@ceng.metu.edu.tr>", "To": "dev@dpdk.org", "Cc": "=?utf-8?b?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= <omer.yamac@ceng.metu.edu.tr>,\n Ferruh Yigit <ferruh.yigit@amd.com>", "Subject": "[PATCH 1/2] drivers: suggestion on meson without version file", "Date": "Thu, 6 Oct 2022 10:19:22 +0300", "Message-Id": "<20221006071923.755507-1-omer.yamac@ceng.metu.edu.tr>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<Yzvpzz/umhkV7rl5@bricha3-MOBL.ger.corp.intel.com>", "References": "<Yzvpzz/umhkV7rl5@bricha3-MOBL.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Most of the drivers don't have a special version.map file. They just\nincluded due to the compilation issue and needs to be updated for each\nrelease.\n\nThese version.map files include:\nDPDK_23 {\n local: *;\n};\n\nIn this patch, we removed the necessity of the version files and\nyou don't need to update these files for each release, you can just\nremove them.\n\nSigned-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>\nSuggested-by: Ferruh Yigit <ferruh.yigit@amd.com>\n\n---\nDepends on: patch-116222 (\"build: increase minimum meson version to 0.53\")\n---\n drivers/meson.build | 63 ++++++++++++++++++++++++---------------------\n 1 file changed, 34 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex f6ba5ba4fb..6ef03e14c7 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -1,6 +1,8 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017-2019 Intel Corporation\n \n+fs = import('fs')\n+\n # Defines the order of dependencies evaluation\n subdirs = [\n 'common',\n@@ -193,38 +195,41 @@ foreach subpath:subdirs\n version_map = '@0@/@1@/version.map'.format(meson.current_source_dir(), drv_path)\n implib = 'lib' + lib_name + '.dll.a'\n \n- def_file = custom_target(lib_name + '_def',\n- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],\n- input: version_map,\n- output: '@0@_exports.def'.format(lib_name))\n-\n- mingw_map = custom_target(lib_name + '_mingw',\n- command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],\n- input: version_map,\n- output: '@0@_mingw.map'.format(lib_name))\n-\n- lk_deps = [version_map, def_file, mingw_map]\n- if is_windows\n- if is_ms_linker\n- lk_args = ['-Wl,/def:' + def_file.full_path()]\n- if meson.version().version_compare('<0.54.0')\n- lk_args += ['-Wl,/implib:drivers\\\\' + implib]\n+ if fs.is_file(version_map)\n+ def_file = custom_target(lib_name + '_def',\n+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],\n+ input: version_map,\n+ output: '@0@_exports.def'.format(lib_name))\n+\n+ mingw_map = custom_target(lib_name + '_mingw',\n+ command: [map_to_win_cmd, '@INPUT@', '@OUTPUT@'],\n+ input: version_map,\n+ output: '@0@_mingw.map'.format(lib_name))\n+\n+ lk_deps = [version_map, def_file, mingw_map]\n+ if is_windows\n+ if is_ms_linker\n+ lk_args = ['-Wl,/def:' + def_file.full_path()]\n+ if meson.version().version_compare('<0.54.0')\n+ lk_args += ['-Wl,/implib:drivers\\\\' + implib]\n+ endif\n+ else\n+ lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]\n endif\n else\n- lk_args = ['-Wl,--version-script=' + mingw_map.full_path()]\n- endif\n- else\n- lk_args = ['-Wl,--version-script=' + version_map]\n- if developer_mode\n- # on unix systems check the output of the\n- # check-symbols.sh script, using it as a\n- # dependency of the .so build\n- lk_deps += custom_target(lib_name + '.sym_chk',\n- command: [check_symbols, version_map, '@INPUT@'],\n- capture: true,\n- input: static_lib,\n- output: lib_name + '.sym_chk')\n+ lk_args = ['-Wl,--version-script=' + version_map]\n+ if developer_mode\n+ # on unix systems check the output of the\n+ # check-symbols.sh script, using it as a\n+ # dependency of the .so build\n+ lk_deps += custom_target(lib_name + '.sym_chk',\n+ command: [check_symbols, version_map, '@INPUT@'],\n+ capture: true,\n+ input: static_lib,\n+ output: lib_name + '.sym_chk')\n+ endif\n endif\n+\n endif\n \n shared_lib = shared_library(lib_name, sources,\n", "prefixes": [ "1/2" ] }