Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117384/?format=api
{ "id": 117384, "url": "http://patches.dpdk.org/api/patches/117384/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20221005143451.157613-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221005143451.157613-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221005143451.157613-1-bruce.richardson@intel.com", "date": "2022-10-05T14:34:50", "name": "[1/2] kni: flag deprecated status at build time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ce070b0eb04a65afd7f6f468ff651348abe6c8c8", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20221005143451.157613-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 24987, "url": "http://patches.dpdk.org/api/series/24987/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24987", "date": "2022-10-05T14:34:50", "name": "[1/2] kni: flag deprecated status at build time", "version": 1, "mbox": "http://patches.dpdk.org/series/24987/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117384/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/117384/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D992A0542;\n\tWed, 5 Oct 2022 16:35:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF6B940694;\n\tWed, 5 Oct 2022 16:35:14 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 2CBC140143;\n Wed, 5 Oct 2022 16:35:11 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 05 Oct 2022 07:34:58 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.34])\n by orsmga007.jf.intel.com with ESMTP; 05 Oct 2022 07:34:56 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1664980512; x=1696516512;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=5bv2MQ/rbXd0CFFLuEKwuoa9enZduIKpK8u9EDdf4xA=;\n b=LspK+fQPXauuWJM//GI2Biq8SRMJMd/2mbdp4xLIiPKpXRdyKsDwMqpR\n YbkhyM1HTFY0p4waPMfBJ4FTDppXVjNIZJw2JSaGYFjZwII1DmRCZgdqC\n E7Z3qUGKAYue9ItQdRn1XI/FaafmIoHyRkb2hXvRnqtNESepEgrfYf9J3\n ZwGiaDZbFp1b4kMGxMU9n+1I1QXHygE7WGWioOFxTFpC4GhwKIlY51U4f\n ZABAfW0Pc/E51L0j8RMD0Pu7JdfDm3mvjsDFoENEAErsiHNBzduaXyjaD\n u2Nv6nW9Zweb3sfJ7EFrRhT8kBtKyvWCK/fAbG6lHNzPZjnDwZ6IOaJMS A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10491\"; a=\"290419703\"", "E=Sophos;i=\"5.95,161,1661842800\"; d=\"scan'208\";a=\"290419703\"", "E=McAfee;i=\"6500,9779,10491\"; a=\"619480550\"", "E=Sophos;i=\"5.95,161,1661842800\"; d=\"scan'208\";a=\"619480550\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "techboard@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 1/2] kni: flag deprecated status at build time", "Date": "Wed, 5 Oct 2022 15:34:50 +0100", "Message-Id": "<20221005143451.157613-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To ensure all users are aware of KNI's deprecated status at build time\nwe can take the following actions:\n\n1. disable the library by default. It can be re-enabled by setting\n disabled_libs to the empty string (or other string not including\n 'kni')\n\n2. add support for a list of deprecated libs to the lib/meson.build file\n so the error message for KNI being disabled includes the fact that it\n is a deprecated library.\n\n3. for the dependent NIC driver, drivers/net/kni, modify its disabled\n message to also reference the fact that KNI is disabled.\n\nNOTE: This is part of the deprecation process for KNI agreed by the DPDK\ntechnical board.[1]\n\n[1] http://mails.dpdk.org/archives/dev/2022-June/243596.html\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n doc/guides/prog_guide/kernel_nic_interface.rst | 4 ++++\n drivers/net/kni/meson.build | 5 +++++\n lib/meson.build | 7 +++++++\n meson_options.txt | 2 +-\n 4 files changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst\nindex 03b5bca958..6a564f61ca 100644\n--- a/doc/guides/prog_guide/kernel_nic_interface.rst\n+++ b/doc/guides/prog_guide/kernel_nic_interface.rst\n@@ -14,6 +14,10 @@ Kernel NIC Interface\n For an alternative to KNI, that does not require any out-of-tree Linux kernel modules,\n or a custom library, see :ref:`virtio_user_as_exception_path`.\n \n+.. note::\n+\n+ KNI is disabled by default in the DPDK build.\n+ To re-enable the library, remove 'kni' from the \"disable_libs\" meson option when configuring a build.\n \n The DPDK Kernel NIC Interface (KNI) allows userspace applications access to the Linux* control plane.\n \ndiff --git a/drivers/net/kni/meson.build b/drivers/net/kni/meson.build\nindex 2acc989694..2deb2c4166 100644\n--- a/drivers/net/kni/meson.build\n+++ b/drivers/net/kni/meson.build\n@@ -6,6 +6,11 @@ if is_windows\n reason = 'not supported on Windows'\n subdir_done()\n endif\n+if not dpdk_conf.has('kni')\n+ build = false\n+ reason = 'needs deprecated lib, \"kni\"'\n+ subdir_done()\n+endif\n \n deps += 'kni'\n sources = files('rte_eth_kni.c')\ndiff --git a/lib/meson.build b/lib/meson.build\nindex c648f7d800..264a1671df 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -85,6 +85,7 @@ optional_libs = [\n 'vhost',\n ]\n \n+deprecated_libs = ['kni']\n disabled_libs = []\n opt_disabled_libs = run_command(list_dir_globs, get_option('disable_libs'),\n check: true).stdout().split()\n@@ -133,7 +134,13 @@ foreach l:libraries\n if disabled_libs.contains(l)\n build = false\n reason = 'explicitly disabled via build config'\n+ if deprecated_libs.contains(l)\n+ reason += ' (deprecated lib)'\n+ endif\n else\n+ if deprecated_libs.contains(l)\n+ warning('Enabling deprecated library, \"@0@\"'.format(l))\n+ endif\n subdir(l)\n endif\n if name != l\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 8640f599ae..39af78787c 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -8,7 +8,7 @@ option('developer_mode', type: 'feature', description:\n 'turn on additional build checks relevant for DPDK developers')\n option('disable_drivers', type: 'string', value: '', description:\n 'Comma-separated list of drivers to explicitly disable.')\n-option('disable_libs', type: 'string', value: '', description:\n+option('disable_libs', type: 'string', value: 'kni', description:\n 'Comma-separated list of libraries to explicitly disable. [NOTE: not all libs can be disabled]')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', description:\n 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')\n", "prefixes": [ "1/2" ] }