Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117194/?format=api
{ "id": 117194, "url": "http://patches.dpdk.org/api/patches/117194/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-20-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220930072220.20753-20-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220930072220.20753-20-liudongdong3@huawei.com", "date": "2022-09-30T07:22:20", "name": "[19/19] net/hns3: fix the obtaination of minimum Tx frame length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9a75cbbace3881d3b270ff414356fbe0b40e3db2", "submitter": { "id": 2718, "url": "http://patches.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220930072220.20753-20-liudongdong3@huawei.com/mbox/", "series": [ { "id": 24928, "url": "http://patches.dpdk.org/api/series/24928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=24928", "date": "2022-09-30T07:22:03", "name": "some bugfixes and clean code for hns3 - part2", "version": 1, "mbox": "http://patches.dpdk.org/series/24928/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/117194/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/117194/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EA90A034C;\n\tFri, 30 Sep 2022 09:25:55 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B334C42BE0;\n\tFri, 30 Sep 2022 09:24:29 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id A48414282D;\n Fri, 30 Sep 2022 09:24:23 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.54])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Mf1pC5HcZz1P6yq;\n Fri, 30 Sep 2022 15:20:03 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Fri, 30 Sep 2022 15:24:21 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@amd.com>,\n <thomas@monjalon.net>", "CC": "<stable@dpdk.org>, <fengchengwen@huawei.com>, <yisen.zhuang@huawei.com>,\n <liudongdong3@huawei.com>, <lihuisong@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 19/19] net/hns3: fix the obtaination of minimum Tx frame\n length", "Date": "Fri, 30 Sep 2022 15:22:20 +0800", "Message-ID": "<20220930072220.20753-20-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20220930072220.20753-1-liudongdong3@huawei.com>", "References": "<20220930072220.20753-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jie Hai <haijie1@huawei.com>\n\nWhen packet length in Tx is less than length hardware supported,\nthe minimum frame length in hns3 is used to do padding to avoid\nhardware error. Currently, this length is fixed by macro, which\nis very unfavorable for subsequent hardware evolution. So fix it\nas firmware report.\n\nFixes: 395b5e08ef8d (\"net/hns3: add Tx short frame padding compatibility\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n drivers/net/hns3/hns3_cmd.h | 6 ++++++\n drivers/net/hns3/hns3_ethdev.c | 4 +++-\n drivers/net/hns3/hns3_ethdev.h | 3 +--\n drivers/net/hns3/hns3_ethdev_vf.c | 4 +++-\n 4 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h\nindex 8ac8b45819..994dfc48cc 100644\n--- a/drivers/net/hns3/hns3_cmd.h\n+++ b/drivers/net/hns3/hns3_cmd.h\n@@ -967,6 +967,12 @@ struct hns3_dev_specs_0_cmd {\n \tuint32_t max_tm_rate;\n };\n \n+struct hns3_dev_specs_1_cmd {\n+\tuint8_t rsv0[12];\n+\tuint8_t min_tx_pkt_len;\n+\tuint8_t rsv1[11];\n+};\n+\n struct hns3_query_rpu_cmd {\n \tuint32_t tc_queue_num;\n \tuint32_t rsv1[2];\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 60e933998a..813fcedc6a 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -2661,14 +2661,17 @@ static void\n hns3_parse_dev_specifications(struct hns3_hw *hw, struct hns3_cmd_desc *desc)\n {\n \tstruct hns3_dev_specs_0_cmd *req0;\n+\tstruct hns3_dev_specs_1_cmd *req1;\n \n \treq0 = (struct hns3_dev_specs_0_cmd *)desc[0].data;\n+\treq1 = (struct hns3_dev_specs_1_cmd *)desc[1].data;\n \n \thw->max_non_tso_bd_num = req0->max_non_tso_bd_num;\n \thw->rss_ind_tbl_size = rte_le_to_cpu_16(req0->rss_ind_tbl_size);\n \thw->rss_key_size = rte_le_to_cpu_16(req0->rss_key_size);\n \thw->max_tm_rate = rte_le_to_cpu_32(req0->max_tm_rate);\n \thw->intr.int_ql_max = rte_le_to_cpu_16(req0->intr_ql_max);\n+\thw->min_tx_pkt_len = req1->min_tx_pkt_len;\n }\n \n static int\n@@ -2763,7 +2766,6 @@ hns3_get_capability(struct hns3_hw *hw)\n \thw->tso_mode = HNS3_TSO_HW_CAL_PSEUDO_H_CSUM;\n \thw->vlan_mode = HNS3_HW_SHIFT_AND_DISCARD_MODE;\n \thw->drop_stats_mode = HNS3_PKTS_DROP_STATS_MODE2;\n-\thw->min_tx_pkt_len = HNS3_HIP09_MIN_TX_PKT_LEN;\n \tpf->tqp_config_mode = HNS3_FLEX_MAX_TQP_NUM_MODE;\n \thw->rss_info.ipv6_sctp_offload_supported = true;\n \thw->udp_cksum_mode = HNS3_SPECIAL_PORT_HW_CKSUM_MODE;\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 9fe9766736..2457754b3d 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -75,7 +75,6 @@\n #define HNS3_DEFAULT_MTU\t\t1500UL\n #define HNS3_DEFAULT_FRAME_LEN\t\t(HNS3_DEFAULT_MTU + HNS3_ETH_OVERHEAD)\n #define HNS3_HIP08_MIN_TX_PKT_LEN\t33\n-#define HNS3_HIP09_MIN_TX_PKT_LEN\t9\n \n #define HNS3_BITS_PER_BYTE\t8\n \n@@ -550,7 +549,7 @@ struct hns3_hw {\n \t * The minimum length of the packet supported by hardware in the Tx\n \t * direction.\n \t */\n-\tuint32_t min_tx_pkt_len;\n+\tuint8_t min_tx_pkt_len;\n \n \tstruct hns3_queue_intr intr;\n \t/*\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 446a0cdbc7..c1bbcf42b1 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -701,13 +701,16 @@ static void\n hns3vf_parse_dev_specifications(struct hns3_hw *hw, struct hns3_cmd_desc *desc)\n {\n \tstruct hns3_dev_specs_0_cmd *req0;\n+\tstruct hns3_dev_specs_1_cmd *req1;\n \n \treq0 = (struct hns3_dev_specs_0_cmd *)desc[0].data;\n+\treq1 = (struct hns3_dev_specs_1_cmd *)desc[1].data;\n \n \thw->max_non_tso_bd_num = req0->max_non_tso_bd_num;\n \thw->rss_ind_tbl_size = rte_le_to_cpu_16(req0->rss_ind_tbl_size);\n \thw->rss_key_size = rte_le_to_cpu_16(req0->rss_key_size);\n \thw->intr.int_ql_max = rte_le_to_cpu_16(req0->intr_ql_max);\n+\thw->min_tx_pkt_len = req1->min_tx_pkt_len;\n }\n \n static int\n@@ -846,7 +849,6 @@ hns3vf_get_capability(struct hns3_hw *hw)\n \thw->intr.gl_unit = HNS3_INTR_COALESCE_GL_UINT_1US;\n \thw->tso_mode = HNS3_TSO_HW_CAL_PSEUDO_H_CSUM;\n \thw->drop_stats_mode = HNS3_PKTS_DROP_STATS_MODE2;\n-\thw->min_tx_pkt_len = HNS3_HIP09_MIN_TX_PKT_LEN;\n \thw->rss_info.ipv6_sctp_offload_supported = true;\n \thw->promisc_mode = HNS3_LIMIT_PROMISC_MODE;\n \n", "prefixes": [ "19/19" ] }